From patchwork Sat Jun 7 02:53:43 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marcos Paulo de Souza X-Patchwork-Id: 894900 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2762D259C80 for ; Sat, 7 Jun 2025 02:54:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749264847; cv=none; b=qEDPyvcTnxSJrqbCyZOwYGoiOOwJmmRNJJ89sYotbjArYqnWHQ/eECyOb5HtdV4Vfl4pam2hQ5ggyB2rGmsW7/k+loZyjC2PFJlwjn3tCEHDZRqx00mzEG5W5qj6T2MQKVQY0rErkheCxYpJgAvC7TkQaYq1H9+XQnbb9FDibPw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749264847; c=relaxed/simple; bh=8VuAOHFeqx5UMsNpvlh7ZAQit2VLidP6PcKmMQI0hl0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=WWFFDvLF2GWJkA22qxR5iaAtG4uoyTxZNbGZPUaDXqhYwc9Q4K8E6/AlO1XcUlRbR8RSxKJRsg2/dwsKMcJr5KMo7YLE8dOWpKnHykwZ2+oXmiFG1D+hqRr3yzAd112qLQdbsG7IgjfvtwR6CAaRoY99b44ELndC8Oydd0Q/qT8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=C/2/n8az; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="C/2/n8az" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-441d437cfaaso17148625e9.1 for ; Fri, 06 Jun 2025 19:54:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1749264843; x=1749869643; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=079G7lwbZSdbFJvvw8wIKqroIeNsEJYLRsyPP7yIsHs=; b=C/2/n8azwKyJCTLNIgy7LVyV3KtP358RJIYCZzmXVpd+zfxPgWb8+6uQX7Qm2NzQ4a xA/pXilYEqd8T7TsvpqjWF2z6ij7EnqW0GGqJkK9+aSHj+KAfQ97OnISMuDI2E6ktRh8 mjhnITT0yT4YGOM2BmqzGSHK5pViWU7zVRcMAUoIgj+33M6UPEJ9zuLAaH1043OA6jS9 b2lsjGmcFTUci5jWRBy2d4nt5YUVwXj3QIO/0OOx8ceOEACqJVe5JaaV95XSm3lSHKkU 2PhKtFjI0vvEUoAwwQ4QhnkNwuJVzmHewTQDFp4zDQsUbY9X+DQta4qdKYRtuW607yhn N0Xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749264843; x=1749869643; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=079G7lwbZSdbFJvvw8wIKqroIeNsEJYLRsyPP7yIsHs=; b=X0VFcKPORoJp7CXkeRZrnCZnN83x8IUHncZJeZ/LAzfkwZJEOIdFCfx9nAix9sf8Tt DdEo4WLjin6h73I7dwoTZB0Skm73IRRk4Xv39Nb6iC87c1atFafTXRFemTrNNUM22fhr Tw7uv9y/Ac88RS4rR+8iO+0PboqFz/bj7UvXDFM/Go8892M3aOA4nIzvJLFhI4k8tMp9 DubXvUvYTBUCDPTHI+rFo1ulAY87MtGWIK9Y+4thX0a7g4BEENp9VGW8AOUIAxV4KkmB O5yfGQ8l2qzG8LvyIS6Gxteyvnr6xsDsDaYG9S4XUd2A6s7iK74G3qWxohdv0wCIYJj9 Lw6g== X-Forwarded-Encrypted: i=1; AJvYcCWj990o+Q1ikK9nOEpX18pG3RAarFi254VEKGp2pFRGMVZrPGlKjDqPxqx8Utie/PCIHWhov5zngcrK/h8=@vger.kernel.org X-Gm-Message-State: AOJu0YwNuwWt0Fpv31gWmeBWRF2kACjyLs7OBtGMNnyLEdYGAr+qlD8R +IsFRFdi0w2vgN3vfReiAas0ILQAMc6af8l3Q84jL8iShWKtf2qoOBKLqV6yf1Sob8c= X-Gm-Gg: ASbGncu8YSLmJsGtW+Hvef+NDkqBYvLMXlzHFx6XBVLPA374/A74GX5bWyW3EjK7Kkb RZykvMBhU+1gWfiqYXoHbcg0+ZLGkF351gV5TsFNEigkv4dw7iON/dxgD0IAQHKH3T7ESpdUPn6 9FLB0+PXoh+USekwWRtV2ByEaR+q+oa1IbxP3yvCgFt3W/BEvb9wJ9YEjcv7RCcvennvMve+4IQ BroyBBNabvawx8WKBLceHSSvRmoQ36s2gMHmZ7SBH3bNkGPvfGRwHGYycnjJA1rxlkTF+m2OVpn M4w54AEESMhCUDDnozjbUOdFLWh7S+74x6Ns6JwhcgXN8yOLBRboK0mvVKo= X-Google-Smtp-Source: AGHT+IEFMaOycz8paZH8Dwc7eB8/xeQCEwaltIN87YJjZdoV9BEkV0ZK9L7/PCQxBolImcH3wDz9CQ== X-Received: by 2002:a05:600c:8b08:b0:440:9b1a:cd78 with SMTP id 5b1f17b1804b1-4520141635bmr68757385e9.10.1749264843376; Fri, 06 Jun 2025 19:54:03 -0700 (PDT) Received: from [127.0.0.1] ([2804:5078:80f:b600:58f2:fc97:371f:2]) by smtp.gmail.com with ESMTPSA id 71dfb90a1353d-530e6429475sm2005465e0c.45.2025.06.06.19.53.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Jun 2025 19:54:02 -0700 (PDT) From: Marcos Paulo de Souza Date: Fri, 06 Jun 2025 23:53:43 -0300 Subject: [PATCH 1/7] printk: Make console_{suspend,resume} handle CON_SUSPENDED Precedence: bulk X-Mailing-List: linux-serial@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250606-printk-cleanup-part2-v1-1-f427c743dda0@suse.com> References: <20250606-printk-cleanup-part2-v1-0-f427c743dda0@suse.com> In-Reply-To: <20250606-printk-cleanup-part2-v1-0-f427c743dda0@suse.com> To: Petr Mladek , Steven Rostedt , John Ogness , Sergey Senozhatsky , Greg Kroah-Hartman , Jiri Slaby , Jason Wessel , Daniel Thompson , Douglas Anderson , Richard Weinberger , Anton Ivanov , Johannes Berg Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, kgdb-bugreport@lists.sourceforge.net, linux-um@lists.infradead.org, Marcos Paulo de Souza X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1749264832; l=1467; i=mpdesouza@suse.com; s=20231031; h=from:subject:message-id; bh=8VuAOHFeqx5UMsNpvlh7ZAQit2VLidP6PcKmMQI0hl0=; b=T3wYMARjrMBrnSS0B53XQkjL8a0KEFURCPDHgsLUslXubhtqe5kSsdH3AVNiC4itsQepzSKEL bCiOgTyAtZ1BpRW6LdXAAFDz3h5mWwilxfoY0pptQZniRHvG6Kc9OCL X-Developer-Key: i=mpdesouza@suse.com; a=ed25519; pk=/Ni/TsKkr69EOmdZXkp1Q/BlzDonbOBRsfPa18ySIwU= Since commit 9e70a5e109a4 ("printk: Add per-console suspended state") the CON_SUSPENDED flag was introced, and this flag was being checked on console_is_usable function, which returns false if the console is suspended. No functional changes. Signed-off-by: Marcos Paulo de Souza --- kernel/printk/printk.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c index 1eea80d0648ed3583375cce3dfe60407894d659c..6d3cf488f4261a3dfd8809a5ab7164b218238c13 100644 --- a/kernel/printk/printk.c +++ b/kernel/printk/printk.c @@ -3530,7 +3530,7 @@ void console_suspend(struct console *console) { __pr_flush(console, 1000, true); console_list_lock(); - console_srcu_write_flags(console, console->flags & ~CON_ENABLED); + console_srcu_write_flags(console, console->flags | CON_SUSPENDED); console_list_unlock(); /* @@ -3543,13 +3543,14 @@ void console_suspend(struct console *console) } EXPORT_SYMBOL(console_suspend); +/* Unset CON_SUSPENDED flag so the console can start printing again. */ void console_resume(struct console *console) { struct console_flush_type ft; bool is_nbcon; console_list_lock(); - console_srcu_write_flags(console, console->flags | CON_ENABLED); + console_srcu_write_flags(console, console->flags & ~CON_SUSPENDED); is_nbcon = console->flags & CON_NBCON; console_list_unlock();