From patchwork Wed Nov 9 10:39:14 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 4969 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id 0127823E0E for ; Wed, 9 Nov 2011 10:39:32 +0000 (UTC) Received: from mail-fx0-f52.google.com (mail-fx0-f52.google.com [209.85.161.52]) by fiordland.canonical.com (Postfix) with ESMTP id EA265A180D5 for ; Wed, 9 Nov 2011 10:39:31 +0000 (UTC) Received: by mail-fx0-f52.google.com with SMTP id n26so2131830faa.11 for ; Wed, 09 Nov 2011 02:39:31 -0800 (PST) Received: by 10.152.109.199 with SMTP id hu7mr1133700lab.16.1320835171714; Wed, 09 Nov 2011 02:39:31 -0800 (PST) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.152.10.72 with SMTP id g8cs163014lab; Wed, 9 Nov 2011 02:39:31 -0800 (PST) Received: by 10.14.17.84 with SMTP id i60mr126628eei.190.1320835170012; Wed, 09 Nov 2011 02:39:30 -0800 (PST) Received: from eu1sys200aog111.obsmtp.com (eu1sys200aog111.obsmtp.com. [207.126.144.131]) by mx.google.com with SMTP id o47si1082109eeb.102.2011.11.09.02.39.21 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 09 Nov 2011 02:39:30 -0800 (PST) Received-SPF: neutral (google.com: 207.126.144.131 is neither permitted nor denied by best guess record for domain of linus.walleij@stericsson.com) client-ip=207.126.144.131; Authentication-Results: mx.google.com; spf=neutral (google.com: 207.126.144.131 is neither permitted nor denied by best guess record for domain of linus.walleij@stericsson.com) smtp.mail=linus.walleij@stericsson.com Received: from beta.dmz-eu.st.com ([164.129.1.35]) (using TLSv1) by eu1sys200aob111.postini.com ([207.126.147.11]) with SMTP ID DSNKTrpYWWn3e6vIBtTKyHJRfkFwJJmGZe/l@postini.com; Wed, 09 Nov 2011 10:39:29 UTC Received: from zeta.dmz-eu.st.com (zeta.dmz-eu.st.com [164.129.230.9]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 8AF5D129; Wed, 9 Nov 2011 10:39:17 +0000 (GMT) Received: from relay1.stm.gmessaging.net (unknown [10.230.100.17]) by zeta.dmz-eu.st.com (STMicroelectronics) with ESMTP id F28572B37; Wed, 9 Nov 2011 10:39:16 +0000 (GMT) Received: from exdcvycastm003.EQ1STM.local (alteon-source-exch [10.230.100.61]) (using TLSv1 with cipher RC4-MD5 (128/128 bits)) (Client CN "exdcvycastm003", Issuer "exdcvycastm003" (not verified)) by relay1.stm.gmessaging.net (Postfix) with ESMTPS id 4DDAA24C2F3; Wed, 9 Nov 2011 11:39:11 +0100 (CET) Received: from localhost.localdomain (10.230.100.153) by smtp.stericsson.com (10.230.100.1) with Microsoft SMTP Server (TLS) id 8.3.83.0; Wed, 9 Nov 2011 11:39:16 +0100 From: Linus Walleij To: Grant Likely , Cc: , Viresh Kumar , Virupax Sadashivpetimath , Linus Walleij Subject: [PATCH 4/6] spi/pl022: skip default configuration before suspending Date: Wed, 9 Nov 2011 11:39:14 +0100 Message-ID: <1320835154-31303-1-git-send-email-linus.walleij@stericsson.com> X-Mailer: git-send-email 1.7.3.2 MIME-Version: 1.0 From: Virupax Sadashivpetimath The loading of the default configuration before suspending has been in the driver since its inception, but it is not really needed. Especially so since we take to all the trouble of enabling and disabling power and clock just to do this. Let's scrap this now. Signed-off-by: Virupax Sadashivpetimath Signed-off-by: Linus Walleij --- drivers/spi/spi-pl022.c | 7 +------ 1 files changed, 1 insertions(+), 6 deletions(-) diff --git a/drivers/spi/spi-pl022.c b/drivers/spi/spi-pl022.c index fa3eaae..bffad2a 100644 --- a/drivers/spi/spi-pl022.c +++ b/drivers/spi/spi-pl022.c @@ -2314,12 +2314,7 @@ static int pl022_suspend(struct device *dev) return status; } - amba_vcore_enable(pl022->adev); - amba_pclk_enable(pl022->adev); - load_ssp_default_config(pl022); - amba_pclk_disable(pl022->adev); - amba_vcore_disable(pl022->adev); - dev_dbg(dev, "suspended\n"); + dev_dbg(&adev->dev, "suspended\n"); return 0; }