| Message ID | 20230404060011.108561-3-jaewon02.kim@samsung.com |
|---|---|
| State | New |
| Headers | show |
| Series | [1/3] spi: s3c64xx: support spi polling mode using devicetree | expand |
On Tue, 04 Apr 2023 15:00:10 +0900, Jaewon Kim wrote: > This patch adds "samsung,spi-polling" property. > It is method to check data trans by polling when DMA is not used. > > Signed-off-by: Jaewon Kim <jaewon02.kim@samsung.com> > --- > Documentation/devicetree/bindings/spi/samsung,spi.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/spi/samsung,spi.yaml: properties:samsung,spi-polling: 'oneOf' conditional failed, one must be fixed: Additional properties are not allowed ('default' was unexpected) hint: A vendor boolean property can use "type: boolean" /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/spi/samsung,spi.yaml: properties:samsung,spi-polling: 'oneOf' conditional failed, one must be fixed: 'enum' is a required property 'const' is a required property hint: A vendor string property with exact values has an implicit type from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml# Additional properties are not allowed ('default', 'type' were unexpected) hint: A vendor string property with exact values has an implicit type /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/spi/samsung,spi.yaml: properties:samsung,spi-polling: 'oneOf' conditional failed, one must be fixed: '$ref' is a required property 'allOf' is a required property hint: A vendor property needs a $ref to types.yaml from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml# hint: Vendor specific properties must have a type and description unless they have a defined, common suffix. from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml# ./Documentation/devicetree/bindings/soc/samsung/exynos-usi.yaml: Error in referenced schema matching $id: http://devicetree.org/schemas/spi/samsung,spi.yaml doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230404060011.108561-3-jaewon02.kim@samsung.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
diff --git a/Documentation/devicetree/bindings/spi/samsung,spi.yaml b/Documentation/devicetree/bindings/spi/samsung,spi.yaml index e0a465d70b0a..b4942fe160f2 100644 --- a/Documentation/devicetree/bindings/spi/samsung,spi.yaml +++ b/Documentation/devicetree/bindings/spi/samsung,spi.yaml @@ -69,6 +69,12 @@ properties: $ref: /schemas/types.yaml#/definitions/uint32 default: 0 + samsung,spi-polling: + description: + Polling SPI data without DMA transfer. + type: boolean + default: 0 + reg: maxItems: 1
This patch adds "samsung,spi-polling" property. It is method to check data trans by polling when DMA is not used. Signed-off-by: Jaewon Kim <jaewon02.kim@samsung.com> --- Documentation/devicetree/bindings/spi/samsung,spi.yaml | 6 ++++++ 1 file changed, 6 insertions(+)