| Message ID | 20240125145007.748295-14-tudor.ambarus@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | spi: s3c64xx: winter cleanup and gs101 support | expand |
On Thu, Jan 25, 2024 at 8:50 AM Tudor Ambarus <tudor.ambarus@linaro.org> wrote: > > Propagate the dma_submit_error() error code, don't overwrite it. But why? What would be the benefit over -EIO? > > Signed-off-by: Tudor Ambarus <tudor.ambarus@linaro.org> > --- > drivers/spi/spi-s3c64xx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c > index 48b87c5e2dd2..25d642f99278 100644 > --- a/drivers/spi/spi-s3c64xx.c > +++ b/drivers/spi/spi-s3c64xx.c > @@ -316,7 +316,7 @@ static int prepare_dma(struct s3c64xx_spi_dma_data *dma, > ret = dma_submit_error(dma->cookie); > if (ret) { > dev_err(&sdd->pdev->dev, "DMA submission failed"); > - return -EIO; > + return ret; > } > > dma_async_issue_pending(dma->ch); > -- > 2.43.0.429.g432eaa2c6b-goog >
On 1/25/24 20:23, Sam Protsenko wrote: > On Thu, Jan 25, 2024 at 8:50 AM Tudor Ambarus <tudor.ambarus@linaro.org> wrote: >> >> Propagate the dma_submit_error() error code, don't overwrite it. > > But why? What would be the benefit over -EIO I'd like to see why dma submit fail rather than "oh, it's an EIO". DMA submit should just add the dma descriptor to a queue, without firing it, thus EIO looks very wrong here, and it's misleading. > >> >> Signed-off-by: Tudor Ambarus <tudor.ambarus@linaro.org> >> --- >> drivers/spi/spi-s3c64xx.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c >> index 48b87c5e2dd2..25d642f99278 100644 >> --- a/drivers/spi/spi-s3c64xx.c >> +++ b/drivers/spi/spi-s3c64xx.c >> @@ -316,7 +316,7 @@ static int prepare_dma(struct s3c64xx_spi_dma_data *dma, >> ret = dma_submit_error(dma->cookie); >> if (ret) { >> dev_err(&sdd->pdev->dev, "DMA submission failed"); >> - return -EIO; >> + return ret; >> } >> >> dma_async_issue_pending(dma->ch); >> -- >> 2.43.0.429.g432eaa2c6b-goog >>
diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index 48b87c5e2dd2..25d642f99278 100644 --- a/drivers/spi/spi-s3c64xx.c +++ b/drivers/spi/spi-s3c64xx.c @@ -316,7 +316,7 @@ static int prepare_dma(struct s3c64xx_spi_dma_data *dma, ret = dma_submit_error(dma->cookie); if (ret) { dev_err(&sdd->pdev->dev, "DMA submission failed"); - return -EIO; + return ret; } dma_async_issue_pending(dma->ch);
Propagate the dma_submit_error() error code, don't overwrite it. Signed-off-by: Tudor Ambarus <tudor.ambarus@linaro.org> --- drivers/spi/spi-s3c64xx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)