| Message ID | 20250103060407.1064107-2-va@nvidia.com |
|---|---|
| State | New |
| Headers | show |
| Series | Configure Clocks, Add Native Dma support. | expand |
On Fri, Jan 03, 2025 at 06:04:02AM +0000, Vishwaroop A wrote: > Set QSPI0_2X_PM to 199.99 MHz and QSPI0_PM to 99.99 MHz using > PLLC as the parent clock. These frequencies allow Quad IO DT > reads up to 99.99 MHz, which is the fastest that can be > achieved considering various PLL and clock divider constraints. > > Populate the DMA and IOMMU properties for the Tegra234 QSPI devices to > enable DMA support. > > Change-Id: I1dded904aa8e0f278c89998481e829f1ce474e8c > Signed-off-by: Vishwaroop A <va@nvidia.com> > --- > arch/arm64/boot/dts/nvidia/tegra234.dtsi | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/arch/arm64/boot/dts/nvidia/tegra234.dtsi b/arch/arm64/boot/dts/nvidia/tegra234.dtsi > index 984c85eab41a..96d0f13390ae 100644 > --- a/arch/arm64/boot/dts/nvidia/tegra234.dtsi > +++ b/arch/arm64/boot/dts/nvidia/tegra234.dtsi > @@ -2948,6 +2948,13 @@ > <&bpmp TEGRA234_CLK_QSPI0_PM>; > clock-names = "qspi", "qspi_out"; > resets = <&bpmp TEGRA234_RESET_QSPI0>; > + assigned-clocks = <&bpmp TEGRA234_CLK_QSPI0_2X_PM>, > + <&bpmp TEGRA234_CLK_QSPI0_PM>; > + assigned-clock-rates = <199999999 99999999>; > + assigned-clock-parents = <&bpmp TEGRA234_CLK_PLLC>; > + dma-names = "rx", "tx"; > + dma-coherent; > + iommus = <&smmu_niso1 TEGRA234_SID_QSPI0>; > status = "disabled"; > }; > > @@ -3031,6 +3038,13 @@ > <&bpmp TEGRA234_CLK_QSPI1_PM>; > clock-names = "qspi", "qspi_out"; > resets = <&bpmp TEGRA234_RESET_QSPI1>; > + assigned-clocks = <&bpmp TEGRA234_CLK_QSPI1_2X_PM>, > + <&bpmp TEGRA234_CLK_QSPI1_PM>; > + assigned-clock-rates = <199999999 99999999>; > + assigned-clock-parents = <&bpmp TEGRA234_CLK_PLLC>; > + dma-names = "rx", "tx"; > + dma-coherent; > + iommus = <&smmu_niso1 TEGRA234_SID_QSPI1>; > status = "disabled"; > }; > It looks like these are missing the "dmas" properties that go along with "dma-names". Thierry
On Wed, 12 Feb 2025 14:46:45 +0000, Vishwaroop A wrote: > This patch series configures qspi clocks, fixes combined sequence > programming and introduces native dma support. > > Vishwaroop A (6): > arm64: tegra: Configure QSPI clocks and add DMA > spi: tegra210-quad: Update dummy sequence configuration > spi: tegra210-quad: Fix X1_X2_X4 encoding and support x4 transfers > spi: tegra210-quad: remove redundant error handling code > spi: tegra210-quad: modify chip select (CS) deactivation > spi: tegra210-quad: Introduce native DMA support > > arch/arm64/boot/dts/nvidia/tegra234.dtsi | 14 ++ > drivers/spi/spi-tegra210-quad.c | 273 +++++++++++++---------- > 2 files changed, 174 insertions(+), 113 deletions(-) > > --- > v1 -> v2: > * Removed Change-IDs from the patches. > * Addressed kernel test bot warnings. > --- > -- > 2.17.1 > > > My bot found new DTB warnings on the .dts files added or changed in this series. Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platform maintainer has comments. If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date: pip3 install dtschema --upgrade New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/nvidia/' for 20250212144651.2433086-1-va@nvidia.com: arch/arm64/boot/dts/nvidia/tegra234-sim-vdk.dtb: spi@3270000: 'dmas' is a dependency of 'dma-names' from schema $id: http://devicetree.org/schemas/dma/dma.yaml# arch/arm64/boot/dts/nvidia/tegra234-p3768-0000+p3767-0000.dtb: spi@3270000: Unevaluated properties are not allowed ('dma-coherent', 'iommus' were unexpected) from schema $id: http://devicetree.org/schemas/spi/nvidia,tegra210-quad.yaml# arch/arm64/boot/dts/nvidia/tegra234-p3768-0000+p3767-0000.dtb: spi@3270000: 'dmas' is a dependency of 'dma-names' from schema $id: http://devicetree.org/schemas/dma/dma.yaml# arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0008.dtb: spi@3270000: Unevaluated properties are not allowed ('dma-coherent', 'iommus' were unexpected) from schema $id: http://devicetree.org/schemas/spi/nvidia,tegra210-quad.yaml# arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0008.dtb: spi@3270000: 'dmas' is a dependency of 'dma-names' from schema $id: http://devicetree.org/schemas/dma/dma.yaml# arch/arm64/boot/dts/nvidia/tegra234-sim-vdk.dtb: spi@3300000: 'dmas' is a dependency of 'dma-names' from schema $id: http://devicetree.org/schemas/dma/dma.yaml# arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0000.dtb: spi@3270000: Unevaluated properties are not allowed ('dma-coherent', 'iommus' were unexpected) from schema $id: http://devicetree.org/schemas/spi/nvidia,tegra210-quad.yaml# arch/arm64/boot/dts/nvidia/tegra234-p3768-0000+p3767-0005.dtb: spi@3270000: Unevaluated properties are not allowed ('dma-coherent', 'iommus' were unexpected) from schema $id: http://devicetree.org/schemas/spi/nvidia,tegra210-quad.yaml# arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0000.dtb: spi@3270000: 'dmas' is a dependency of 'dma-names' from schema $id: http://devicetree.org/schemas/dma/dma.yaml# arch/arm64/boot/dts/nvidia/tegra234-p3768-0000+p3767-0005.dtb: spi@3270000: 'dmas' is a dependency of 'dma-names' from schema $id: http://devicetree.org/schemas/dma/dma.yaml# arch/arm64/boot/dts/nvidia/tegra234-p3740-0002+p3701-0008.dtb: spi@3270000: Unevaluated properties are not allowed ('dma-coherent', 'iommus' were unexpected) from schema $id: http://devicetree.org/schemas/spi/nvidia,tegra210-quad.yaml# arch/arm64/boot/dts/nvidia/tegra234-p3768-0000+p3767-0000.dtb: spi@3300000: 'dmas' is a dependency of 'dma-names' from schema $id: http://devicetree.org/schemas/dma/dma.yaml# arch/arm64/boot/dts/nvidia/tegra234-p3740-0002+p3701-0008.dtb: spi@3270000: 'dmas' is a dependency of 'dma-names' from schema $id: http://devicetree.org/schemas/dma/dma.yaml# arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0008.dtb: spi@3300000: 'dmas' is a dependency of 'dma-names' from schema $id: http://devicetree.org/schemas/dma/dma.yaml# arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0000.dtb: spi@3300000: 'dmas' is a dependency of 'dma-names' from schema $id: http://devicetree.org/schemas/dma/dma.yaml# arch/arm64/boot/dts/nvidia/tegra234-p3768-0000+p3767-0005.dtb: spi@3300000: 'dmas' is a dependency of 'dma-names' from schema $id: http://devicetree.org/schemas/dma/dma.yaml# arch/arm64/boot/dts/nvidia/tegra234-p3740-0002+p3701-0008.dtb: spi@3300000: 'dmas' is a dependency of 'dma-names' from schema $id: http://devicetree.org/schemas/dma/dma.yaml#
diff --git a/arch/arm64/boot/dts/nvidia/tegra234.dtsi b/arch/arm64/boot/dts/nvidia/tegra234.dtsi index 984c85eab41a..96d0f13390ae 100644 --- a/arch/arm64/boot/dts/nvidia/tegra234.dtsi +++ b/arch/arm64/boot/dts/nvidia/tegra234.dtsi @@ -2948,6 +2948,13 @@ <&bpmp TEGRA234_CLK_QSPI0_PM>; clock-names = "qspi", "qspi_out"; resets = <&bpmp TEGRA234_RESET_QSPI0>; + assigned-clocks = <&bpmp TEGRA234_CLK_QSPI0_2X_PM>, + <&bpmp TEGRA234_CLK_QSPI0_PM>; + assigned-clock-rates = <199999999 99999999>; + assigned-clock-parents = <&bpmp TEGRA234_CLK_PLLC>; + dma-names = "rx", "tx"; + dma-coherent; + iommus = <&smmu_niso1 TEGRA234_SID_QSPI0>; status = "disabled"; }; @@ -3031,6 +3038,13 @@ <&bpmp TEGRA234_CLK_QSPI1_PM>; clock-names = "qspi", "qspi_out"; resets = <&bpmp TEGRA234_RESET_QSPI1>; + assigned-clocks = <&bpmp TEGRA234_CLK_QSPI1_2X_PM>, + <&bpmp TEGRA234_CLK_QSPI1_PM>; + assigned-clock-rates = <199999999 99999999>; + assigned-clock-parents = <&bpmp TEGRA234_CLK_PLLC>; + dma-names = "rx", "tx"; + dma-coherent; + iommus = <&smmu_niso1 TEGRA234_SID_QSPI1>; status = "disabled"; };
Set QSPI0_2X_PM to 199.99 MHz and QSPI0_PM to 99.99 MHz using PLLC as the parent clock. These frequencies allow Quad IO DT reads up to 99.99 MHz, which is the fastest that can be achieved considering various PLL and clock divider constraints. Populate the DMA and IOMMU properties for the Tegra234 QSPI devices to enable DMA support. Change-Id: I1dded904aa8e0f278c89998481e829f1ce474e8c Signed-off-by: Vishwaroop A <va@nvidia.com> --- arch/arm64/boot/dts/nvidia/tegra234.dtsi | 14 ++++++++++++++ 1 file changed, 14 insertions(+)