From patchwork Sun Jan 18 02:04:26 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mathieu Poirier X-Patchwork-Id: 43269 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-we0-f198.google.com (mail-we0-f198.google.com [74.125.82.198]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id EBE91240BA for ; Sun, 18 Jan 2015 02:05:42 +0000 (UTC) Received: by mail-we0-f198.google.com with SMTP id q58sf1988598wes.1 for ; Sat, 17 Jan 2015 18:05:42 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:in-reply-to:references:sender:precedence:list-id :x-original-sender:x-original-authentication-results:mailing-list :list-post:list-help:list-archive:list-unsubscribe; bh=uf7IwWZ/R9aCfcLzZPrHXW5sRo0kSLdJQsGdK5BVmfw=; b=ROU04URhzZ6MUaE4mJNWyvoyXm3IvcCx0hU5IxZzrMuF+Z4fAgXqvqlD5MFDzPWr1i BvrlvzVJ9V5Yz/rDAOgA9lCJRksxD8wNbCtHAvjnXqyOlNIj8RTsgkZAZP3YyQeTRxZY 4sSSPCZRT+1f4RVcKZ14Cr4FBhYQKtx8S7FcitlTQSMxb9hcUHqruukSZMVbrpe2Xevm KKT4Z3Aw9ZRqgPWPgzaADQiGFjED3h76IdIpdyFXp0czYbjU1ljw/t4WWo/zt7qPDwBt n2K6WAj4Iun6VQOHxPQMJRdlv26kPOPnjr6EJRTSjKeXayEaS16RdxQacrsoTU2jgdBp rkvw== X-Gm-Message-State: ALoCoQkeu8U3MEwZterjoCUnNSWyrtuDrSsG6kYRAh1fbpYOyVbDHKUKY8WS9J8JnlReL2aO8hlQ X-Received: by 10.180.108.165 with SMTP id hl5mr1234404wib.7.1421546742282; Sat, 17 Jan 2015 18:05:42 -0800 (PST) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.204.104 with SMTP id kx8ls465483lac.82.gmail; Sat, 17 Jan 2015 18:05:41 -0800 (PST) X-Received: by 10.152.45.65 with SMTP id k1mr23270292lam.14.1421546741730; Sat, 17 Jan 2015 18:05:41 -0800 (PST) Received: from mail-la0-f41.google.com (mail-la0-f41.google.com. [209.85.215.41]) by mx.google.com with ESMTPS id r2si8322524lar.126.2015.01.17.18.05.41 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sat, 17 Jan 2015 18:05:41 -0800 (PST) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.41 as permitted sender) client-ip=209.85.215.41; Received: by mail-la0-f41.google.com with SMTP id hv19so24024351lab.0 for ; Sat, 17 Jan 2015 18:05:41 -0800 (PST) X-Received: by 10.152.18.135 with SMTP id w7mr22234695lad.47.1421546741630; Sat, 17 Jan 2015 18:05:41 -0800 (PST) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.9.200 with SMTP id c8csp716292lbb; Sat, 17 Jan 2015 18:05:40 -0800 (PST) X-Received: by 10.66.155.170 with SMTP id vx10mr33869832pab.137.1421546739405; Sat, 17 Jan 2015 18:05:39 -0800 (PST) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id lo1si10704446pab.201.2015.01.17.18.05.38; Sat, 17 Jan 2015 18:05:39 -0800 (PST) Received-SPF: none (google.com: linux-kernel-owner@vger.kernel.org does not designate permitted sender hosts) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752304AbbARCFV (ORCPT + 28 others); Sat, 17 Jan 2015 21:05:21 -0500 Received: from mail-pa0-f48.google.com ([209.85.220.48]:47278 "EHLO mail-pa0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751936AbbARCE7 (ORCPT ); Sat, 17 Jan 2015 21:04:59 -0500 Received: by mail-pa0-f48.google.com with SMTP id rd3so31616740pab.7 for ; Sat, 17 Jan 2015 18:04:59 -0800 (PST) X-Received: by 10.70.49.99 with SMTP id t3mr33706162pdn.105.1421546699294; Sat, 17 Jan 2015 18:04:59 -0800 (PST) Received: from t430.cg.shawcable.net (S0106002369de4dac.cg.shawcable.net. [70.73.24.112]) by mx.google.com with ESMTPSA id zk9sm7852666pac.1.2015.01.17.18.04.58 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 17 Jan 2015 18:04:58 -0800 (PST) From: mathieu.poirier@linaro.org To: forest@alittletooquiet.net, gregkh@linuxfoundation.org Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, mathieu.poirier@linaro.org Subject: [PATCH 4/4] staging: vt6655: correcting parameter related sparse error Date: Sat, 17 Jan 2015 19:04:26 -0700 Message-Id: <1421546666-21461-5-git-send-email-mathieu.poirier@linaro.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1421546666-21461-1-git-send-email-mathieu.poirier@linaro.org> References: <1421546666-21461-1-git-send-email-mathieu.poirier@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: mathieu.poirier@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.41 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , From: Mathieu Poirier mpoirier@t430:~/work/kernel1$ make C=1 M=drivers/staging/vt6655/ LD drivers/staging/vt6655/built-in.o CHECK drivers/staging/vt6655/device_main.c drivers/staging/vt6655/device_main.c:1503:25: warning: incorrect type in argument 1 (different address spaces) drivers/staging/vt6655/device_main.c:1503:25: expected void [noderef] * drivers/staging/vt6655/device_main.c:1503:25: got struct vnt_private * drivers/staging/vt6655/device_main.c:1503:25: warning: incorrect type in argument 2 (different address spaces) drivers/staging/vt6655/device_main.c:1503:25: expected void [noderef] * drivers/staging/vt6655/device_main.c:1503:25: got struct vnt_private * drivers/staging/vt6655/device_main.c:1505:25: warning: incorrect type in argument 1 (different address spaces) drivers/staging/vt6655/device_main.c:1505:25: expected void [noderef] * drivers/staging/vt6655/device_main.c:1505:25: got struct vnt_private * drivers/staging/vt6655/device_main.c:1505:25: warning: incorrect type in argument 2 (different address spaces) drivers/staging/vt6655/device_main.c:1505:25: expected void [noderef] * drivers/staging/vt6655/device_main.c:1505:25: got struct vnt_private * In this case a pointer to "struct vnt_private" is given to macros @MACvRegBitsOn() and @MACvRegBitsOff(). These in turn eventually call @ioread8(), which take a "void __iomem *" as parameter. The first field of "struct vnt_private" is a pointer to a "struct pci_dev", whose first field is a "struct list_head". Correcting the problem by following the trend set fort in every other calls to the macros by passing "->PortOffset", declared as "void __iomem *". Signed-off-by: Mathieu Poirier --- drivers/staging/vt6655/device_main.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655/device_main.c index a3f5cd84259a..951ea5321d61 100644 --- a/drivers/staging/vt6655/device_main.c +++ b/drivers/staging/vt6655/device_main.c @@ -1500,9 +1500,11 @@ static void vnt_bss_info_changed(struct ieee80211_hw *hw, if (conf->enable_beacon) { vnt_beacon_enable(priv, vif, conf); - MACvRegBitsOn(priv, MAC_REG_TCR, TCR_AUTOBCNTX); + MACvRegBitsOn(priv->PortOffset, + MAC_REG_TCR, TCR_AUTOBCNTX); } else { - MACvRegBitsOff(priv, MAC_REG_TCR, TCR_AUTOBCNTX); + MACvRegBitsOff(priv->PortOffset, + MAC_REG_TCR, TCR_AUTOBCNTX); } }