| Message ID | 20200915114543.2599-1-rogerq@ti.com |
|---|---|
| Headers | show |
| Series | usb: cdns,usb3: Convert DT binding to YAML | expand |
On Tue, 15 Sep 2020 14:45:41 +0300, Roger Quadros wrote: > Converts cdns-usb3.txt to YAML schema cdns,usb3.yaml > > Signed-off-by: Roger Quadros <rogerq@ti.com> > --- > .../devicetree/bindings/usb/cdns,usb3.yaml | 92 +++++++++++++++++++ > .../devicetree/bindings/usb/cdns-usb3.txt | 45 --------- > 2 files changed, 92 insertions(+), 45 deletions(-) > create mode 100644 Documentation/devicetree/bindings/usb/cdns,usb3.yaml > delete mode 100644 Documentation/devicetree/bindings/usb/cdns-usb3.txt > Reviewed-by: Rob Herring <robh@kernel.org>
Hi Sergei, On 15/09/2020 19:15, Sergei Shtylyov wrote: > Hello! > > On 9/15/20 2:45 PM, Roger Quadros wrote: > >> Controller version 0x0002450D has USB2 PHY RX sensitivity issues >> that needs to be worked around by enabling phyrst-a-enable bit >> in PHYRST_CFG register. >> >> There is no way to know controller version before device controller >> is started and the workaround needs to be applied for both host and >> device modes, so we add this DT property. >> >> Signed-off-by: Roger Quadros <rogerq@ti.com> >> Acked-by: Rob Herring <robh@kernel.org> >> --- >> Documentation/devicetree/bindings/usb/cdns,usb3.yaml | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/usb/cdns,usb3.yaml b/Documentation/devicetree/bindings/usb/cdns,usb3.yaml >> index 9b14c8443d39..ac20b98e9910 100644 >> --- a/Documentation/devicetree/bindings/usb/cdns,usb3.yaml >> +++ b/Documentation/devicetree/bindings/usb/cdns,usb3.yaml >> @@ -61,6 +61,10 @@ properties: >> buffers expressed in KB >> $ref: /schemas/types.yaml#/definitions/uint32 >> >> + cdns,phyrst-a-enable: >> + description: Enable resetting of PHY if Rx fail is detected > > Failure? Actually the IP manual says "Reset PHY if Rx fail is detected". So let's leave it like that. > > [...] > > MBR, Sergei > cheers, -roger
Hi Felipe, This series converts DT binding to YAML schema. Then adds a new property to enable workaround for USB2.0 PHY Rx compliance issues. cheers, -roger Changelog: v3: - removed oneOf from compatible. Added items in phy-names. v2: - updated commit log to better describe why DT property is required for the quirk. Pawel Laszczak (1): usb: cdns3: Enable workaround for USB2.0 PHY Rx compliance test PHY lockup Roger Quadros (2): dt-bindings: usb: Convert cdns-usb3.txt to YAML schema dt-bindings: usb: cdns,usb3: Add cdns,phyrst-a-enable property .../devicetree/bindings/usb/cdns,usb3.yaml | 96 +++++++++++++++++++ .../devicetree/bindings/usb/cdns-usb3.txt | 45 --------- drivers/usb/cdns3/core.c | 2 + drivers/usb/cdns3/core.h | 1 + drivers/usb/cdns3/drd.c | 12 +++ drivers/usb/cdns3/drd.h | 5 +- 6 files changed, 115 insertions(+), 46 deletions(-) create mode 100644 Documentation/devicetree/bindings/usb/cdns,usb3.yaml delete mode 100644 Documentation/devicetree/bindings/usb/cdns-usb3.txt