mbox series

[00/14] USB: serial: keyspan_pda: fix up write implementation

Message ID 20201025174600.27896-1-johan@kernel.org
Headers show
Series USB: serial: keyspan_pda: fix up write implementation | expand

Message

Johan Hovold Oct. 25, 2020, 5:45 p.m. UTC 
This series fixes a number of long-standing issues with the keyspan_pda
driver and reworks its write implementation so that it can be used with
any line discipline or for a system console.

The last few patches cleans up the xircom device support and some style
issues.

Johan


Johan Hovold (14):
  USB: serial: keyspan_pda: fix dropped unthrottle interrupts
  USB: serial: keyspan_pda: fix write deadlock
  USB: serial: keyspan_pda: fix stalled writes
  USB: serial: keyspan_pda: fix write-wakeup use-after-free
  USB: serial: keyspan_pda: fix tx-unthrottle use-after-free
  USB: serial: keyspan_pda: fix write unthrottling
  USB: serial: keyspan_pda: refactor write-room handling
  USB: serial: keyspan_pda: fix write implementation
  USB: serial: keyspan_pda: increase transmitter threshold
  USB: serial: keyspan_pda: add write-fifo support
  USB: serial: keyspan_pda: clean up xircom/entrega support
  USB: serial: keyspan_pda: clean up comments and whitespace
  USB: serial: keyspan_pda: use BIT() macro
  USB: serial: keyspan_pda: drop redundant usb-serial pointer

 drivers/usb/serial/Kconfig       |  19 +-
 drivers/usb/serial/Makefile      |   1 -
 drivers/usb/serial/keyspan_pda.c | 548 +++++++++++++------------------
 3 files changed, 241 insertions(+), 327 deletions(-)

Comments

Sebastian Andrzej Siewior Oct. 26, 2020, 12:13 p.m. UTC | #1 
On 2020-10-25 18:45:46 [+0100], Johan Hovold wrote:
> This series fixes a number of long-standing issues with the keyspan_pda

> driver and reworks its write implementation so that it can be used with

> any line discipline or for a system console.

> 

> The last few patches cleans up the xircom device support and some style

> issues.


Thank you Johan. This series fixes quite some issues including the
in_interrupt() part. I added the buffer part because it hurt to see an
allocation for one byte. There is no loss without it :)

Acked-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>


> Johan


Sebastian
Johan Hovold Oct. 27, 2020, 8:11 a.m. UTC | #2 
On Mon, Oct 26, 2020 at 01:13:18PM +0100, Sebastian Andrzej Siewior wrote:
> On 2020-10-25 18:45:46 [+0100], Johan Hovold wrote:
> > This series fixes a number of long-standing issues with the keyspan_pda
> > driver and reworks its write implementation so that it can be used with
> > any line discipline or for a system console.
> > 
> > The last few patches cleans up the xircom device support and some style
> > issues.
> 
> Thank you Johan. This series fixes quite some issues including the
> in_interrupt() part. I added the buffer part because it hurt to see an
> allocation for one byte. There is no loss without it :)
> 
> Acked-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>

Sounds good. And thanks for taking a look at the series.

Johan
Greg Kroah-Hartman Oct. 28, 2020, 9:38 a.m. UTC | #3 
On Sun, Oct 25, 2020 at 06:45:46PM +0100, Johan Hovold wrote:
> This series fixes a number of long-standing issues with the keyspan_pda
> driver and reworks its write implementation so that it can be used with
> any line discipline or for a system console.
> 
> The last few patches cleans up the xircom device support and some style
> issues.

Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Johan Hovold Nov. 4, 2020, 10:04 a.m. UTC | #4 
On Wed, Oct 28, 2020 at 10:38:48AM +0100, Greg Kroah-Hartman wrote:
> On Sun, Oct 25, 2020 at 06:45:46PM +0100, Johan Hovold wrote:
> > This series fixes a number of long-standing issues with the keyspan_pda
> > driver and reworks its write implementation so that it can be used with
> > any line discipline or for a system console.
> > 
> > The last few patches cleans up the xircom device support and some style
> > issues.
> 
> Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Thanks for reviewing. Now applied for -next.

Johan