mbox series

[v2,0/6] USB: serial: cp210x: fixes and CP2105/CP2108 fw version

Message ID 20210705082015.18286-1-johan@kernel.org
Headers show
Series USB: serial: cp210x: fixes and CP2105/CP2108 fw version | expand

Message

Johan Hovold July 5, 2021, 8:20 a.m. UTC 
Here are couple of minor fixes and some cleanups related to the recent
regression which broke RTS control on some CP2102N devices with buggy
firmware.

In case we run into another one of these, let's log the firmware
version also for CP2105 and CP2108 for which it can be retrieved.

Johan


Changes in v2
 - keep the special-chars error message to make it more obvious that
   continuing on errors is intentional (1/6) (Greg)


Johan Hovold (6):
  USB: serial: cp210x: fix control-characters error handling
  USB: serial: cp210x: fix flow-control error handling
  USB: serial: cp210x: clean up control-request timeout
  USB: serial: cp210x: clean up set-chars request
  USB: serial: cp210x: clean up type detection
  USB: serial: cp210x: determine fw version for CP2105 and CP2108

 drivers/usb/serial/cp210x.c | 77 +++++++++++++++----------------------
 1 file changed, 32 insertions(+), 45 deletions(-)

Comments

Greg KH July 5, 2021, 8:32 a.m. UTC | #1 
On Mon, Jul 05, 2021 at 10:20:09AM +0200, Johan Hovold wrote:
> Here are couple of minor fixes and some cleanups related to the recent
> regression which broke RTS control on some CP2102N devices with buggy
> firmware.
> 
> In case we run into another one of these, let's log the firmware
> version also for CP2105 and CP2108 for which it can be retrieved.
> 
> Johan
> 
> 
> Changes in v2
>  - keep the special-chars error message to make it more obvious that
>    continuing on errors is intentional (1/6) (Greg)

Thanks for the change, looks good to me!

Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Johan Hovold July 30, 2021, 3:21 p.m. UTC | #2 
On Mon, Jul 05, 2021 at 10:32:14AM +0200, Greg Kroah-Hartman wrote:
> On Mon, Jul 05, 2021 at 10:20:09AM +0200, Johan Hovold wrote:

> > Here are couple of minor fixes and some cleanups related to the recent

> > regression which broke RTS control on some CP2102N devices with buggy

> > firmware.

> > 

> > In case we run into another one of these, let's log the firmware

> > version also for CP2105 and CP2108 for which it can be retrieved.

> > 

> > Johan

> > 

> > 

> > Changes in v2

> >  - keep the special-chars error message to make it more obvious that

> >    continuing on errors is intentional (1/6) (Greg)

> 

> Thanks for the change, looks good to me!

> 

> Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>


Thanks also for reviewing these. Now applied for -next.

Johan