mbox series

[0/2] Possible xHCI driver fix for ZHAOXIN hosts

Message ID 20241217112917.623898-1-niklas.neronin@linux.intel.com
Headers show
Series Possible xHCI driver fix for ZHAOXIN hosts | expand

Message

Niklas Neronin Dec. 17, 2024, 11:29 a.m. UTC 
Hi Weitao Wang,

You fixed an issue in the Linux xHCI driver which concerned TRB prefetch on
ZHAOXIN hosts [1]. The fix was to allocate two pages for a segment instead
of one, on some ZHAOXIN hosts.

I recently noticed that the xHCI driver always sets the page size to 4096
bytes, regardless of whether a 4096-page size is supported. This may be the
root issue that your patch fixed.

I do not have access to a ZHAOXIN system, so could you please test the two
patches? The first patch sets the xHCI page size to the size supported by
the xHCI controller, and the second patch reverts your fix [1].

The patches are built on top of Linux 6.12.

[1], commit 2a865a652299 ("xhci: Fix TRB prefetch issue of ZHAOXIN hosts")

Niklas Neronin (2):
  usb: xhci: set page size to the xHCI-supported size
  Revert "xhci: Fix TRB prefetch issue of ZHAOXIN hosts"

 drivers/usb/host/xhci-mem.c | 36 ++++++++++++++----------------------
 drivers/usb/host/xhci-pci.c |  7 +------
 drivers/usb/host/xhci.h     | 10 +++++-----
 3 files changed, 20 insertions(+), 33 deletions(-)