| Message ID | cover.1606827507.git.agx@sigxcpu.org |
|---|---|
| Headers | show |
| Series | usb: typec: tps6598x: Export some power supply properties | expand |
On Tue, Dec 1, 2020 at 2:59 PM Guido Günther <agx@sigxcpu.org> wrote: > This allows downstream supplies and userspace to detect > whether external power is supplied. ... > +static int devm_tps6598_psy_register(struct tps6598x *tps) > +{ > + struct power_supply_config psy_cfg = {}; > + const char *port_dev_name = dev_name(tps->dev); > + size_t psy_name_len = strlen(tps6598x_psy_name_prefix) + > + strlen(port_dev_name) + 1; I'm so sorry by not noticing this one... > + char *psy_name; > + > + psy_cfg.drv_data = tps; > + psy_cfg.fwnode = dev_fwnode(tps->dev); > + psy_name = devm_kzalloc(tps->dev, psy_name_len, GFP_KERNEL); > + if (!psy_name) > + return -ENOMEM; > + > + snprintf(psy_name, psy_name_len, "%s%s", tps6598x_psy_name_prefix, > + port_dev_name); ...followed by this. Please, use devm_kasprintf() instead.
Hi Andy, On Tue, Dec 01, 2020 at 03:52:40PM +0200, Andy Shevchenko wrote: > On Tue, Dec 1, 2020 at 2:59 PM Guido Günther <agx@sigxcpu.org> wrote: > > This allows downstream supplies and userspace to detect > > whether external power is supplied. > > ... > > > +static int devm_tps6598_psy_register(struct tps6598x *tps) > > +{ > > + struct power_supply_config psy_cfg = {}; > > + const char *port_dev_name = dev_name(tps->dev); > > > + size_t psy_name_len = strlen(tps6598x_psy_name_prefix) + > > + strlen(port_dev_name) + 1; > > I'm so sorry by not noticing this one... > > > + char *psy_name; > > + > > + psy_cfg.drv_data = tps; > > + psy_cfg.fwnode = dev_fwnode(tps->dev); > > + psy_name = devm_kzalloc(tps->dev, psy_name_len, GFP_KERNEL); > > + if (!psy_name) > > + return -ENOMEM; > > + > > + snprintf(psy_name, psy_name_len, "%s%s", tps6598x_psy_name_prefix, > > + port_dev_name); > > ...followed by this. > > Please, use devm_kasprintf() instead. Will do. I'll let the series sit for a couple of days before sending a v5. Cheers, -- Guido > > -- > With Best Regards, > Andy Shevchenko >
This allows downstream supplies and userspace to detect whether external power is supplied. The Librem 5 has the tp65982 in front of bq25980 charge controller. Since that is capable of sinking and sourcing power the online property helps to decide what to do. It also makes upower happy. There will be follow up patches providing more properties but these need some more time to cook and i wanted to check if this is the right way to go? changes from v3 - As per review comments from Andy Shevchenko https://lore.kernel.org/linux-usb/CAHp75VeLZtm85Y=3QMkPGb332wn05-zr-_mrrwXvnqLhazR1Gg@mail.gmail.com/ - Use positive conditionals - Add reviewed by from Heikki Krogerus https://lore.kernel.org/linux-usb/20201130102720.GA2911464@kuha.fi.intel.com/T/#u https://lore.kernel.org/linux-usb/20201130102942.GB2911464@kuha.fi.intel.com/T/#u - Fix typc vs typec typo in commit message changes from v2 - As per kernel test robot https://lore.kernel.org/linux-usb/202011271005.zJVawX74-lkp@intel.com/ - Flip USB_ROLE_SWITCH and REGMAP_I2C from 'depends on' to 'select' This matches tcpm and avoids a config symbol recursion which went unnoticed on my arm64 build but trips up x86_64. changes from v1 - As per review comments from Heikki Krogerus https://lore.kernel.org/linux-usb/20201126123552.GP1008337@kuha.fi.intel.com/ - select POWER_SUPPLY - use POWER_SUPPLY_USB_TYPE_PD when a PD contract got negotiated To: Heikki Krogerus <heikki.krogerus@linux.intel.com>,Greg Kroah-Hartman <gregkh@linuxfoundation.org>,linux-usb@vger.kernel.org,linux-kernel@vger.kernel.org,Andy Shevchenko <andy.shevchenko@gmail.com> Guido Günther (2): usb: typec: tps6598x: Select USB_ROLE_SWITCH and REGMAP_I2C usb: typec: tps6598x: Export some power supply properties drivers/usb/typec/Kconfig | 5 +- drivers/usb/typec/tps6598x.c | 105 +++++++++++++++++++++++++++++++++++ 2 files changed, 108 insertions(+), 2 deletions(-)