From patchwork Mon Sep 8 09:45:30 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Robert Baldyga X-Patchwork-Id: 36951 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-pd0-f198.google.com (mail-pd0-f198.google.com [209.85.192.198]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 2532C20491 for ; Mon, 8 Sep 2014 09:46:08 +0000 (UTC) Received: by mail-pd0-f198.google.com with SMTP id ft15sf7446649pdb.1 for ; Mon, 08 Sep 2014 02:46:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:in-reply-to:references:sender:precedence:list-id :x-original-sender:x-original-authentication-results:mailing-list :list-post:list-help:list-archive:list-unsubscribe; bh=JocYMxdx8PjMo1m0u8wdYuddLKXykG90gOCR3O2Xz3Q=; b=M7cFlB7FRldYv6/2vd3u2Ev0G3jB6mffEKLB5QL201a2+Wts7iwOqEhIwsEC0kEkwh xdYBNn5YbuATTf+h0bUIixTjW6WX+JVf5mrpMHqS9KPo9d/9Gs0GliZRjM82BzWhtyJc YOQrpicCJCpx70nDZ+bBDnGLhTGUPP4MECAoL3JFfLGibYJ0KiU1GxboptL3lk7HZxQY 3NFfci/PzXvnPuaReBeyIm0kCTvTMLWj3Pfqb0WvSC0ZPf/xilRQPAIqnARpvit9NlZ7 vaMrXjXJvIFFHN53d0YeKo17Jl7xIvscrsBM2dvdRmw9dm1sxJxtOio/12ebO4s8HsMX hOCw== X-Gm-Message-State: ALoCoQmVQ55igsALWLwbT77FtaNGBRwIZlbHUUbXANbzPZkCygP2daLqQ5BKGkuxR+atGFKfX2c3 X-Received: by 10.66.141.48 with SMTP id rl16mr16760058pab.1.1410169567136; Mon, 08 Sep 2014 02:46:07 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.83.49 with SMTP id i46ls1595110qgd.10.gmail; Mon, 08 Sep 2014 02:46:07 -0700 (PDT) X-Received: by 10.52.69.195 with SMTP id g3mr3486236vdu.45.1410169567040; Mon, 08 Sep 2014 02:46:07 -0700 (PDT) Received: from mail-vc0-f176.google.com (mail-vc0-f176.google.com [209.85.220.176]) by mx.google.com with ESMTPS id p10si1780242vda.28.2014.09.08.02.46.07 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 08 Sep 2014 02:46:07 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.176 as permitted sender) client-ip=209.85.220.176; Received: by mail-vc0-f176.google.com with SMTP id ik5so14889432vcb.21 for ; Mon, 08 Sep 2014 02:46:06 -0700 (PDT) X-Received: by 10.220.112.143 with SMTP id w15mr158313vcp.41.1410169566938; Mon, 08 Sep 2014 02:46:06 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.221.45.67 with SMTP id uj3csp106472vcb; Mon, 8 Sep 2014 02:46:06 -0700 (PDT) X-Received: by 10.70.118.166 with SMTP id kn6mr40553402pdb.65.1410169565936; Mon, 08 Sep 2014 02:46:05 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id jo7si16892808pbb.25.2014.09.08.02.46.05 for ; Mon, 08 Sep 2014 02:46:05 -0700 (PDT) Received-SPF: none (google.com: stable-owner@vger.kernel.org does not designate permitted sender hosts) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752950AbaIHJqB (ORCPT + 1 other); Mon, 8 Sep 2014 05:46:01 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:61636 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753665AbaIHJp6 (ORCPT ); Mon, 8 Sep 2014 05:45:58 -0400 Received: from epcpsbgm1.samsung.com (epcpsbgm1 [203.254.230.26]) by mailout3.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0NBK00MQQTSL9W50@mailout3.samsung.com>; Mon, 08 Sep 2014 18:45:57 +0900 (KST) X-AuditID: cbfee61a-f79e46d00000134f-ba-540d7ad5428e Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id F1.9B.04943.5DA7D045; Mon, 08 Sep 2014 18:45:57 +0900 (KST) Received: from AMDC2122.DIGITAL.local ([106.120.53.17]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0NBK001BQTRY5140@mmp1.samsung.com>; Mon, 08 Sep 2014 18:45:57 +0900 (KST) From: Robert Baldyga To: gregkh@linuxfoundation.org Cc: Paul.Zimmerman@synopsys.com, balbi@ti.com, linux-usb@vger.kernel.org, stable@vger.kernel.org, Marek Szyprowski , Robert Baldyga Subject: [PATCH stable 4/6] usb: dwc2/gadget: do not call disconnect method in pullup Date: Mon, 08 Sep 2014 11:45:30 +0200 Message-id: <1410169532-16212-5-git-send-email-r.baldyga@samsung.com> X-Mailer: git-send-email 1.9.1 In-reply-to: <1410169532-16212-1-git-send-email-r.baldyga@samsung.com> References: <1410169532-16212-1-git-send-email-r.baldyga@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprALMWRmVeSWpSXmKPExsVy+t9jAd2rVbwhBvNfSVkcvF9v0bx4PZvF omWtzBZrj9xlt3j0cCurxYPDO9ktFmx8xOjA7rF/7hp2j74tqxg9tuz/zOhx/MZ2Jo/Pm+QC WKO4bFJSczLLUov07RK4Mp60NbAVzGOreNJ+lLGBcRFrFyMnh4SAicSmq7/YIGwxiQv31oPZ QgKLGCUmr1SCsNuZJD7/KwGx2QR0JLZ8n8AIYosIyEk8uf2HGcRmFtjJKPF8HpgtLBAusep7 EwuIzSKgKnFg/QugmRwcvAKuEkd3xUGskpM4eWwy2AmcAm4SR69dZoJY5Spxb04/6wRG3gWM DKsYRVMLkguKk9JzDfWKE3OLS/PS9ZLzczcxgsPpmdQOxpUNFocYBTgYlXh4OS7zhAixJpYV V+YeYpTgYFYS4Q3O4Q0R4k1JrKxKLcqPLyrNSS0+xCjNwaIkznug1TpQSCA9sSQ1OzW1ILUI JsvEwSnVwFgXLBeaN00zNSvx5J4ft2unMsX+Wvg/5KLKu24fRfXaJwr1U1mytsv0Wc/48qfh akOkbserskOtdi9+G/wSz1616db7B+rvVp9f+lZq7dxshidSjton6v6lVUxdoLQ3OMiBY+W8 Z2+dwv927jvFtdF411tbfs7bexIXpsxoMfQRZ/OM33108RElluKMREMt5qLiRABdXpWZIwIA AA== Sender: stable-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: stable@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: patch@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.176 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , From: Marek Szyprowski This leads to potential spinlock recursion in composite framework, other udc drivers also don't call it directly from pullup method. Signed-off-by: Marek Szyprowski Signed-off-by: Robert Baldyga --- drivers/usb/dwc2/gadget.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c index f3198dc..1c2b8dd 100644 --- a/drivers/usb/dwc2/gadget.c +++ b/drivers/usb/dwc2/gadget.c @@ -2943,7 +2943,6 @@ static int s3c_hsotg_pullup(struct usb_gadget *gadget, int is_on) s3c_hsotg_phy_enable(hsotg); s3c_hsotg_core_init(hsotg); } else { - s3c_hsotg_disconnect(hsotg); s3c_hsotg_phy_disable(hsotg); }