From patchwork Sun Aug 16 11:59:50 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vinod Koul X-Patchwork-Id: 247777 Delivered-To: patch@linaro.org Received: by 2002:a92:cc90:0:0:0:0:0 with SMTP id x16csp1814206ilo; Sun, 16 Aug 2020 05:00:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwZKydyBAH+IotTb2h8qE7i2vLQqW8gvuSLEDorvpEgF6QbReMqRwv0wK0K34RFVoSqdlem X-Received: by 2002:a17:906:a201:: with SMTP id r1mr10466205ejy.432.1597579256566; Sun, 16 Aug 2020 05:00:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1597579256; cv=none; d=google.com; s=arc-20160816; b=wuStPUH+g6+9pnaXtxZYbHmbd2pB/Ix6r3rBV5CQupUAql1XW3g5vsYsruqkB6uEK9 cQC6UoLB8BmW27PdSXM7aRUJJInIEde1eIlNiijuGFCN/OnoJPN3hVGopAPB4b5QXv2V Fg+fz71sJBpRiaSJz0lT+2l7414f/o+0uf69nfeTzUL84FfuJ/G82h3VKwVDAk5bJn5h en7DB9r0+jslQrX6X8jgJAlCpCjWrmabOtfWi1SqD46mcWNQb+4bQ9ccuM3BQnjFGrQV qS8gfTPipPrLaAXUtErP2snqofUj4GpUn1AMS4JmgUPj9N71uSE7SWWx5/ogTCFzrWxi zRFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=33MMMuF0+EvA8/mCct+Cr8eRnvM4N7sev1iGVW07ZOE=; b=h9SzkAxjgrgx+sah7w+XO5HFbkaTUgxnTYON8dFM5V+MTdaIaEkruE3jJXnXTHJxmB z/1y0mqjr90/9QViEB1xc6b1jsK5dJCKxlcWXXUzhQGUa1D/oBB+3UcXe/2XTxWqw1HF Xwl15fWhaojOv7lFNfrDa3Jgovx0/Vbcb+0sQ1LF3x9w7eJbrvqeXdrKO5FSPFcWTl2K TJ9eLWtxcbmTMTJdlcKeU3XaB2qYyGWQpOEWMHYyy9WvFs7dJBjr0zLnD6+UD/zdaxIT IOrWf2iuHHQbDS0Se7ntjhjh/hx3wX4JVbouS+TgRlPWFAKCpM5hRToQ9yogiaKWOhfa cn6g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=oYBQms5G; spf=pass (google.com: domain of linux-usb-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-usb-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id um10si8711907ejb.119.2020.08.16.05.00.55; Sun, 16 Aug 2020 05:00:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-usb-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=oYBQms5G; spf=pass (google.com: domain of linux-usb-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-usb-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726339AbgHPMAZ (ORCPT + 5 others); Sun, 16 Aug 2020 08:00:25 -0400 Received: from mail.kernel.org ([198.145.29.99]:52396 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726308AbgHPMAN (ORCPT ); Sun, 16 Aug 2020 08:00:13 -0400 Received: from localhost.localdomain (unknown [122.171.38.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DD9D1207D3; Sun, 16 Aug 2020 12:00:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597579203; bh=CXcNyaPtavfj7aGTBkfdqdo9bINGV1Mzg2Iw/8pbozY=; h=From:To:Cc:Subject:Date:From; b=oYBQms5G+ACe346GACm1SD4S49w7jSNQPi0x7irHu6s97Uqxj8yV+8bgPJyw0wMmM x7VbuvLuaAfh7QoVOwxKeHoszMwTuK6OSaZzarT11F3ee95LqOu9bliy9ZDnRq3eIU uHlV251FUBhbUhAqRRUmUUf4bXOTkq7TnrMJBgP0= From: Vinod Koul To: Mathias Nyman , Greg Kroah-Hartman Cc: Vinod Koul , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] usb: renesas-xhci: add missing versions Date: Sun, 16 Aug 2020 17:29:50 +0530 Message-Id: <20200816115950.400594-1-vkoul@kernel.org> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Some devices in wild are reporting firmware version as 0x2011 and 0x2020, so add these as well Reported by: Anastasios Vacharakis Reported by: Glen Journeay Fixes: 2478be82de44 ("usb: renesas-xhci: Add ROM loader for uPD720201") Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=208911 Signed-off-by: Vinod Koul --- Greg, this fixes regression for folks with preprogrammed controllers with firmware version 0x2020 and 0x2011, please mark as stable material drivers/usb/host/xhci-pci-renesas.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) -- 2.26.2 diff --git a/drivers/usb/host/xhci-pci-renesas.c b/drivers/usb/host/xhci-pci-renesas.c index 59b1965ad0a3..f32b5a958ace 100644 --- a/drivers/usb/host/xhci-pci-renesas.c +++ b/drivers/usb/host/xhci-pci-renesas.c @@ -50,14 +50,19 @@ #define RENESAS_RETRY 10000 #define RENESAS_DELAY 10 -#define ROM_VALID_01 0x2013 -#define ROM_VALID_02 0x2026 +/* keep the ids sorted */ +#define ROM_VALID_01 0x2011 +#define ROM_VALID_02 0x2013 +#define ROM_VALID_03 0x2020 +#define ROM_VALID_04 0x2026 static int renesas_verify_fw_version(struct pci_dev *pdev, u32 version) { switch (version) { case ROM_VALID_01: case ROM_VALID_02: + case ROM_VALID_03: + case ROM_VALID_04: return 0; } dev_err(&pdev->dev, "FW has invalid version :%d\n", version);