From patchwork Sat Aug 5 09:51:53 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 711109 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FEA6EB64DD for ; Sat, 5 Aug 2023 09:52:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229610AbjHEJwK (ORCPT ); Sat, 5 Aug 2023 05:52:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41104 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229501AbjHEJwJ (ORCPT ); Sat, 5 Aug 2023 05:52:09 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A56C13A9B; Sat, 5 Aug 2023 02:52:04 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2E37C60B2C; Sat, 5 Aug 2023 09:52:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 871EEC433C7; Sat, 5 Aug 2023 09:52:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691229123; bh=k1H8U6RI1llKdbpE02HLjjQniXPJI9WecDX0w+udZxg=; h=From:To:Cc:Subject:Date:From; b=iOy65PHDHA9Jq5LZS5cEJm54DND1H3goCPAPegqGgwjkecwpBBgT4HGFsJxMqneJl Bay944svlGQ3twdgUbs7nH1EdOLJvL97Uq9DRDK5bKFOen03SYiAHyzA9w9xDGp6zL f4K3ss+T77+WaCFWERfCteUAhVEZY2A9F/T3IpLRpBdwNF7iwScNdITpZfAo0Ymbu7 jaUQAFM0Pp8ziVCRJuOsJbErJmb1Od/zgljbzc/o6YVEK2D5SrlPQVIV/Z4olbJfFE PWY+GWRGLNyBOLYCoRhFADk7S2vSsOt38iQZEsJ7GSnFBbkJxOIHBhMDBvNuwchQGu SrU+Xkaxq+nkw== From: Arnd Bergmann To: Heikki Krogerus , Greg Kroah-Hartman , Rajat Khandelwal Cc: Arnd Bergmann , Neil Armstrong , Bjorn Andersson , Dmitry Baryshkov , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] usb: typec: intel_pmc_mux: select CONFIG_USB_COMMON Date: Sat, 5 Aug 2023 11:51:53 +0200 Message-Id: <20230805095157.3459892-1-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org From: Arnd Bergmann It is possible to configure the typec drivers to be built-in while the actual USB host and device support is in loadable modules, but that now causes a link failure because the usb debugfs support is then not available to built-in code. x86_64-linux-ld: drivers/usb/typec/mux/intel_pmc_mux.o: in function `pmc_usb_init': intel_pmc_mux.c:(.init.text+0x3): undefined reference to `usb_debug_root' Select CONFIG_USB_COMMON to get it to build again, as we do for other drivers that require the core usb functionality. Fixes: 0a453dc9f2602 ("usb: typec: intel_pmc_mux: Expose IOM port status to debugfs") Signed-off-by: Arnd Bergmann --- drivers/usb/typec/mux/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/typec/mux/Kconfig b/drivers/usb/typec/mux/Kconfig index 784b9d8107e9b..65da61150ba78 100644 --- a/drivers/usb/typec/mux/Kconfig +++ b/drivers/usb/typec/mux/Kconfig @@ -29,6 +29,7 @@ config TYPEC_MUX_INTEL_PMC tristate "Intel PMC mux control" depends on ACPI depends on INTEL_SCU_IPC + select USB_COMMON select USB_ROLE_SWITCH help Driver for USB muxes controlled by Intel PMC FW. Intel PMC FW can