mbox series

[v6,0/4] watchdog: mt8192: add wdt support

Message ID 20201014131936.20584-1-crystal.guo@mediatek.com
Headers show
Series watchdog: mt8192: add wdt support | expand

Message

Crystal Guo Oct. 14, 2020, 1:19 p.m. UTC 
This patches aim to add watchdog support for MT8192.

change in v6:
1. add change log.
2. remove Reviewed-by tag on[v5,2/4]


change in v5:
fix typos on mt8192-reset.h (https://patchwork.kernel.org/patch/11697493/)


change in v4:
just revise v3 commit messages.
[v4,1/5] fix the description of compatible is Reviewed-by: Matthias and Guenter.
[v4,2/5] update watchdog device node for mt8183 is Acked-by: Guenter, and will
be applied to v5.9-next/dts64.
[v4,4/5] add toprgu reset-controller head file for MT8192 platform is Reviewed-by: Matthias,
and Acked-by: Guenter.
[v4,5/5] add support for watchdog device found in MT8192 SoC is Reviewed-by: Matthias and Guenter.


change in v3:
1. separate [v2,1/3] to fix the original mt2712 and mt8183 compatibles and add new board as:
[v3,1/5] fix mt2712 and mt8183 description of compatible, since mt2712
and mt8183 also provide sub-system software reset features, but mt6589 not
support this feature. (Reviewed-by: Matthias)
[v3,2/5] update watchdog device node for mt8183
[v3,3/5] update mtk-wdt document for MT8192 platform
2. [v3, 4/5] is same as [v2,2/3] (Reviewed-by: Matthias)
3. modify the commit message of [v2,3/3]
[v3,5/5] add support for watchdog device found in MT8192 SoC(Reviewed-by: Matthias and Guenter)


v2 changes:
Abandon V1 changes,and add the following changes:
[v2,1/3] update mtk-wdt document for mt2712, mt8183 and mt8192.
[v2,2/3] add toprgu reset-controller head file for MT8192 platform (Reviewed-by: Matthias)
[v2,3/3] add support for watchdog device found in MT8192 SoC( Reviewed-by: Matthias)


v1 changes:
Instead of submit the mt8192-reset.h, get the number of
reset bits from dtsi directly.

Crystal Guo (4):
  dt-binding: mediatek: watchdog: fix the description of compatible
  dt-binding: mediatek: mt8192: update mtk-wdt document
  dt-binding: mt8192: add toprgu reset-controller head file
  watchdog: mt8192: add wdt support

 .../devicetree/bindings/watchdog/mtk-wdt.txt  |  5 ++--
 drivers/watchdog/mtk_wdt.c                    |  6 ++++
 .../reset-controller/mt8192-resets.h          | 30 +++++++++++++++++++
 3 files changed, 39 insertions(+), 2 deletions(-)
 create mode 100644 include/dt-bindings/reset-controller/mt8192-resets.h

Comments

Crystal Guo Nov. 16, 2020, 12:27 p.m. UTC | #1 
Hi Maintainers,

Gentle pin for this patch.

Thanks

On Wed, 2020-10-14 at 21:19 +0800, Crystal Guo wrote:
> update mtk-wdt document for MT8192 platform

> 

> Signed-off-by: Crystal Guo <crystal.guo@mediatek.com>

> ---

>  Documentation/devicetree/bindings/watchdog/mtk-wdt.txt | 1 +

>  1 file changed, 1 insertion(+)

> 

> diff --git a/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt b/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt

> index 45eedc2c3141..e36ba60de829 100644

> --- a/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt

> +++ b/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt

> @@ -12,6 +12,7 @@ Required properties:

>  	"mediatek,mt7629-wdt", "mediatek,mt6589-wdt": for MT7629

>  	"mediatek,mt8183-wdt": for MT8183

>  	"mediatek,mt8516-wdt", "mediatek,mt6589-wdt": for MT8516

> +	"mediatek,mt8192-wdt": for MT8192

>  

>  - reg : Specifies base physical address and size of the registers.

>
Nicolas Boichat Dec. 21, 2020, 12:59 a.m. UTC | #2 
On Mon, Nov 16, 2020 at 8:27 PM Crystal Guo <crystal.guo@mediatek.com> wrote:
>

> Hi Maintainers,

>

> Gentle pin for this patch.

>

> Thanks

>

> On Wed, 2020-10-14 at 21:19 +0800, Crystal Guo wrote:

> > update mtk-wdt document for MT8192 platform


Rob: I assume your input is required here? Any chance we could have
your ack/review on this trivial patch? It seems like the series is
blocked pending on a review of this patch -- and I don't think it has
been reviewed before.

Thanks,


> >

> > Signed-off-by: Crystal Guo <crystal.guo@mediatek.com>

> > ---

> >  Documentation/devicetree/bindings/watchdog/mtk-wdt.txt | 1 +

> >  1 file changed, 1 insertion(+)

> >

> > diff --git a/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt b/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt

> > index 45eedc2c3141..e36ba60de829 100644

> > --- a/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt

> > +++ b/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt

> > @@ -12,6 +12,7 @@ Required properties:

> >       "mediatek,mt7629-wdt", "mediatek,mt6589-wdt": for MT7629

> >       "mediatek,mt8183-wdt": for MT8183

> >       "mediatek,mt8516-wdt", "mediatek,mt6589-wdt": for MT8516

> > +     "mediatek,mt8192-wdt": for MT8192

> >

> >  - reg : Specifies base physical address and size of the registers.

> >

>

> _______________________________________________

> Linux-mediatek mailing list

> Linux-mediatek@lists.infradead.org

> http://lists.infradead.org/mailman/listinfo/linux-mediatek
Crystal Guo Dec. 26, 2020, 8:55 a.m. UTC | #3 
On Mon, 2020-12-21 at 08:59 +0800, Nicolas Boichat wrote:
> On Mon, Nov 16, 2020 at 8:27 PM Crystal Guo <crystal.guo@mediatek.com> wrote:

> >

> > Hi Maintainers,

> >

> > Gentle pin for this patch.

> >

> > Thanks

> >

> > On Wed, 2020-10-14 at 21:19 +0800, Crystal Guo wrote:

> > > update mtk-wdt document for MT8192 platform

> 

> Rob: I assume your input is required here? Any chance we could have

> your ack/review on this trivial patch? It seems like the series is

> blocked pending on a review of this patch -- and I don't think it has

> been reviewed before.

> 

> Thanks,

> 

> 


Hi Maintainers,

Just a gentle ping, can you help to review or give some suggestions
about this patch set?

Many thanks.

> > >

> > > Signed-off-by: Crystal Guo <crystal.guo@mediatek.com>

> > > ---

> > >  Documentation/devicetree/bindings/watchdog/mtk-wdt.txt | 1 +

> > >  1 file changed, 1 insertion(+)

> > >

> > > diff --git a/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt b/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt

> > > index 45eedc2c3141..e36ba60de829 100644

> > > --- a/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt

> > > +++ b/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt

> > > @@ -12,6 +12,7 @@ Required properties:

> > >       "mediatek,mt7629-wdt", "mediatek,mt6589-wdt": for MT7629

> > >       "mediatek,mt8183-wdt": for MT8183

> > >       "mediatek,mt8516-wdt", "mediatek,mt6589-wdt": for MT8516

> > > +     "mediatek,mt8192-wdt": for MT8192

> > >

> > >  - reg : Specifies base physical address and size of the registers.

> > >

> >

> > _______________________________________________

> > Linux-mediatek mailing list

> > Linux-mediatek@lists.infradead.org

> > http://lists.infradead.org/mailman/listinfo/linux-mediatek
Guenter Roeck Jan. 23, 2021, 6:21 p.m. UTC | #4 
On Wed, Oct 14, 2020 at 09:19:34PM +0800, Crystal Guo wrote:
> update mtk-wdt document for MT8192 platform

> 

> Signed-off-by: Crystal Guo <crystal.guo@mediatek.com>


Reviewed-by: Guenter Roeck <linux@roeck-us.net>


> ---

>  Documentation/devicetree/bindings/watchdog/mtk-wdt.txt | 1 +

>  1 file changed, 1 insertion(+)

> 

> diff --git a/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt b/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt

> index 45eedc2c3141..e36ba60de829 100644

> --- a/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt

> +++ b/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt

> @@ -12,6 +12,7 @@ Required properties:

>  	"mediatek,mt7629-wdt", "mediatek,mt6589-wdt": for MT7629

>  	"mediatek,mt8183-wdt": for MT8183

>  	"mediatek,mt8516-wdt", "mediatek,mt6589-wdt": for MT8516

> +	"mediatek,mt8192-wdt": for MT8192

>  

>  - reg : Specifies base physical address and size of the registers.

>