mbox series

[v2,0/4] Various fixes for the da9052 watchdog

Message ID 20250325-da9052-fixes-v2-0-bfac3f07b4a4@gmail.com
Headers show
Series Various fixes for the da9052 watchdog | expand

Message

Marcus Folkesson March 25, 2025, 7:27 a.m. UTC 
Add support for the nowayout and timeout module parameters and treat
them in a standard way.

Respect twdmin, without this the watchdog timer will immediately assert
TWD_ERROR and power down to reset mode.

Do not stop the watchdog during probe. If the watchdog is enabled in the
bootloader, it should propably supposed to stay on.

Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com>
---
Changes in v2:
- Fix warning found by kernel test robot
- Link to v1: https://lore.kernel.org/r/20250313-da9052-fixes-v1-0-379dc87af953@gmail.com

---
Marcus Folkesson (4):
      watchdog: da9052_wdt: add support for nowayout
      watchdog: da9052_wdt: use timeout value from external inputs
      watchdog: da9052_wdt: do not disable wdt during probe
      watchdog: da9052_wdt: respect TWDMIN

 drivers/watchdog/da9052_wdt.c | 23 +++++++++++++++--------
 1 file changed, 15 insertions(+), 8 deletions(-)
---
base-commit: 0fed89a961ea851945d23cc35beb59d6e56c0964
change-id: 20250313-da9052-fixes-186674b34993

Best regards,

Comments

Guenter Roeck March 25, 2025, 1:01 p.m. UTC | #1 
On Tue, Mar 25, 2025 at 08:27:12AM +0100, Marcus Folkesson wrote:
> Add nowayout module parameter for not stopping the
> watchdog when userspae application quits.
> 
> Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Guenter Roeck March 25, 2025, 1:05 p.m. UTC | #2 
On Tue, Mar 25, 2025 at 08:27:14AM +0100, Marcus Folkesson wrote:
> If the watchog is started by the bootloader, we do not want the watchdog
> to be disabled.
> 

If the watchdog is left running, the watchdog core should be notified
by setting WDOG_HW_RUNNING. Please see other drivers for examples.

Thanks,
Guenter