| Message ID | 20241001170018.20139-2-towinchenmi@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | watchdog: apple: Increase reset delay to 150ms | expand |
On 10/1/24 09:59, Nick Chan wrote: > Although there is an existing code comment about flushing the writes, > writes were not actually being flushed. > > Actually flush the writes by changing readl_relaxed() to readl(). > > Fixes: 4ed224aeaf661 ("watchdog: Add Apple SoC watchdog driver") > Suggested-by: Arnd Bergmann <arnd@arndb.de> > Signed-off-by: Nick Chan <towinchenmi@gmail.com> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
diff --git a/drivers/watchdog/apple_wdt.c b/drivers/watchdog/apple_wdt.c index d4f739932f0b..62dabf223d90 100644 --- a/drivers/watchdog/apple_wdt.c +++ b/drivers/watchdog/apple_wdt.c @@ -130,7 +130,7 @@ static int apple_wdt_restart(struct watchdog_device *wdd, unsigned long mode, * can take up to ~20-25ms until the SoC is actually reset. Just wait * 50ms here to be safe. */ - (void)readl_relaxed(wdt->regs + APPLE_WDT_WD1_CUR_TIME); + (void)readl(wdt->regs + APPLE_WDT_WD1_CUR_TIME); mdelay(50); return 0;
Although there is an existing code comment about flushing the writes, writes were not actually being flushed. Actually flush the writes by changing readl_relaxed() to readl(). Fixes: 4ed224aeaf661 ("watchdog: Add Apple SoC watchdog driver") Suggested-by: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Nick Chan <towinchenmi@gmail.com> --- drivers/watchdog/apple_wdt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)