From patchwork Fri Mar 14 16:02:44 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 874142 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EA1191FF7B8; Fri, 14 Mar 2025 16:02:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741968175; cv=none; b=OjEQXp/vQNUXIgB31G0tiupGImcLIp8AclxU3Rdzj0w2xJqhW4/FvxlYjy0GuhN7OYBvDazeyn5B2OTGzg32mfB6pkHe7aXhOAOSrCEScnZpu7h+yKE7YhajmA+5a9pX01VV3GSyc9QrECEgAU6n4L+rHzXv0aQ7n/WnTwq1nEU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741968175; c=relaxed/simple; bh=2xfK40kbAsq1KvSui06/jpf2SUEyYwHkDTzV9ntlS0E=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=WL5dM3U7EPMkep8v7s5rYvbjC1pvvThd+gcZvJNMLK+Uil8wu5xn2d5B1xOULiJS4z7EAJnlPWHzZiA3GUpzqamRop+DhuFHtS3bqu8OIjchhFswkYx8LmcNo6s8eSf2qL3WW85q9RmKSxlDUYc6rsn2cKqTpebNaI65jrSAQqk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=NwAIwXPA; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="NwAIwXPA" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 803CFC4CEE9; Fri, 14 Mar 2025 16:02:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1741968173; bh=2xfK40kbAsq1KvSui06/jpf2SUEyYwHkDTzV9ntlS0E=; h=From:To:Cc:Subject:Date:From; b=NwAIwXPA5LFcIGfs/bRsgeS29k96CBCEM5nbbzJuvRLWiyQYt3rykJ48fbgDzQ4h+ dK5u8r9V4Ee5/y1NQs8aHLSzT00O9fYt03Ryl/fN2Oj3OMa5XNtYYNt9JJ0muwTSdR /MXZloiB9t3j0LdunViaOvQrids/JmMppD1Q9DdA+L7qM1Mr/lKS63K0FZ294Zgg+e n5VWtTs9xkuvnxnxouvylTWiPpD++qr7929bLwS4kxC38MLOgLWTRQPorjIPZjTYY1 2dClBdjtIEOBybXRJhhp9zobqDT6wXGMklWdgHYkfaq8adhrbHNM+T+wwGfJIwgk5n /feX1H8EpT2Mw== From: Arnd Bergmann To: Wim Van Sebroeck , Guenter Roeck , Joel Stanley , Andrew Jeffery , Chin-Ting Kuo Cc: Arnd Bergmann , linux-watchdog@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: [PATCH] watchdog: aspeed: fix 64-bit division Date: Fri, 14 Mar 2025 17:02:44 +0100 Message-Id: <20250314160248.502324-1-arnd@kernel.org> X-Mailer: git-send-email 2.39.5 Precedence: bulk X-Mailing-List: linux-watchdog@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Arnd Bergmann On 32-bit architectures, the new calculation causes a build failure: ld.lld-21: error: undefined symbol: __aeabi_uldivmod Since neither value is ever larger than a register, cast both sides into a uintptr_t. Fixes: 5c03f9f4d362 ("watchdog: aspeed: Update bootstatus handling") Signed-off-by: Arnd Bergmann Reviewed-by: Guenter Roeck Reviewed-by: Andrew Jeffery --- drivers/watchdog/aspeed_wdt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/watchdog/aspeed_wdt.c b/drivers/watchdog/aspeed_wdt.c index 369635b38ca0..837e15701c0e 100644 --- a/drivers/watchdog/aspeed_wdt.c +++ b/drivers/watchdog/aspeed_wdt.c @@ -254,7 +254,7 @@ static void aspeed_wdt_update_bootstatus(struct platform_device *pdev, if (!of_device_is_compatible(pdev->dev.of_node, "aspeed,ast2400-wdt")) { res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - idx = ((intptr_t)wdt->base & 0x00000fff) / resource_size(res); + idx = ((intptr_t)wdt->base & 0x00000fff) / (uintptr_t)resource_size(res); } scu_base = syscon_regmap_lookup_by_compatible(scu.compatible);