diff mbox series

[2/8] dt-bindings: watchdog: sama5d4-wdt: Add sama7d65-wdt

Message ID 3c55e634f2993ac5a49e1b8bfceb2333e175d376.1739555984.git.Ryan.Wanner@microchip.com
State New
Headers show
Series Add System Components for Microchip SAMA7D65 SoC | expand

Commit Message

Ryan Wanner Feb. 14, 2025, 6:08 p.m. UTC 
From: Ryan Wanner <Ryan.Wanner@microchip.com>

Add microchip,sama7d65-wdt compatible string to the dt-binding documentation.

Signed-off-by: Ryan Wanner <Ryan.Wanner@microchip.com>
---
 .../devicetree/bindings/watchdog/atmel,sama5d4-wdt.yaml        | 3 +++
 1 file changed, 3 insertions(+)

Comments

Claudiu Beznea Feb. 18, 2025, 8:42 a.m. UTC | #1 
On 14.02.2025 20:08, Ryan.Wanner@microchip.com wrote:
> From: Ryan Wanner <Ryan.Wanner@microchip.com>
> 
> Add microchip,sama7d65-wdt compatible string to the dt-binding documentation.
> 
> Signed-off-by: Ryan Wanner <Ryan.Wanner@microchip.com>
> ---
>  .../devicetree/bindings/watchdog/atmel,sama5d4-wdt.yaml        | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/watchdog/atmel,sama5d4-wdt.yaml b/Documentation/devicetree/bindings/watchdog/atmel,sama5d4-wdt.yaml
> index cdf87db361837..e9c026194d403 100644
> --- a/Documentation/devicetree/bindings/watchdog/atmel,sama5d4-wdt.yaml
> +++ b/Documentation/devicetree/bindings/watchdog/atmel,sama5d4-wdt.yaml
> @@ -23,6 +23,9 @@ properties:
>            - const: microchip,sam9x7-wdt
>            - const: microchip,sam9x60-wdt
>

You could have keep this new line after the items section that you've added.

> +      - items:
> +          - const: microchip,sama7d65-wdt
> +          - const: microchip,sama7g5-wdt

here.

>    reg:
>      maxItems: 1
>
Rob Herring Feb. 19, 2025, 10:59 p.m. UTC | #2 
On Tue, Feb 18, 2025 at 10:42:36AM +0200, Claudiu Beznea wrote:
> 
> 
> On 14.02.2025 20:08, Ryan.Wanner@microchip.com wrote:
> > From: Ryan Wanner <Ryan.Wanner@microchip.com>
> > 
> > Add microchip,sama7d65-wdt compatible string to the dt-binding documentation.
> > 
> > Signed-off-by: Ryan Wanner <Ryan.Wanner@microchip.com>
> > ---
> >  .../devicetree/bindings/watchdog/atmel,sama5d4-wdt.yaml        | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/watchdog/atmel,sama5d4-wdt.yaml b/Documentation/devicetree/bindings/watchdog/atmel,sama5d4-wdt.yaml
> > index cdf87db361837..e9c026194d403 100644
> > --- a/Documentation/devicetree/bindings/watchdog/atmel,sama5d4-wdt.yaml
> > +++ b/Documentation/devicetree/bindings/watchdog/atmel,sama5d4-wdt.yaml
> > @@ -23,6 +23,9 @@ properties:
> >            - const: microchip,sam9x7-wdt
> >            - const: microchip,sam9x60-wdt
> >
> 
> You could have keep this new line after the items section that you've added.
> 
> > +      - items:
> > +          - const: microchip,sama7d65-wdt
> > +          - const: microchip,sama7g5-wdt
> 
> here.

Please do.

> 
> >    reg:
> >      maxItems: 1
> >  
>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/watchdog/atmel,sama5d4-wdt.yaml b/Documentation/devicetree/bindings/watchdog/atmel,sama5d4-wdt.yaml
index cdf87db361837..e9c026194d403 100644
--- a/Documentation/devicetree/bindings/watchdog/atmel,sama5d4-wdt.yaml
+++ b/Documentation/devicetree/bindings/watchdog/atmel,sama5d4-wdt.yaml
@@ -23,6 +23,9 @@  properties:
           - const: microchip,sam9x7-wdt
           - const: microchip,sam9x60-wdt
 
+      - items:
+          - const: microchip,sama7d65-wdt
+          - const: microchip,sama7g5-wdt
   reg:
     maxItems: 1