From patchwork Wed Sep 9 15:36:00 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bryan O'Donoghue X-Patchwork-Id: 249473 Delivered-To: patch@linaro.org Received: by 2002:a92:5b9c:0:0:0:0:0 with SMTP id c28csp523657ilg; Wed, 9 Sep 2020 08:35:30 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzrUA69RorZ9Efmbf1YqhiOqiVpKSRs7kTN08vkffiubI294MtrWC1vx9limQyIuSjOfMwJ X-Received: by 2002:a92:9a15:: with SMTP id t21mr4231731ili.289.1599665730195; Wed, 09 Sep 2020 08:35:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599665730; cv=none; d=google.com; s=arc-20160816; b=YyvdzCOfFZkm1I5JUJC6tjkIFGDFdsVX/B1jKFCoLDsMT8l9dIVtdbsq3uI2DmYsDL lCUODL+7AuqqsbD84jqDyATKq2+ceas0AjXHwHdGGLLM/poWG9auY53Nv7MuDIjqgTAY 84RNNj/tEeMPse47XKrbqT/ju9SHwfb/4H09bocwj4wY9laub75FcEDJliHzK5UYBsv2 7P6G1r12C4JIoqIFcGq4dtmYsbqG4Own8h8nctOr0ppcU+YM843Axjzr3KyU1vWm37zo TTkvmUOO2jcDHWMRWbEXyLpn3SeFln64cPdyFWyIAq+CQjXt7FxRVEM5NdTjcLaP5OPu CX8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:sender:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:message-id:date:subject:to:from :dkim-signature:dkim-signature; bh=JBC/nIv0uUW0xa4BjuuG1WERHYxOhpDMqRdm/ussu8Q=; b=MVoZe4a5NuZPPi6nPnkUmJZ1yNTod6Jy+W1V8QpG7s6CnVD6yg6cxJX+yX1tAnlk+w 3jaYrpJaPJ6m5yhyiX9f3xGaX/bXOBurWjzUftlNfKqmSsa4uHtw1MjhRrh3fr1yzWwp aI2JSil4zecKrRC6cN76KuJfWGKIRzjIG3VUHi0hlKwgKW/RT1b1fbLqjCICAECketr1 Rc4RnyXfe26WD46JjqXbHkUAxZxpIEyrAdQ5cJ+IOWi8JCfKtC0H2Jxt67RLTTdfwtJF 4KJtGvTl5H13HefIvgQE5YuQb4Opk1LMHPGIYcRt3w3oB2TeFqLyjvtCeCt1HC9O4w6V 5iKA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.infradead.org header.s=merlin.20170209 header.b=z6g5EvDI; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=TWMgl3rq; spf=pass (google.com: best guess record for domain of wcn36xx-bounces+patch=linaro.org@lists.infradead.org designates 2001:8b0:10b:1231::1 as permitted sender) smtp.mailfrom="wcn36xx-bounces+patch=linaro.org@lists.infradead.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from merlin.infradead.org (merlin.infradead.org. [2001:8b0:10b:1231::1]) by mx.google.com with ESMTPS id i5si2173047jaj.2.2020.09.09.08.35.29 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Sep 2020 08:35:30 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of wcn36xx-bounces+patch=linaro.org@lists.infradead.org designates 2001:8b0:10b:1231::1 as permitted sender) client-ip=2001:8b0:10b:1231::1; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.infradead.org header.s=merlin.20170209 header.b=z6g5EvDI; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=TWMgl3rq; spf=pass (google.com: best guess record for domain of wcn36xx-bounces+patch=linaro.org@lists.infradead.org designates 2001:8b0:10b:1231::1 as permitted sender) smtp.mailfrom="wcn36xx-bounces+patch=linaro.org@lists.infradead.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=JBC/nIv0uUW0xa4BjuuG1WERHYxOhpDMqRdm/ussu8Q=; b=z6g5EvDImImrwu7qynAbDOXxEz e3w6n/n08Wfy4xmirgHMWOsQbaOnAbNJv/60r7GpLqf6kjpyoUS/wsVYRVgPqSM8xoyA0Mh/c+5sc P7wi6XM+TPJIWC+L4drm081LeP5dlTgfMkRu2P8tbsqn5xlpBMWNRiR5R3tVLK05Isy1I4wGpX937 SiBi7zi0+B0sChQWOCLuTxsFtcMabua1R7ZLGpQ+tJB/eAhDSa609I0aJfLEAg1zUccT2E8v9iUkQ jgZjIJZn1/LndTKJ3AA0GEVSUmTUBNWoHHVd6CkCUHwAe9I8vbcKL2acrTGPJjDGxVDen7u+17Ig5 6lGPxpYA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kG286-0006MN-SN; Wed, 09 Sep 2020 15:35:26 +0000 Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kG280-0006JP-H4 for wcn36xx@lists.infradead.org; Wed, 09 Sep 2020 15:35:24 +0000 Received: by mail-wr1-x441.google.com with SMTP id a17so3457259wrn.6 for ; Wed, 09 Sep 2020 08:35:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=3yl/nnkmmjEV1dEUeIEWBah0JAShNSUhA1OGmxb4SHg=; b=TWMgl3rqh8xfOJBvdb20gacEaA8MPiLOlqUOzrXRVZ8tijmSKlo/Q5cssfCvRT14vC 5sFOSBqhB1ErAKBysIERtHmKRmqJEzyVVO+bzaaccsXlEj42DZYvLadV/9ZFmqSuWbKn 7SGh6axVSVxXc4hUfH0wYaaUxdIhZQLU1Md5PqPd1qahacaMrzPx8Kqi9kxirh1ilgz4 HC8sofnMtgerLoB9c+QoWxrQbawZqzea8TBtBlNDsYHhpWE1olk6hDvtkhhj2GLQ5UfB 8LFzDPFTFTURFAMEL5oIEezpKmfJS9ZfVGLAjaaT7hZruOMxLfuK4CxwXB2tNCKZi1IB p/yw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=3yl/nnkmmjEV1dEUeIEWBah0JAShNSUhA1OGmxb4SHg=; b=KuHK2x04Hmebotfb4uyw8CXhq//3uXcQ3uJqvOdNSKflEQzVTEuz2seR0AA85gxHWR Pb7tRV8xm3JmnEsochMOfB3YECk6E0iBvs2VH0JKbpPEwlLQ2H7r4XJveNSBMDuQTP1x uc2A2wO6ktAnHqVAc5okJF+x4cm1BkvnNQwmTxPxt2dYUNHXl2w4xmLNonzn2f6fKlCp eHlsaYC1GDamm5QRfBMYKxMxiMYtTtcvTtV9Idv4NHpPVxx3H7tDmYwkPQQg2ykhN360 sO2NsbKBmwgTtLeyFwMmD0D5F7qqX69cDXlcKQV5PfpsnHhZSGxH6jRLc2q7Hh2NMEQn gpAA== X-Gm-Message-State: AOAM530WZx0Ms9dtXCmTCzKGas3du0f09rk89YprENAOCnm7zLEqwCCI Oz+U9YfcyA/kq040rh1FI1hu6w== X-Received: by 2002:adf:dd0b:: with SMTP id a11mr4415955wrm.422.1599665719547; Wed, 09 Sep 2020 08:35:19 -0700 (PDT) Received: from sagittarius-a.chello.ie (188-141-3-169.dynamic.upc.ie. [188.141.3.169]) by smtp.gmail.com with ESMTPSA id s2sm4473335wrw.96.2020.09.09.08.35.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Sep 2020 08:35:18 -0700 (PDT) From: Bryan O'Donoghue To: kvalo@codeaurora.org, wcn36xx@lists.infradead.org, linux-wireless@vger.kernel.org Subject: [PATCH v4 0/7] wcn36xx: Add a set of helpers to enable VHT parameter passing Date: Wed, 9 Sep 2020 16:36:00 +0100 Message-Id: <20200909153607.2904822-1-bryan.odonoghue@linaro.org> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200909_113520_577929_27B4C83F X-CRM114-Status: GOOD ( 14.91 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:441 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: wcn36xx@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: bryan.odonoghue@linaro.org, shawn.guo@linaro.org, loic.poulain@linaro.org Sender: "wcn36xx" Errors-To: wcn36xx-bounces+patch=linaro.org@lists.infradead.org This series is two in a set of seven to add support for wcn3680 at 802.11ac data-rates. V4: - No functional change. Sending out full set again using --base=ath-202009090652 to aid kernel test robot - https://lore.kernel.org/linux-wireless/20200908182437.2870281-1-bryan.odonoghue@linaro.org/T/#t V3: - Enables MU-MIMO bits in wcn36xx_smd_set_sta_vht_params() - Adds a set of helper functions. In the previous set these unused declarations would cause a warning during compile because they were declared static with the intention to add code later on to use them. To resolve that, I do not declare the functions static. Static declaration is done in a later patch after the functions have been used. - There are two good reasons for this: 1. Granularity. I think its important and useful to have a patch per function that clearly sets out what it does and why. 2. Patch size. Declaring seven functions at the time of their first use is not good practice. I think maintaining patch granularity is a good enough reason to not squash these commits down. It is pretty trivial to declare the functions static later on without generating compile warnings in the interregnum. V2: This set makes a series of modifications to enable passing of an extended V1 data-structure to the firmware. A series of of helper functions are added to facilitate the setup. The final step in the process is enabling the extended data-structure parameter passing for the wcn3680 only. Only a firmware that is capable of 80211.ac will accept the larger V1 messages and only after explicitly enabling the DOT11AC firmware feature bit. - No functional difference from V1 for these patches Breaking into smaller chunks to enable easier review/merging V1: https://lore.kernel.org/linux-wireless/87eensldhi.fsf@codeaurora.org/T/#t Bryan O'Donoghue (7): wcn36xx: Add wcn36xx_set_default_rates_v1 wcn36xx: Add wcn36xx_smd_set_sta_default_vht_params() wcn36xx: Add wcn36xx_smd_set_sta_default_ht_ldpc_params() wcn36xx: Add wcn36xx_smd_set_sta_vht_params() wcn36xx: Add wcn36xx_smd_set_sta_ht_ldpc_params() wcn36xx: Add wcn36xx_smd_set_bss_vht_params() wcn36xx: Add wrapper function wcn36xx_smd_set_sta_params_v1() drivers/net/wireless/ath/wcn36xx/main.c | 8 ++ drivers/net/wireless/ath/wcn36xx/smd.c | 90 ++++++++++++++++++++++ drivers/net/wireless/ath/wcn36xx/wcn36xx.h | 1 + 3 files changed, 99 insertions(+) base-commit: 160b351d75cb50a0dd2abf9b63e1891935aa9e4a prerequisite-patch-id: 9a4ac7faca179f6594c9b3a115ee69a2da540a69 prerequisite-patch-id: 183286f9c22d1aaa12f356651224e6b337ef1938 -- 2.27.0 _______________________________________________ wcn36xx mailing list wcn36xx@lists.infradead.org http://lists.infradead.org/mailman/listinfo/wcn36xx