mbox series

[0/1] Re: wifi: mac80211: don't ask rate control with zero rate mask if scanning

Message ID 20240125090737.49673-1-dmantipov@yandex.ru
Headers show
Series Re: wifi: mac80211: don't ask rate control with zero rate mask if scanning | expand

Message

Dmitry Antipov Jan. 25, 2024, 9:07 a.m. UTC 
Well, the literal approach to "not even use the bitrate mask for scanning"
may look like the following. It fixes an original WARN_ONCE() as reported
by syzkaller, but I'm definitely interesting on how to check whether it
doesn't break something else.

Dmitry Antipov (1):
  wifi: mac80211: ignore the bitrate mask when scanning

 include/net/mac80211.h | 3 +++
 net/mac80211/rate.c    | 4 +++-
 net/mac80211/scan.c    | 2 ++
 3 files changed, 8 insertions(+), 1 deletion(-)

Comments

Johannes Berg Jan. 26, 2024, 10:05 a.m. UTC | #1 
On Thu, 2024-01-25 at 12:07 +0300, Dmitry Antipov wrote:
> Well, the literal approach to "not even use the bitrate mask for scanning"
> may look like the following. It fixes an original WARN_ONCE() as reported
> by syzkaller, but I'm definitely interesting on how to check whether it
> doesn't break something else.

I will always run the hwsim tests in hostap, but I'm not really
concerned it would break anything - this was never really _intended_ to
cover scanning in the first place.

johannes