mbox series

[0/2] CLeanup scan_flags from struct ath12k_wmi_scan_req_arg

Message ID 20240211145548.1939610-1-nico.escande@gmail.com
Headers show
Series CLeanup scan_flags from struct ath12k_wmi_scan_req_arg | expand

Message

Nicolas Escande Feb. 11, 2024, 2:55 p.m. UTC 
As previously done for ath11k (see [1] lets fixup struct ath12k_wmi_scan_req_arg
to remove the scan_flags member. This prevent future use of out of sync
WMI_SCAN_XXX defines & their corresponding scan_f_xxx corresponding bitfields

[1] https://lore.kernel.org/all/20240209113536.266822-1-nico.escande@gmail.com/

Nicolas Escande (2):
  wifi: ath12k: do not use scan_flags from struct
  wifi: ath12k: Remove unused scan_flags from struct

 drivers/net/wireless/ath/ath12k/mac.c |  4 +-
 drivers/net/wireless/ath/ath12k/wmi.c |  2 +-
 drivers/net/wireless/ath/ath12k/wmi.h | 55 ++++++++++++---------------
 3 files changed, 28 insertions(+), 33 deletions(-)

Comments

Jeff Johnson Feb. 12, 2024, 6:50 p.m. UTC | #1 
On 2/11/2024 6:55 AM, Nicolas Escande wrote:
> As discussed in [1] to fix the mismatch between the WMI_SCAN_XXX macros &
> their corresponding scan_f_xxx bitfield equivalent, lets stop using the
> scan_flags in the union altogether.
> 
> [1] https://lore.kernel.org/all/4be7d62e-cb59-462d-aac2-94e27efc22ff@quicinc.com/
> 
> Tested-on: QCN9274 hw2.0 PCI CI_WLAN.WBE.1.3-02907.1-QCAHKSWPL_SILICONZ-10
> 
> Signed-off-by: Nicolas Escande <nico.escande@gmail.com>
Acked-by: Jeff Johnson <quic_jjohnson@quicinc.com>