mbox series

[v3,0/4] wifi: ath12k: Fix the static checker warning

Message ID 20250111090129.2733338-1-quic_periyasa@quicinc.com
Headers show
Series wifi: ath12k: Fix the static checker warning | expand

Message

Karthikeyan Periyasamy Jan. 11, 2025, 9:01 a.m. UTC 
This patch series fix the below Smatch static checker warnings

Warnings:
mac.c:10941 ath12k_mac_destroy() error: we previously assumed 'ab' could be null (see line 11348)
mac.c:11007 ath12k_mac_allocate() error: uninitialized symbol 'ab'.
mac.c:11013 ath12k_mac_allocate() error: uninitialized symbol 'ab'.

v3:
 wifi: ath12k: Remove ath12k_get_num_hw() helper function
  - Renamed the patch title
  - Removed ath12k_get_num_hw() helper function
v2:
 - Rebased on ToT

Karthikeyan Periyasamy (4):
  wifi: ath12k: Refactor ath12k_hw set helper function argument
  wifi: ath12k: Refactor the ath12k_hw get helper function argument
  wifi: ath12k: Remove ath12k_get_num_hw() helper function
  wifi: ath12k: Fix uninitialized variable access in
    ath12k_mac_allocate() function

 drivers/net/wireless/ath/ath12k/core.c | 20 ++++++-----
 drivers/net/wireless/ath/ath12k/core.h | 13 +++----
 drivers/net/wireless/ath/ath12k/mac.c  | 47 +++++++++++++++++---------
 3 files changed, 47 insertions(+), 33 deletions(-)


base-commit: 0c5fcd9069dd5f984e39820629acbfbe0f1b4256

Comments

Karthikeyan Periyasamy Jan. 12, 2025, 6:54 a.m. UTC | #1 
On 1/11/2025 2:31 PM, Karthikeyan Periyasamy wrote:
> This patch series fix the below Smatch static checker warnings
> 
> Warnings:
> mac.c:10941 ath12k_mac_destroy() error: we previously assumed 'ab' could be null (see line 11348)
> mac.c:11007 ath12k_mac_allocate() error: uninitialized symbol 'ab'.
> mac.c:11013 ath12k_mac_allocate() error: uninitialized symbol 'ab'.
> 
> v3:
>   wifi: ath12k: Remove ath12k_get_num_hw() helper function
>    - Renamed the patch title
>    - Removed ath12k_get_num_hw() helper function
> v2:
>   - Rebased on ToT
> 
> Karthikeyan Periyasamy (4):
>    wifi: ath12k: Refactor ath12k_hw set helper function argument
>    wifi: ath12k: Refactor the ath12k_hw get helper function argument
>    wifi: ath12k: Remove ath12k_get_num_hw() helper function
>    wifi: ath12k: Fix uninitialized variable access in
>      ath12k_mac_allocate() function
> 
>   drivers/net/wireless/ath/ath12k/core.c | 20 ++++++-----
>   drivers/net/wireless/ath/ath12k/core.h | 13 +++----
>   drivers/net/wireless/ath/ath12k/mac.c  | 47 +++++++++++++++++---------
>   3 files changed, 47 insertions(+), 33 deletions(-)
> 
> 
> base-commit: 0c5fcd9069dd5f984e39820629acbfbe0f1b4256


Ignore this patch, will send the next version with updated copyrights.