mbox series

[ath-next,v2,0/2] wifi: ath12k: set proper key flags and MIC space for CCMP256 and GCMP ciphers

Message ID 20250415195812.2633923-1-rameshkumar.sundaram@oss.qualcomm.com
Headers show
Series wifi: ath12k: set proper key flags and MIC space for CCMP256 and GCMP ciphers | expand

Message

Rameshkumar Sundaram April 15, 2025, 7:58 p.m. UTC 
Currently for CCMP256, GCMP128 and GCMP256 ciphers, Management key flags
are not set properly and MIC space is not added based on the cipher used.

This results in unexpected drop of protected management frames in case
either of above 3 ciphers is used.
Fix this by setting IEEE80211_KEY_FLAG_GENERATE_IV_MGMT flag for above
ciphers and by reserving proper MIC length for those ciphers.

*v2:
 - Rebased on ToT

Rameshkumar Sundaram (2):
  wifi: ath12k: fix wrong handling of CCMP256 and GCMP ciphers
  wifi: ath12k: avoid multiple skb_cb fetch in ath12k_mac_mgmt_tx_wmi()

 drivers/net/wireless/ath/ath12k/dp_rx.c |  3 +--
 drivers/net/wireless/ath/ath12k/dp_rx.h |  3 +++
 drivers/net/wireless/ath/ath12k/mac.c   | 22 +++++++++++++---------
 3 files changed, 17 insertions(+), 11 deletions(-)


base-commit: d0bcc5eaaa611aacbffe6b2cc2fb64bfc3bdfcbc

Comments

Jeff Johnson April 17, 2025, 10:57 p.m. UTC | #1 
On Wed, 16 Apr 2025 01:28:10 +0530, Rameshkumar Sundaram wrote:
> Currently for CCMP256, GCMP128 and GCMP256 ciphers, Management key flags
> are not set properly and MIC space is not added based on the cipher used.
> 
> This results in unexpected drop of protected management frames in case
> either of above 3 ciphers is used.
> Fix this by setting IEEE80211_KEY_FLAG_GENERATE_IV_MGMT flag for above
> ciphers and by reserving proper MIC length for those ciphers.
> 
> [...]

Applied, thanks!

[1/2] wifi: ath12k: fix wrong handling of CCMP256 and GCMP ciphers
      commit: f5d6b15d9503263d9425dcde9cc2fd401a32b0f2
[2/2] wifi: ath12k: avoid multiple skb_cb fetch in ath12k_mac_mgmt_tx_wmi()
      commit: 0ca04ad0cdfb7ac2ebd79dcffebe4806e8707a74

Best regards,