mbox series

[ath-next,0/2] wifi: ath12k: Fix asymmetry between ath12k_core_init() and ath12k_core_deinit()

Message ID 20250423055650.16230-1-quic_yintang@quicinc.com
Headers show
Series wifi: ath12k: Fix asymmetry between ath12k_core_init() and ath12k_core_deinit() | expand

Message

Yingying Tang April 23, 2025, 5:56 a.m. UTC 
There is asymmetry between ath12k_core_init and() ath12k_core_deinit(). 
It will cause page fault in some case. Reorder and relocate the release of
resources in ath12k_core_deinit() to avoid this asymmetry issue.

Yingying Tang (2):
  wifi: ath12k: Reorder and relocate the release of resources in
    ath12k_core_deinit()
  wifi: ath12k: Adjust the process of resource release for ahb bus

 drivers/net/wireless/ath/ath12k/ahb.c  | 5 ++---
 drivers/net/wireless/ath/ath12k/core.c | 5 ++---
 drivers/net/wireless/ath/ath12k/core.h | 1 +
 drivers/net/wireless/ath/ath12k/pci.c  | 5 ++---
 4 files changed, 7 insertions(+), 9 deletions(-)
---
base-commit: 89ac53e96217bd5525ee56eaa1b8ef2b398a9ad6

Comments

Vasanthakumar Thiagarajan April 29, 2025, 5:18 a.m. UTC | #1 
On 4/23/2025 11:26 AM, Yingying Tang wrote:
> There is asymmetry between ath12k_core_init and() ath12k_core_deinit().
> It will cause page fault in some case. Reorder and relocate the release of
> resources in ath12k_core_deinit() to avoid this asymmetry issue.
> 
> Yingying Tang (2):
>    wifi: ath12k: Reorder and relocate the release of resources in
>      ath12k_core_deinit()
>    wifi: ath12k: Adjust the process of resource release for ahb bus
> 
>   drivers/net/wireless/ath/ath12k/ahb.c  | 5 ++---
>   drivers/net/wireless/ath/ath12k/core.c | 5 ++---
>   drivers/net/wireless/ath/ath12k/core.h | 1 +
>   drivers/net/wireless/ath/ath12k/pci.c  | 5 ++---
>   4 files changed, 7 insertions(+), 9 deletions(-)

Reviewed-by: Vasanthakumar Thiagarajan <vasanthakumar.thiagarajan@oss.qualcomm.com>
Jeff Johnson May 19, 2025, 5:48 p.m. UTC | #2 
On Wed, 23 Apr 2025 11:26:48 +0530, Yingying Tang wrote:
> There is asymmetry between ath12k_core_init and() ath12k_core_deinit().
> It will cause page fault in some case. Reorder and relocate the release of
> resources in ath12k_core_deinit() to avoid this asymmetry issue.
> 
> Yingying Tang (2):
>   wifi: ath12k: Reorder and relocate the release of resources in
>     ath12k_core_deinit()
>   wifi: ath12k: Adjust the process of resource release for ahb bus
> 
> [...]

Applied, thanks!

[1/2] wifi: ath12k: Reorder and relocate the release of resources in ath12k_core_deinit()
      commit: aabd3be90579ed088aa34f0584ab6836c735c76f
[2/2] wifi: ath12k: Adjust the process of resource release for ahb bus
      commit: 167e6fc7a4471db2c88bb8da32ac444734a41cea

Best regards,