From patchwork Wed Sep 9 15:37:52 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bryan O'Donoghue X-Patchwork-Id: 249504 Delivered-To: patch@linaro.org Received: by 2002:a92:5b9c:0:0:0:0:0 with SMTP id c28csp525102ilg; Wed, 9 Sep 2020 08:37:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwyTPqKOfpgeEFgPo0psBKwiozU3a3ygZ8rregttJtlVWC4Uzg661e/auCpPOmHmBKty2ZQ X-Received: by 2002:a92:9646:: with SMTP id g67mr4277250ilh.116.1599665833441; Wed, 09 Sep 2020 08:37:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599665833; cv=none; d=google.com; s=arc-20160816; b=uQfBmUOMH7HwGpsH/xgdosK6qHIepba6k8kGCSKGa9Yx9ItIZGLmuIHrY84yYiMJ61 sKoFXY9QPGY98eeAbERueTuhYrWeAe18adc5mfru6JqX//JbNWIqE8athADsz6zVWlog crAJE8fgtg+WoXEBEJRMJzUSOGvh1/kFsfCip/5EJ+GFp17VTd4F6b5tmM7YmhU7/D73 u9jJvYZIFa0gcdhPeXBiD525gS0kfP7GzGotMdRvKHw0UEcoHjeF2a3VF7+RYyROHl6J 3RuCVyjlzr27NsDhGPpN4zG3TgTjwoWLj6KBWx39lef/723d7lnotE+u1HI9eMvoAyxp YA1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:sender:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:dkim-signature; bh=LjdB+S4LEnt5bGoRCmlvVuHUL37VvEE+2IBeNlBO47w=; b=OAgoDk+XuTP9hfrZ9ZtHVZSKG193u/bj2IxGE9yRXMMW8s3LO6Xp985z5CsrWBs3Ja qUXeEv0hl0SPv6GueJDTWCEelPUK1D0LisCdUuy50vtI2v2gyOUyO67vZevwWiBp6Djx TN6Y3r+oYzb7bY4Md5/El/4n6ZXhWbQceM/S1ozR0i1lzMC/izR2txENRYv+jNX3uC89 mYGbBRvbeiST5qtJUHp3xdsDTzrLgLINPCt5y5U1Ds1kUp84B5x1QBl2R2Z+Dr5xagcr yhKVE2yH4pEURZAoGrU6R+KQ5IX68wIMACeb34+CSo4XE+/tcRZV5W0X+BGMQHdw7Ryb 2bjg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.infradead.org header.s=merlin.20170209 header.b=airSSWyJ; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b="lxcfZku/"; spf=pass (google.com: best guess record for domain of wcn36xx-bounces+patch=linaro.org@lists.infradead.org designates 2001:8b0:10b:1231::1 as permitted sender) smtp.mailfrom="wcn36xx-bounces+patch=linaro.org@lists.infradead.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from merlin.infradead.org (merlin.infradead.org. [2001:8b0:10b:1231::1]) by mx.google.com with ESMTPS id e13si3507316jaq.72.2020.09.09.08.37.13 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Sep 2020 08:37:13 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of wcn36xx-bounces+patch=linaro.org@lists.infradead.org designates 2001:8b0:10b:1231::1 as permitted sender) client-ip=2001:8b0:10b:1231::1; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.infradead.org header.s=merlin.20170209 header.b=airSSWyJ; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b="lxcfZku/"; spf=pass (google.com: best guess record for domain of wcn36xx-bounces+patch=linaro.org@lists.infradead.org designates 2001:8b0:10b:1231::1 as permitted sender) smtp.mailfrom="wcn36xx-bounces+patch=linaro.org@lists.infradead.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=LjdB+S4LEnt5bGoRCmlvVuHUL37VvEE+2IBeNlBO47w=; b=airSSWyJep1DvF9W7VT69JjoL NF/aXRZ7wePT/AI/U9Y90M7eiaNiTmVj8Lyg32/RO9OFVWBg+seKsF+ZynoYqwynmRB6YlzmUPyHt q7y3hAtXxaR0NwJEwotWQ3kftC3mUK35rTJ/BSJhCBxixGRTkgPrtujbWg2nSZqsTUvg0rXoKfprJ bxJwD1de8hgXEHDXM34TaI2jU4dWxsbQ4AHZKOWxUwgOoWEnPM499AQJJgZlIdSy3muGBzHZj8MZt 4qoCJ4xHUFqGno09mTRaDkN6aB2CsAWri4m4N5JDjKNUWY8pmh8EqY5hEmICWMp7E462H4MuqExi+ 4lyCYaj3w==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kG29m-0006pm-41; Wed, 09 Sep 2020 15:37:10 +0000 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kG29j-0006oU-Ah for wcn36xx@lists.infradead.org; Wed, 09 Sep 2020 15:37:08 +0000 Received: by mail-wm1-x341.google.com with SMTP id q9so2736433wmj.2 for ; Wed, 09 Sep 2020 08:37:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=YTwsOssKLuWm0RN1XuxIWtatvqfRvgRgu4IUBKS+A1E=; b=lxcfZku/uhGuk8yokqH2WaZ+jloQ85lqillMPiqaXSgPvhWT5/qCvOt/LB29RZcYHg mIllMij6oOC4gS/aTj1qiiXjdL6xxeAEE3MUZEpbx8v1iaA9JBC6Dg9RUtHPUWXgueFH xzqsnItJ6S25o8nyjQDZNzAFI5B+qjU4kTckRFaZ7kKf+9F0Bnvz2Aie0Bi6+vVKctLM JjDtMFe0a9Vh+HASj4sW3YcwGueVpy1UN6KAf9YpbHZLI/u8zkOQzQejW8XcmVwttZfE knPSyLxE+CBsvyi5OCbyRRV55R+SUHGqaRNhDzgwIpsbpxSfe9yzxSKHN+xdQSuRRoC3 Jx5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=YTwsOssKLuWm0RN1XuxIWtatvqfRvgRgu4IUBKS+A1E=; b=rKNkgwO+g+Ykj7fLOiK6nfYxvMF9Jp/OybkCpcelXFGL+bc+Y/bctISLm/2hxVBmpw XcGHykESaVrTXBtq8johmqRK7YjtZMiMerEP1201+aOELh+tRyC4ANr0WIr4a36dA+5K qpKmlWgG5G4/2Wp7mahoUK2tMmq7GKUP05yRCgojLC9MVerhpQvokb4c3MvOXgyH362D ds4HVvrsTk2bihzRG5c6bzvml2ZXSxY9bff6QJRq+AKAuw+jwcKmwGgyWeLOQfKSM9VX 3BG3PqZ0W1j3pis9qOOtgYcK1ErFsHMSymqfrJtjY0KrHNSu2TQiMj56qpSd6gaX5c9K xlmw== X-Gm-Message-State: AOAM530DFpTNZsPbbX/OgE6MPlhTJMwPSB0GAwGiHs0NPY2glsVXgEia SdN2pWuqP7sm04g+7OUgcda2zQ== X-Received: by 2002:a7b:c753:: with SMTP id w19mr4009720wmk.157.1599665826371; Wed, 09 Sep 2020 08:37:06 -0700 (PDT) Received: from sagittarius-a.chello.ie (188-141-3-169.dynamic.upc.ie. [188.141.3.169]) by smtp.gmail.com with ESMTPSA id a83sm4424122wmh.48.2020.09.09.08.37.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Sep 2020 08:37:05 -0700 (PDT) From: Bryan O'Donoghue To: kvalo@codeaurora.org, wcn36xx@lists.infradead.org, linux-wireless@vger.kernel.org Subject: [PATCH v4 1/2] wcn36xx: Mark internal smd functions static Date: Wed, 9 Sep 2020 16:37:52 +0100 Message-Id: <20200909153753.2905176-2-bryan.odonoghue@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200909153753.2905176-1-bryan.odonoghue@linaro.org> References: <20200909153753.2905176-1-bryan.odonoghue@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200909_113707_401520_4079F072 X-CRM114-Status: GOOD ( 14.47 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:341 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: wcn36xx@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: bryan.odonoghue@linaro.org, shawn.guo@linaro.org, loic.poulain@linaro.org Sender: "wcn36xx" Errors-To: wcn36xx-bounces+patch=linaro.org@lists.infradead.org This commit marks all smd.c functions that are only used inside of smd.c as static. Previous commits added some VHT specific setup functions non-static which is the right thing to do in terms of having granular git commits that compile warning free. What we really want is for local not global scope on those functions. This patch makes the conversion from global to local scope. Signed-off-by: Bryan O'Donoghue --- drivers/net/wireless/ath/wcn36xx/smd.c | 34 ++++++++++++++------------ 1 file changed, 18 insertions(+), 16 deletions(-) -- 2.27.0 _______________________________________________ wcn36xx mailing list wcn36xx@lists.infradead.org http://lists.infradead.org/mailman/listinfo/wcn36xx diff --git a/drivers/net/wireless/ath/wcn36xx/smd.c b/drivers/net/wireless/ath/wcn36xx/smd.c index 18507b4d3681..61d9834b080d 100644 --- a/drivers/net/wireless/ath/wcn36xx/smd.c +++ b/drivers/net/wireless/ath/wcn36xx/smd.c @@ -80,7 +80,7 @@ static struct wcn36xx_cfg_val wcn36xx_cfg_vals[] = { WCN36XX_CFG_VAL(ENABLE_DYNAMIC_RA_START_RATE, 133), /* MCS 5 */ }; -struct wcn36xx_cfg_val wcn3680_cfg_vals[] = { +static struct wcn36xx_cfg_val wcn3680_cfg_vals[] = { WCN36XX_CFG_VAL(CURRENT_TX_ANTENNA, 1), WCN36XX_CFG_VAL(CURRENT_RX_ANTENNA, 1), WCN36XX_CFG_VAL(LOW_GAIN_OVERRIDE, 0), @@ -242,7 +242,7 @@ static void wcn36xx_smd_set_bss_ht_params(struct ieee80211_vif *vif, } } -void +static void wcn36xx_smd_set_bss_vht_params(struct ieee80211_vif *vif, struct ieee80211_sta *sta, struct wcn36xx_hal_config_bss_params_v1 *bss) @@ -279,7 +279,7 @@ static void wcn36xx_smd_set_sta_ht_params(struct ieee80211_sta *sta, } } -void wcn36xx_smd_set_sta_vht_params(struct wcn36xx *wcn, +static void wcn36xx_smd_set_sta_vht_params(struct wcn36xx *wcn, struct ieee80211_sta *sta, struct wcn36xx_hal_config_sta_params_v1 *sta_params) { @@ -301,7 +301,7 @@ void wcn36xx_smd_set_sta_vht_params(struct wcn36xx *wcn, } } -void wcn36xx_smd_set_sta_ht_ldpc_params(struct ieee80211_sta *sta, +static void wcn36xx_smd_set_sta_ht_ldpc_params(struct ieee80211_sta *sta, struct wcn36xx_hal_config_sta_params_v1 *sta_params) { if (sta->ht_cap.ht_supported) { @@ -326,7 +326,7 @@ static void wcn36xx_smd_set_sta_default_ht_params( sta_params->dsss_cck_mode_40mhz = 1; } -void wcn36xx_smd_set_sta_default_vht_params(struct wcn36xx *wcn, +static void wcn36xx_smd_set_sta_default_vht_params(struct wcn36xx *wcn, struct wcn36xx_hal_config_sta_params_v1 *sta_params) { if (wcn->rf_id == RF_IRIS_WCN3680) { @@ -342,7 +342,7 @@ void wcn36xx_smd_set_sta_default_vht_params(struct wcn36xx *wcn, sta_params->vht_tx_bf_enabled = 0; } -void wcn36xx_smd_set_sta_default_ht_ldpc_params(struct wcn36xx *wcn, +static void wcn36xx_smd_set_sta_default_ht_ldpc_params(struct wcn36xx *wcn, struct wcn36xx_hal_config_sta_params_v1 *sta_params) { if (wcn->rf_id == RF_IRIS_WCN3680) @@ -1363,7 +1363,7 @@ static void wcn36xx_smd_convert_sta_to_v1(struct wcn36xx *wcn, v1->p2p = orig->p2p; } -void +static void wcn36xx_smd_set_sta_params_v1(struct wcn36xx *wcn, struct ieee80211_vif *vif, struct ieee80211_sta *sta, @@ -1502,12 +1502,12 @@ int wcn36xx_smd_config_sta(struct wcn36xx *wcn, struct ieee80211_vif *vif, return ret; } -void wcn36xx_smd_set_bss_params(struct wcn36xx *wcn, - struct ieee80211_vif *vif, - struct ieee80211_sta *sta, - const u8 *bssid, - bool update, - struct wcn36xx_hal_config_bss_params *bss) +static void wcn36xx_smd_set_bss_params(struct wcn36xx *wcn, + struct ieee80211_vif *vif, + struct ieee80211_sta *sta, + const u8 *bssid, + bool update, + struct wcn36xx_hal_config_bss_params *bss) { struct wcn36xx_vif *vif_priv = wcn36xx_vif_to_priv(vif); struct wcn36xx_hal_config_sta_params *sta_params; @@ -1715,9 +1715,11 @@ static int wcn36xx_smd_config_bss_v1(struct wcn36xx *wcn, return ret; } -int wcn36xx_smd_config_bss_v0(struct wcn36xx *wcn, struct ieee80211_vif *vif, - struct ieee80211_sta *sta, const u8 *bssid, - bool update) +static int wcn36xx_smd_config_bss_v0(struct wcn36xx *wcn, + struct ieee80211_vif *vif, + struct ieee80211_sta *sta, + const u8 *bssid, + bool update) { struct wcn36xx_hal_config_bss_req_msg *msg; struct wcn36xx_hal_config_bss_params *bss;