From patchwork Fri Nov 20 02:14:03 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bryan O'Donoghue X-Patchwork-Id: 329138 Delivered-To: patch@linaro.org Received: by 2002:a17:907:2110:0:0:0:0 with SMTP id qn16csp888577ejb; Thu, 19 Nov 2020 18:13:12 -0800 (PST) X-Google-Smtp-Source: ABdhPJyMKHhAkn1ZvnQBMUB6atqfIDVUWF97RNOtSGNofbb8jYiDrXkqO/eNgobVwhvV8uajPTY5 X-Received: by 2002:ac8:6601:: with SMTP id c1mr14143628qtp.106.1605838391954; Thu, 19 Nov 2020 18:13:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605838391; cv=none; d=google.com; s=arc-20160816; b=jf0rHLiO1Vb8Nhbjzfn41MXON9YqbWBczZ5yzGeKSKqt3PRgmh4EYZzp6i/aOcbrQz 0mZSK721lys9Nrti5VM95hplvP/ea55XWA+Nt7GXckE/vSFzCI89EYXYLC6USNuQ8+Kr OnIGGK+ZhxfrzSFaqA1HdQyJQHKSDq8tE6KcNpcEdOPd8U/2wv/ThWTLXIfWUL/Ef9v0 5ighV0Ijts9qM/p08yk1yDhCULUekVtpocUHoUEzd34jzGWOJ/L6WKRtGmI3HZzFvy7x UBlqNPxEgfTSbH0V++sMsz6cd76Yf4dJp2GsCNZB+IK2Klv++xwXETQ2VUJBVN5uyKpg kImg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:sender:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:dkim-signature; bh=lfXztfvs2dhySJ7g/q1BwjLuqhlnS/d1fQMkQ7ZvEgU=; b=L8A38Evjxiexh5MlYV3uPYjl1HZ2dDbX3mtfBCYrZr2UXN/GHTe0ihkRSWZJn7UQsl vq3qxZYYDw1QqUetZjVqRtpjD54xAke2c/twJGDZcYGg6ofwgQmL8pAhFoX3doQGTelB tVVV5EUfuwWOMYqxakwPkwyxeNPxR5PJrwTDp5aOeo/L/Mj7dLlLQgEuwfU6B3gFOp+W EWgL9AhPnFUY+t8MEcMa2kWHoW6ejuZ7D6Cv+a53AVdMH8xfEHYLTfH6V6mB8cReviMl gT2G8tK3gPIrZoJ2I3NvOyeb0Snup92OeZnN2kgrwqQJM5r6/mAWeN7IcXar55ioczl4 GNgA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.infradead.org header.s=merlin.20170209 header.b=KZwOlKu9; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b="C/c7ppoO"; spf=pass (google.com: best guess record for domain of wcn36xx-bounces+patch=linaro.org@lists.infradead.org designates 2001:8b0:10b:1231::1 as permitted sender) smtp.mailfrom="wcn36xx-bounces+patch=linaro.org@lists.infradead.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from merlin.infradead.org (merlin.infradead.org. [2001:8b0:10b:1231::1]) by mx.google.com with ESMTPS id j13si791708qth.369.2020.11.19.18.13.10 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Nov 2020 18:13:10 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of wcn36xx-bounces+patch=linaro.org@lists.infradead.org designates 2001:8b0:10b:1231::1 as permitted sender) client-ip=2001:8b0:10b:1231::1; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.infradead.org header.s=merlin.20170209 header.b=KZwOlKu9; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b="C/c7ppoO"; spf=pass (google.com: best guess record for domain of wcn36xx-bounces+patch=linaro.org@lists.infradead.org designates 2001:8b0:10b:1231::1 as permitted sender) smtp.mailfrom="wcn36xx-bounces+patch=linaro.org@lists.infradead.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=lfXztfvs2dhySJ7g/q1BwjLuqhlnS/d1fQMkQ7ZvEgU=; b=KZwOlKu9fN81crT4cykvkoRuv mCCW4hxLAU7Twkrj82ciSaYpeT+1cWk5yY7oEzRi/VAPb++4wfTbSIiPMRmb+HPQKP68gAh4l2fGa hHVKWs6R+A7/om+Q+FAtjenfNkRjYbyLA4+pc4z9jUSk4s4UDJWeqm/IQuXSyN71TvQIddJK3jcr6 IV9gyCa4MAZb5mNxF0Lf/lHpzZDo8+3npxfYwM7RaBpc1e/WVXx5BXWMoIGByMxuej2zkGZkwm299 74EoRCtjcVfPJUUBdQdFCAJPSLVjZtgOfG34Puks68IFi9Qndmg+Rj8uHg97rKiDw6Crscpr1rNZ4 BEYovxk9w==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kfvvB-0003YL-GC; Fri, 20 Nov 2020 02:13:09 +0000 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kfvv9-0003Xb-8B for wcn36xx@lists.infradead.org; Fri, 20 Nov 2020 02:13:07 +0000 Received: by mail-wm1-x341.google.com with SMTP id x13so1964843wmj.1 for ; Thu, 19 Nov 2020 18:13:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=8BSPoG1Zi+TALCvJRKxCUtKA+N0pqJkuPFY0LmJPJy0=; b=C/c7ppoOFuQqVYtomLTN/r31dQxxwc7OihdLBhHy2ogjn7pWrOyd2elRJ4cnpUuZ5K B0PoF1tdAKqAq3eJUQLYrGszaEw8ZKJ7/ewgACFyugjm+0DZTLu7Pa6Bu0P4rSsKbxxW Yxb9o9XeQFcG3uGHWBkdx0Dgtup79MxkiKDNh6lJ6mJjaCGmOGOzA2+QS7uTeBG1Y6wU 1ArUneRxLwc4gfCAfCTJMW8Z2Q0SKEiYICPfjkxl/LJh9XBdyskASO7Q+BL9SEnsizQh BAaRgLbElnZYQkaT5daGcCnnhvyXeOXpxEyhYnOclUxHacT9rlMEXqh5yR8fKvyw48wQ HOBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=8BSPoG1Zi+TALCvJRKxCUtKA+N0pqJkuPFY0LmJPJy0=; b=qqkvxZf+HDNDrJdWKsycTbEmsaTAwlw8FsSLW6wMSVM6OU9GhwG5ArLOYeD6YcQ1XN sDAfFHFi2FKLlW+uCRnIILdVOtM86zeZOUnheUU9fdOuLduS22dV32EFGfxU6IhSBnm1 mIxFULmLMeV+z4qvBrjCL2nuLCE4b4NV8eUCNIG6/Gajv9aareFwlvonHbLcLOkdUNpl zNdD3LIOX0hspQaMVuKpgf5E1LHMyXF8Y4qssyUzWr7AtkCuQRkCL48XgFeQJfPJ63mH xgHU3Codo/3JkJkuZjbro8HmZMVXOCM2MdUpRguaKyL+RpmMi04SPbGGIqqc+PYM19qG x45A== X-Gm-Message-State: AOAM5309HZPN2s+99ON7OmcnPWum47m8e7Qk24JbPhhLpfqVlMySBJa4 ucyi5mcmBMfLiVt28Vb58N5xbg== X-Received: by 2002:a1c:f715:: with SMTP id v21mr7158472wmh.2.1605838384588; Thu, 19 Nov 2020 18:13:04 -0800 (PST) Received: from sagittarius-a.chello.ie (188-141-3-169.dynamic.upc.ie. [188.141.3.169]) by smtp.gmail.com with ESMTPSA id c187sm2918261wmd.23.2020.11.19.18.13.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Nov 2020 18:13:04 -0800 (PST) From: Bryan O'Donoghue To: kvalo@codeaurora.org, wcn36xx@lists.infradead.org, linux-wireless@vger.kernel.org Subject: [PATCH] wcn36xx: Send NULL data packet when exiting BMPS Date: Fri, 20 Nov 2020 02:14:03 +0000 Message-Id: <20201120021403.2646574-2-bryan.odonoghue@linaro.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20201120021403.2646574-1-bryan.odonoghue@linaro.org> References: <20201120021403.2646574-1-bryan.odonoghue@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201119_211307_363654_62440523 X-CRM114-Status: GOOD ( 11.03 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:341 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: wcn36xx@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: bryan.odonoghue@linaro.org, shawn.guo@linaro.org, benl@squareup.com, loic.poulain@linaro.org Sender: "wcn36xx" Errors-To: wcn36xx-bounces+patch=linaro.org@lists.infradead.org This commit updates the BMPS exit path to be consistent with downstream in terms of exiting BMPS mode. Downstream sets the flag to send a NULL data frame to the host on exiting BMPS. This will tell the AP to send any queued frames to the STA immediately. Verified the relevant bit toggle in wireshark. Signed-off-by: Bryan O'Donoghue --- drivers/net/wireless/ath/wcn36xx/smd.c | 1 + 1 file changed, 1 insertion(+) -- 2.28.0 _______________________________________________ wcn36xx mailing list wcn36xx@lists.infradead.org http://lists.infradead.org/mailman/listinfo/wcn36xx diff --git a/drivers/net/wireless/ath/wcn36xx/smd.c b/drivers/net/wireless/ath/wcn36xx/smd.c index 8ff1eda8f942..acf533fae46a 100644 --- a/drivers/net/wireless/ath/wcn36xx/smd.c +++ b/drivers/net/wireless/ath/wcn36xx/smd.c @@ -2176,6 +2176,7 @@ int wcn36xx_smd_exit_bmps(struct wcn36xx *wcn, struct ieee80211_vif *vif) INIT_HAL_MSG(msg_body, WCN36XX_HAL_EXIT_BMPS_REQ); msg_body.bss_index = vif_priv->bss_index; + msg_body.send_data_null = 1; PREPARE_HAL_BUF(wcn->hal_buf, msg_body);