| Message ID | 55b5641f-094e-4f94-9f79-ac053733f2cf@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | wifi: rtw88: Prepare to support RTL8814AU (part 1/2) | expand |
Bitterblue Smith <rtl8821cerfe2@gmail.com> wrote: > Don't call ltecoex_read_reg() and ltecoex_reg_write() when the > ltecoex_addr member of struct rtw_chip_info is NULL. The RTL8814AU > doesn't have this feature. > > Signed-off-by: Bitterblue Smith <rtl8821cerfe2@gmail.com> Acked-by: Ping-Ke Shih <pkshih@realtek.com> > --- > v2: > - No change. Next time please take my Acked-by in v1. That will help me to save time in v2.
Bitterblue Smith <rtl8821cerfe2@gmail.com> wrote: > Don't call ltecoex_read_reg() and ltecoex_reg_write() when the > ltecoex_addr member of struct rtw_chip_info is NULL. The RTL8814AU > doesn't have this feature. > > Signed-off-by: Bitterblue Smith <rtl8821cerfe2@gmail.com> > Acked-by: Ping-Ke Shih <pkshih@realtek.com> 9 patch(es) applied to rtw-next branch of rtw.git, thanks. 8425f5c8f04d wifi: rtw88: Fix __rtw_download_firmware() for RTL8814AU 9e8243025cc0 wifi: rtw88: Fix download_firmware_validate() for RTL8814AU 62f726848da4 wifi: rtw88: Extend struct rtw_pwr_track_tbl for RTL8814AU d80e7d9b6ba3 wifi: rtw88: Extend rf_base_addr and rf_sipi_addr for RTL8814AU 8f0076726b66 wifi: rtw88: Extend rtw_fw_send_ra_info() for RTL8814AU e66f3b5c7535 wifi: rtw88: Constify some more structs and arrays ad815f392003 wifi: rtw88: Rename RTW_RATE_SECTION_MAX to RTW_RATE_SECTION_NUM 0f98a5959657 wifi: rtw88: Extend TX power stuff for 3-4 spatial streams 9f00e2218e15 wifi: rtw88: Fix rtw_update_sta_info() for RTL8814AU --- https://github.com/pkshih/rtw.git
On 10/02/2025 03:23, Ping-Ke Shih wrote: > Bitterblue Smith <rtl8821cerfe2@gmail.com> wrote: >> Don't call ltecoex_read_reg() and ltecoex_reg_write() when the >> ltecoex_addr member of struct rtw_chip_info is NULL. The RTL8814AU >> doesn't have this feature. >> >> Signed-off-by: Bitterblue Smith <rtl8821cerfe2@gmail.com> > > Acked-by: Ping-Ke Shih <pkshih@realtek.com> > >> --- >> v2: >> - No change. > > Next time please take my Acked-by in v1. That will help me to save time in v2. > Okay, I will do that.
diff --git a/drivers/net/wireless/realtek/rtw88/mac.c b/drivers/net/wireless/realtek/rtw88/mac.c index cae9cca6dca3..63edf6461de8 100644 --- a/drivers/net/wireless/realtek/rtw88/mac.c +++ b/drivers/net/wireless/realtek/rtw88/mac.c @@ -784,7 +784,8 @@ static int __rtw_download_firmware(struct rtw_dev *rtwdev, if (!check_firmware_size(data, size)) return -EINVAL; - if (!ltecoex_read_reg(rtwdev, 0x38, <ecoex_bckp)) + if (rtwdev->chip->ltecoex_addr && + !ltecoex_read_reg(rtwdev, 0x38, <ecoex_bckp)) return -EBUSY; wlan_cpu_enable(rtwdev, false); @@ -802,7 +803,8 @@ static int __rtw_download_firmware(struct rtw_dev *rtwdev, wlan_cpu_enable(rtwdev, true); - if (!ltecoex_reg_write(rtwdev, 0x38, ltecoex_bckp)) { + if (rtwdev->chip->ltecoex_addr && + !ltecoex_reg_write(rtwdev, 0x38, ltecoex_bckp)) { ret = -EBUSY; goto dlfw_fail; }
Don't call ltecoex_read_reg() and ltecoex_reg_write() when the ltecoex_addr member of struct rtw_chip_info is NULL. The RTL8814AU doesn't have this feature. Signed-off-by: Bitterblue Smith <rtl8821cerfe2@gmail.com> --- v2: - No change. --- drivers/net/wireless/realtek/rtw88/mac.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)