| Message ID | 1510141660-31612-1-git-send-email-amit.pundir@linaro.org |
|---|---|
| Headers | show |
| Series | selftests: firmware: skip testing unsupported features | expand |
Hi Amit, Thanks for your patches. On 8 November 2017 at 17:17, Amit Pundir <amit.pundir@linaro.org> wrote: > Hi, > > At Linaro we run mainline/linux-next selftests on LTS releases and > run into few test failures due to kernel mismatch or missing upstream > functionality in older kernels. Discussed at length here: > https://lkml.org/lkml/2017/6/15/652 > > This patch series is an attempt to modify selftest firmware test scripts. > The proposed changes skip/ignore testing the upstream functionality > missing in the older kernel releases. > > Regards, > Amit Pundir > > > Amit Pundir (2): > selftests: firmware: skip unsupported async loading tests > selftests: firmware: skip unsupported custom firmware fallback tests Please feel free to add my Reviewed-by: Sumit Semwal <sumit.semwal@linaro.org> to both these patches. > > tools/testing/selftests/firmware/fw_fallback.sh | 38 ++++++++++++++++------- > tools/testing/selftests/firmware/fw_filesystem.sh | 34 ++++++++++++-------- > 2 files changed, 47 insertions(+), 25 deletions(-) > > -- > 2.7.4 > Best, Sumit.
On 11/08/2017 04:47 AM, Amit Pundir wrote: > Hi, > > At Linaro we run mainline/linux-next selftests on LTS releases and > run into few test failures due to kernel mismatch or missing upstream > functionality in older kernels. Discussed at length here: > https://lkml.org/lkml/2017/6/15/652 > > This patch series is an attempt to modify selftest firmware test scripts. > The proposed changes skip/ignore testing the upstream functionality > missing in the older kernel releases. > > Regards, > Amit Pundir > > > Amit Pundir (2): > selftests: firmware: skip unsupported async loading tests > selftests: firmware: skip unsupported custom firmware fallback tests > > tools/testing/selftests/firmware/fw_fallback.sh | 38 ++++++++++++++++------- > tools/testing/selftests/firmware/fw_filesystem.sh | 34 ++++++++++++-------- > 2 files changed, 47 insertions(+), 25 deletions(-) > Thanks for the patches. I have couple of minor comments on the patches. Please see the individual responses to the patches. -- Shuah
On Wed, Nov 08, 2017 at 05:17:38PM +0530, Amit Pundir wrote: > Hi, > > At Linaro we run mainline/linux-next selftests on LTS releases and > run into few test failures due to kernel mismatch or missing upstream > functionality in older kernels. Discussed at length here: > https://lkml.org/lkml/2017/6/15/652 > > This patch series is an attempt to modify selftest firmware test scripts. > The proposed changes skip/ignore testing the upstream functionality > missing in the older kernel releases. > > Regards, > Amit Pundir > > > Amit Pundir (2): > selftests: firmware: skip unsupported async loading tests > selftests: firmware: skip unsupported custom firmware fallback tests For both, if you re-send with a Fixes tag that would be appreciated, there is tooling now in place so that when a Fixes tag is used maintainers in a distro kernel merge these patches as well when relevant. If you can resend with that tag, or if Shuah is willing to amend the commit log with them if you provide it: Acked-by: Luis R. Rodriguez <mcgrof@kernel.org> Luis