| Message ID | 20170919010628.175732-1-salil.mehta@huawei.com |
|---|---|
| Headers | show |
| Series | Bug fixes for the HNS3 Ethernet Driver for Hip08 SoC | expand |
On Tue, Sep 19, 2017 at 02:06:21AM +0100, Salil Mehta wrote: > This patch set presents some bug fixes for the HNS3 Ethernet driver, identified > during internal testing & stabilization efforts. > > This patch series is meant for Linux 4.14 kernel. > > Lipeng (6): > net: hns3: get phy addr from NCL_config > net: hns3: fix the command used to unmap ring from vector > net: hns3: Fix ring and vector map command > net: hns3: fix a bug of set mac address > net: hns3: set default vlan id to PF > net: hns3: Fixes the premature exit of loop when matching clients > > Salil Mehta (1): > net: hns3: fixes the ether address copy with more appropriate API 1. The fixes patches should have Fixes line and not all of them have (I didn't look all patches). 2. Please decide on one style: fixes vs. Fixes, fix vs. Fix in the titles 3. Subject should be descriptive and usable, I don't know if it applies to the "fix a bug of set mac address" patch. Thanks > > drivers/net/ethernet/hisilicon/hns3/hnae3.c | 43 +++++----------------- > .../net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.h | 8 +++- > .../ethernet/hisilicon/hns3/hns3pf/hclge_main.c | 20 ++++++++-- > .../net/ethernet/hisilicon/hns3/hns3pf/hns3_enet.c | 7 ++-- > 4 files changed, 35 insertions(+), 43 deletions(-) > > -- > 2.11.0 > >
Hi Leon, > -----Original Message----- > From: Leon Romanovsky [mailto:leon@kernel.org] > Sent: Tuesday, September 19, 2017 4:59 AM > To: Salil Mehta > Cc: davem@davemloft.net; Zhuangyuzeng (Yisen); lipeng (Y); > mehta.salil.lnk@gmail.com; netdev@vger.kernel.org; linux- > kernel@vger.kernel.org; linux-rdma@vger.kernel.org; Linuxarm > Subject: Re: [PATCH net 0/7] Bug fixes for the HNS3 Ethernet Driver for > Hip08 SoC > > On Tue, Sep 19, 2017 at 02:06:21AM +0100, Salil Mehta wrote: > > This patch set presents some bug fixes for the HNS3 Ethernet driver, > identified > > during internal testing & stabilization efforts. > > > > This patch series is meant for Linux 4.14 kernel. > > > > Lipeng (6): > > net: hns3: get phy addr from NCL_config > > net: hns3: fix the command used to unmap ring from vector > > net: hns3: Fix ring and vector map command > > net: hns3: fix a bug of set mac address > > net: hns3: set default vlan id to PF > > net: hns3: Fixes the premature exit of loop when matching clients > > > > Salil Mehta (1): > > net: hns3: fixes the ether address copy with more appropriate API > > 1. The fixes patches should have Fixes line and not all of them have > (I didn't look all patches). > 2. Please decide on one style: fixes vs. Fixes, fix vs. Fix in the > titles > 3. Subject should be descriptive and usable, I don't know if it applies > to the "fix a bug of set mac address" patch. Yes, missed these. Will fix them. Thanks! Salil > > Thanks > > > > > drivers/net/ethernet/hisilicon/hns3/hnae3.c | 43 +++++------- > ---------- > > .../net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.h | 8 +++- > > .../ethernet/hisilicon/hns3/hns3pf/hclge_main.c | 20 ++++++++-- > > .../net/ethernet/hisilicon/hns3/hns3pf/hns3_enet.c | 7 ++-- > > 4 files changed, 35 insertions(+), 43 deletions(-) > > > > -- > > 2.11.0 > > > >