From patchwork Tue Oct 16 01:18:00 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anton Vorontsov X-Patchwork-Id: 12256 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id CD01F23E29 for ; Tue, 16 Oct 2012 01:21:17 +0000 (UTC) Received: from mail-ie0-f180.google.com (mail-ie0-f180.google.com [209.85.223.180]) by fiordland.canonical.com (Postfix) with ESMTP id 606EDA18C83 for ; Tue, 16 Oct 2012 01:21:17 +0000 (UTC) Received: by mail-ie0-f180.google.com with SMTP id e10so8690275iej.11 for ; Mon, 15 Oct 2012 18:21:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-forwarded-to:x-forwarded-for:delivered-to:received-spf:from:to:cc :subject:date:message-id:x-mailer:in-reply-to:references :x-gm-message-state; bh=wZmWaQpkChkVYPgnp/lIhflK2ddAmATzFVS8k8fPrsY=; b=H+axq498d9I0DRui5lv96fCwOFd1Ewe7S/+vWoZ0w2evEyLwM9XWR397AUOFJ2EkJZ rYAvMvvt3hLPQ7y+n0Iw7WYnYwsBdGTveX5ovVmdTSndsdOZ+eu/L+SA52wMSEB7IKAh /TcriwWPMHhcpy+15R5bc7onTeQMEO/CI9OAxJHUk6Xv23iNWi5ls4RA5rFlgKyKHwvl Bp+eCNPaDl7zpWB3n4SaUhdr+9EiF9bpye61/U3m+AjmYEHZQaFWWa20mG5KmiNJaR58 ycUWmjd6BI1o1A8ufuV52voZMk3GlOwHFPg1PpdUHR7DXJeDj+NA8aX5rfc4FKASmwWa TFzA== Received: by 10.50.194.169 with SMTP id hx9mr1719243igc.70.1350350476863; Mon, 15 Oct 2012 18:21:16 -0700 (PDT) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.50.67.148 with SMTP id n20csp659657igt; Mon, 15 Oct 2012 18:21:16 -0700 (PDT) Received: by 10.68.137.228 with SMTP id ql4mr42366362pbb.125.1350350476229; Mon, 15 Oct 2012 18:21:16 -0700 (PDT) Received: from mail-pb0-f50.google.com (mail-pb0-f50.google.com [209.85.160.50]) by mx.google.com with ESMTPS id i9si24189886pay.314.2012.10.15.18.21.16 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 15 Oct 2012 18:21:16 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.160.50 is neither permitted nor denied by best guess record for domain of anton.vorontsov@linaro.org) client-ip=209.85.160.50; Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.160.50 is neither permitted nor denied by best guess record for domain of anton.vorontsov@linaro.org) smtp.mail=anton.vorontsov@linaro.org Received: by mail-pb0-f50.google.com with SMTP id md4so6058032pbc.37 for ; Mon, 15 Oct 2012 18:21:16 -0700 (PDT) Received: by 10.68.218.226 with SMTP id pj2mr42508889pbc.33.1350350475945; Mon, 15 Oct 2012 18:21:15 -0700 (PDT) Received: from localhost (ip-64-134-230-8.public.wayport.net. [64.134.230.8]) by mx.google.com with ESMTPS id o1sm9907956pax.21.2012.10.15.18.21.14 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 15 Oct 2012 18:21:15 -0700 (PDT) From: Anton Vorontsov To: Jason Wessel Cc: Colin Cross , Alan Cox , John Stultz , linux-kernel@vger.kernel.org, linaro-kernel@lists.linaro.org, patches@linaro.org, kernel-team@android.com, kgdb-bugreport@lists.sourceforge.net Subject: [PATCH 2/7] kdb: Rename kdb_repeat_t to kdb_cmdflags_t, cmd_repeat to cmd_flags Date: Mon, 15 Oct 2012 18:18:00 -0700 Message-Id: <1350350285-3095-2-git-send-email-anton.vorontsov@linaro.org> X-Mailer: git-send-email 1.7.12.3 In-Reply-To: <20121016011724.GB23146@lizard> References: <20121016011724.GB23146@lizard> X-Gm-Message-State: ALoCoQn8xVpknf24a5bFLv69MujOXe7wzlyJ7gqG2WqYP+i79FvEaMtEzw4pGEDT1a0m56VCRUbX We're about to add more options for command behaviour, so let's expand the meaning of kdb_repeat_t. So far we just do various renames, there should be no functional changes. Signed-off-by: Anton Vorontsov --- include/linux/kdb.h | 4 ++-- kernel/debug/kdb/kdb_main.c | 6 +++--- kernel/debug/kdb/kdb_private.h | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/include/linux/kdb.h b/include/linux/kdb.h index 7f6fe6e..cbd1c28 100644 --- a/include/linux/kdb.h +++ b/include/linux/kdb.h @@ -17,7 +17,7 @@ typedef enum { KDB_REPEAT_NONE = 0, /* Do not repeat this command */ KDB_REPEAT_NO_ARGS, /* Repeat the command without arguments */ KDB_REPEAT_WITH_ARGS, /* Repeat the command including its arguments */ -} kdb_repeat_t; +} kdb_cmdflags_t; typedef int (*kdb_func_t)(int, const char **); @@ -146,7 +146,7 @@ static inline const char *kdb_walk_kallsyms(loff_t *pos) /* Dynamic kdb shell command registration */ extern int kdb_register(char *, kdb_func_t, char *, char *, short); extern int kdb_register_repeat(char *, kdb_func_t, char *, char *, - short, kdb_repeat_t); + short, kdb_cmdflags_t); extern int kdb_unregister(char *); #else /* ! CONFIG_KGDB_KDB */ static inline __printf(1, 2) int kdb_printf(const char *fmt, ...) { return 0; } diff --git a/kernel/debug/kdb/kdb_main.c b/kernel/debug/kdb/kdb_main.c index cdaaa52..c7a1797 100644 --- a/kernel/debug/kdb/kdb_main.c +++ b/kernel/debug/kdb/kdb_main.c @@ -992,7 +992,7 @@ int kdb_parse(const char *cmdstr) if (result && ignore_errors && result > KDB_CMD_GO) result = 0; KDB_STATE_CLEAR(CMD); - switch (tp->cmd_repeat) { + switch (tp->cmd_flags) { case KDB_REPEAT_NONE: argc = 0; if (argv[0]) @@ -2700,7 +2700,7 @@ int kdb_register_repeat(char *cmd, char *usage, char *help, short minlen, - kdb_repeat_t repeat) + kdb_cmdflags_t flags) { int i; kdbtab_t *kp; @@ -2749,7 +2749,7 @@ int kdb_register_repeat(char *cmd, kp->cmd_usage = usage; kp->cmd_help = help; kp->cmd_minlen = minlen; - kp->cmd_repeat = repeat; + kp->cmd_flags = flags; return 0; } diff --git a/kernel/debug/kdb/kdb_private.h b/kernel/debug/kdb/kdb_private.h index f8245b3..9e1b8e9 100644 --- a/kernel/debug/kdb/kdb_private.h +++ b/kernel/debug/kdb/kdb_private.h @@ -177,7 +177,7 @@ typedef struct _kdbtab { char *cmd_help; /* Help message for this command */ short cmd_minlen; /* Minimum legal # command * chars required */ - kdb_repeat_t cmd_repeat; /* Does command auto repeat on enter? */ + kdb_cmdflags_t cmd_flags; /* Command behaviour flags */ } kdbtab_t; extern int kdb_bt(int, const char **); /* KDB display back trace */