From patchwork Tue Apr 30 17:29:13 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julien Grall X-Patchwork-Id: 16546 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-vb0-f71.google.com (mail-vb0-f71.google.com [209.85.212.71]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 0C5E820065 for ; Tue, 30 Apr 2013 17:29:55 +0000 (UTC) Received: by mail-vb0-f71.google.com with SMTP id w15sf1180253vbb.10 for ; Tue, 30 Apr 2013 10:29:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:mime-version:x-beenthere:x-received:received-spf :x-received:x-forwarded-to:x-forwarded-for:delivered-to:x-received :received-spf:x-received:from:to:cc:subject:date:message-id:x-mailer :x-gm-message-state:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :x-google-group-id:list-post:list-help:list-archive:list-unsubscribe; bh=wIOVJDbMaD2DeIN7Crh1NAJ7kyJb7FJLZqafqNURdRE=; b=XuqF/xpWrAqRqwDWlfmNRJvIl5El29WXLrZWgUwhJ9j0n+NFGqZ/wzfPAdbkiZOpWb boOkia0EP4dvgPmiGiAAOIK3rAiRkhj7C7Dk1OQPAFRhdEZJPymwlX43TwwvGRrxpixo d4jRXQ/vXDrVSnUZTkXxgnEPmeSMdfcR1dvbRYkIL+6mTVLFz2OUvzmjpqEBAEwJecHR XS04K1GTsc/4AsvcaesvJsuFgZfBfc01PmnYazWGIkxONqsnYq/qx3OX8j+fjmMAkN5m DqcsvfxF13ETR/nMbSTe99OHpqQwCzi62GcqCmHcxthwWUw7h82olINR7T2abcmghYqM VFZA== X-Received: by 10.236.117.178 with SMTP id j38mr10433168yhh.45.1367342991419; Tue, 30 Apr 2013 10:29:51 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.49.117.101 with SMTP id kd5ls356876qeb.45.gmail; Tue, 30 Apr 2013 10:29:50 -0700 (PDT) X-Received: by 10.58.15.193 with SMTP id z1mr35415444vec.40.1367342990875; Tue, 30 Apr 2013 10:29:50 -0700 (PDT) Received: from mail-ve0-x22d.google.com (mail-ve0-x22d.google.com [2607:f8b0:400c:c01::22d]) by mx.google.com with ESMTPS id iz8si5327471vdb.110.2013.04.30.10.29.50 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 30 Apr 2013 10:29:50 -0700 (PDT) Received-SPF: neutral (google.com: 2607:f8b0:400c:c01::22d is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=2607:f8b0:400c:c01::22d; Received: by mail-ve0-f173.google.com with SMTP id ox1so606477veb.4 for ; Tue, 30 Apr 2013 10:29:50 -0700 (PDT) X-Received: by 10.58.48.166 with SMTP id m6mr22105870ven.59.1367342990757; Tue, 30 Apr 2013 10:29:50 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.58.127.98 with SMTP id nf2csp117299veb; Tue, 30 Apr 2013 10:29:49 -0700 (PDT) X-Received: by 10.194.71.241 with SMTP id y17mr12086624wju.31.1367342988522; Tue, 30 Apr 2013 10:29:48 -0700 (PDT) Received: from mail-we0-x234.google.com (mail-we0-x234.google.com [2a00:1450:400c:c03::234]) by mx.google.com with ESMTPS id c3si9122698wja.53.2013.04.30.10.29.47 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 30 Apr 2013 10:29:48 -0700 (PDT) Received-SPF: neutral (google.com: 2a00:1450:400c:c03::234 is neither permitted nor denied by best guess record for domain of julien.grall@linaro.org) client-ip=2a00:1450:400c:c03::234; Received: by mail-we0-f180.google.com with SMTP id x43so633330wey.11 for ; Tue, 30 Apr 2013 10:29:47 -0700 (PDT) X-Received: by 10.180.79.227 with SMTP id m3mr26087782wix.12.1367342987821; Tue, 30 Apr 2013 10:29:47 -0700 (PDT) Received: from belegaer.uk.xensource.com. (firewall.ctxuk.citrix.com. [46.33.159.2]) by mx.google.com with ESMTPSA id j4sm27624289wiz.10.2013.04.30.10.29.45 for (version=TLSv1.2 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 30 Apr 2013 10:29:46 -0700 (PDT) From: Julien Grall To: xen-devel@lists.xensource.com, linux-kernel@vger.kernel.org Cc: konrad.wilk@oracle.com, Stefano.Stabellini@eu.citrix.com, patches@linaro.org, Julien Grall Subject: [PATCH V2] xen: clear IRQ_NOAUTOEN and IRQ_NOREQUEST Date: Tue, 30 Apr 2013 18:29:13 +0100 Message-Id: <1367342953-27509-1-git-send-email-julien.grall@linaro.org> X-Mailer: git-send-email 1.7.10.4 X-Gm-Message-State: ALoCoQl6eHalUQRwBmhx0tHtG/UMOfU09DDxwiugF1odZI/mf7QrJPydWzW8/nETWeyU/9WFlBdE X-Original-Sender: julien.grall@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 2607:f8b0:400c:c01::22d is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Precedence: list Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Reset the IRQ_NOAUTOEN and IRQ_NOREQUEST flags that are enabled by default on ARM. If IRQ_NOAUTOEN is set, __setup_irq doesn't call irq_startup, that is responsible for calling irq_unmask at startup time. As a result event channels remain masked. The clear is already made in bind_evtchn_to_irq with commit a8636c0 but was missing on all others bind_*_to_irq. Move the clear in xen_irq_info_common_init. On x86, IRQ_NOAUTOEN and IRQ_NOREQUEST are cleared by default, so this commit doesn't impact this architecture. Signed-off-by: Julien Grall Acked-by: Stefano Stabellini --- Changes since v1: - Specify this commit will not impact x86 in the comment - Clear flag directly in xen_irq_info_common_init, this function is called by all bind_*_to_irq drivers/xen/events.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/xen/events.c b/drivers/xen/events.c index d8cc812..6a6bbe4 100644 --- a/drivers/xen/events.c +++ b/drivers/xen/events.c @@ -167,6 +167,8 @@ static void xen_irq_info_common_init(struct irq_info *info, info->cpu = cpu; evtchn_to_irq[evtchn] = irq; + + irq_clear_status_flags(irq, IRQ_NOREQUEST|IRQ_NOAUTOEN); } static void xen_irq_info_evtchn_init(unsigned irq, @@ -874,7 +876,6 @@ int bind_evtchn_to_irq(unsigned int evtchn) struct irq_info *info = info_for_irq(irq); WARN_ON(info == NULL || info->type != IRQT_EVTCHN); } - irq_clear_status_flags(irq, IRQ_NOREQUEST|IRQ_NOAUTOEN); out: mutex_unlock(&irq_mapping_update_lock);