From patchwork Thu Jun 16 13:14:54 2016
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: "Jon Medhurst \(Tixy\)" <tixy@linaro.org>
X-Patchwork-Id: 70188
Delivered-To: patch@linaro.org
Received: by 10.140.28.4 with SMTP id 4csp256610qgy;
 Thu, 16 Jun 2016 06:15:06 -0700 (PDT)
X-Received: by 10.98.131.206 with SMTP id h197mr5061695pfe.124.1466082906830; 
 Thu, 16 Jun 2016 06:15:06 -0700 (PDT)
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
 by mx.google.com with ESMTP id k9si6023813pfj.91.2016.06.16.06.15.06; 
 Thu, 16 Jun 2016 06:15:06 -0700 (PDT)
Received-SPF: pass (google.com: best guess record for domain of
 linux-kernel-owner@vger.kernel.org designates 209.132.180.67
 as permitted sender) client-ip=209.132.180.67; 
Authentication-Results: mx.google.com;
 spf=pass (google.com: best guess record for domain of
 linux-kernel-owner@vger.kernel.org designates 209.132.180.67
 as permitted sender)
 smtp.mailfrom=linux-kernel-owner@vger.kernel.org; 
 dmarc=fail (p=NONE dis=NONE) header.from=linaro.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
 id S1754295AbcFPNO7 (ORCPT <rfc822;julien.grall@linaro.org>
 + 30 others); Thu, 16 Jun 2016 09:14:59 -0400
Received: from smarthost01b.mail.zen.net.uk ([212.23.1.3]:33561 "EHLO
 smarthost01b.mail.zen.net.uk" rhost-flags-OK-OK-OK-OK)
 by vger.kernel.org with ESMTP id S1753849AbcFPNO6 (ORCPT
 <rfc822;linux-kernel@vger.kernel.org>);
 Thu, 16 Jun 2016 09:14:58 -0400
Received: from [82.69.122.217] (helo=linaro2)
 by smarthost01b.mail.zen.net.uk with esmtpsa
 (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.80)
 (envelope-from <tixy@linaro.org>)
 id 1bDX8J-0006iS-Q7; Thu, 16 Jun 2016 13:14:55 +0000
Message-ID: <1466082894.20208.1.camel@linaro.org>
Subject: Re: [PATCH v2 0/3] firmware: scpi: add device power domain support
From: "Jon Medhurst (Tixy)" <tixy@linaro.org>
To: Sudeep Holla <sudeep.holla@arm.com>
Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
 Ulf Hansson <ulf.hansson@linaro.org>,
 Mathieu Poirier <mathieu.poirier@linaro.org>,
 Suzuki K Poulose <suzuki.poulose@arm.com>
Date: Thu, 16 Jun 2016 14:14:54 +0100
In-Reply-To: <1466073481-697-1-git-send-email-sudeep.holla@arm.com>
References: <1466073481-697-1-git-send-email-sudeep.holla@arm.com>
X-Mailer: Evolution 3.12.9-1+b1 
Mime-Version: 1.0
X-Originating-smarthost01b-IP: [82.69.122.217]
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 2016-06-16 at 11:37 +0100, Sudeep Holla wrote:
> This series add support for SCPI based device device power state
> management using genpd.
> 
> Regards,
> Sudeep
> 
> v1[1]->v2:
> 	- Fixed the endianness handling in scpi_device_get_power_state
> 	  as spotted by Tixy
> 	- Renamed scpi_pd.c to scpi_pm_domain.c as suggested by Ulf

You seemed to also have made some changes to the contents of the file,
is that deliberate? This is the diff...

 static int scpi_pd_power_on(struct generic_pm_domain *domain)

--- a/drivers/firmware/scpi_pm_domain.c
+++ b/drivers/firmware/scpi_pd.c
@@ -27,7 +27,7 @@ struct scpi_pm_domain {
        struct generic_pm_domain genpd;
        struct scpi_ops *ops;
        u32 domain;
-       char name[20];
+       char name[30];
 };
 
 enum scpi_power_domain_state {
@@ -51,7 +51,7 @@ static int scpi_pd_power(struct scpi_pm_domain *pd,
bool power_on)
        if (ret)
                return ret;
 
-       return (state == pd->ops->device_get_power_state(pd->domain));
+       return !(state == pd->ops->device_get_power_state(pd->domain));
 }