From patchwork Thu Jun 16 21:27:14 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Lezcano X-Patchwork-Id: 70240 Delivered-To: patch@linaro.org Received: by 10.140.28.4 with SMTP id 4csp465894qgy; Thu, 16 Jun 2016 14:32:50 -0700 (PDT) X-Received: by 10.66.122.196 with SMTP id lu4mr7672427pab.52.1466112770780; Thu, 16 Jun 2016 14:32:50 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i3si7981819pfb.33.2016.06.16.14.32.49; Thu, 16 Jun 2016 14:32:50 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755403AbcFPVcr (ORCPT + 30 others); Thu, 16 Jun 2016 17:32:47 -0400 Received: from mail-wm0-f53.google.com ([74.125.82.53]:34253 "EHLO mail-wm0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755343AbcFPV3T (ORCPT ); Thu, 16 Jun 2016 17:29:19 -0400 Received: by mail-wm0-f53.google.com with SMTP id k184so34372896wme.1 for ; Thu, 16 Jun 2016 14:29:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=GKQj9lp6LwyJuMbuc5ae5uthdpQ9zSpp5S+Ud5ODZaM=; b=bC+TOyd23ulJvGVqRZcci5HNG5OPH6cvY1V83aIVLmWJpYvcc9xX/e1fUAtH3l61+B CpRFEadXT5mT6Z3/71TOINaklJTTnQkd9MWpq1NZJ5m8g6T/BuosEpA5Esc7EpreT+zL YmxbZ71fOPw/SjZpMRsfwdeqWMFS4OcmuQE0c= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=GKQj9lp6LwyJuMbuc5ae5uthdpQ9zSpp5S+Ud5ODZaM=; b=WLcziYXUGeWXtYSIQdfw8LLjnh6oxykRR1WgyiBcwTGcAKla1hH0Xw2kUbMNse3ApE l48cmPdx/8XsXO7PKBZIy8sxOLsLNRVQq8/hUDo4mzt4ko1roaOA/oAMJWAhUoQhabL5 VK+N962jzKcuDVsv1AYV62ZFo50GZTuUHGdlH2VltaS489wk7Yz1DjZ1CCfnXorCuV9R 4AGgpPI/cK2YTmK6J8ZJ2phd7hWDaBtFhU0evHZzBa8UPrW8us6O6z51YS7B9v6Tqo16 LyXOrgNaWABsXG0fuPYxIaDLRnjw0b9uTMzSlnVKE5lqpPLO6JfX8OEBW58vpj4YMTAk UOaQ== X-Gm-Message-State: ALyK8tId/YBRRSDZNkAIybMc9YbX+oljKFGi2/KFq3HzRYyMYUoGhW82S4vSFhFKMj1bfnST X-Received: by 10.194.34.202 with SMTP id b10mr1540967wjj.47.1466112558432; Thu, 16 Jun 2016 14:29:18 -0700 (PDT) Received: from localhost.localdomain (sju31-1-78-210-255-2.fbx.proxad.net. [78.210.255.2]) by smtp.gmail.com with ESMTPSA id x128sm16705606wmf.6.2016.06.16.14.29.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 16 Jun 2016 14:29:17 -0700 (PDT) From: Daniel Lezcano To: daniel.lezcano@linaro.org, tglx@linutronix.de Cc: linux-kernel@vger.kernel.org Subject: [PATCH V2 55/63] clocksource/drivers/timer-sp804: Convert init function to return error Date: Thu, 16 Jun 2016 23:27:14 +0200 Message-Id: <1466112442-31105-56-git-send-email-daniel.lezcano@linaro.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1466112442-31105-1-git-send-email-daniel.lezcano@linaro.org> References: <1466112442-31105-1-git-send-email-daniel.lezcano@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The init functions do not return any error. They behave as the following: - panic, thus leading to a kernel crash while another timer may work and make the system boot up correctly or - print an error and let the caller unaware if the state of the system Change that by converting the init functions to return an error conforming to the CLOCKSOURCE_OF_RET prototype. Proper error handling (rollback, errno value) will be changed later case by case, thus this change just return back an error or success in the init function. Signed-off-by: Daniel Lezcano --- include/clocksource/timer-sp804.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) -- 1.9.1 diff --git a/include/clocksource/timer-sp804.h b/include/clocksource/timer-sp804.h index 1f8a1ca..7654d71 100644 --- a/include/clocksource/timer-sp804.h +++ b/include/clocksource/timer-sp804.h @@ -3,10 +3,10 @@ struct clk; -void __sp804_clocksource_and_sched_clock_init(void __iomem *, - const char *, struct clk *, int); -void __sp804_clockevents_init(void __iomem *, unsigned int, - struct clk *, const char *); +int __sp804_clocksource_and_sched_clock_init(void __iomem *, + const char *, struct clk *, int); +int __sp804_clockevents_init(void __iomem *, unsigned int, + struct clk *, const char *); void sp804_timer_disable(void __iomem *); static inline void sp804_clocksource_init(void __iomem *base, const char *name)