From patchwork Fri Jun 17 09:48:41 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Juri Lelli X-Patchwork-Id: 70299 Delivered-To: patch@linaro.org Received: by 10.140.28.4 with SMTP id 4csp190988qgy; Fri, 17 Jun 2016 02:49:04 -0700 (PDT) X-Received: by 10.36.65.162 with SMTP id b34mr1758291itd.30.1466156944158; Fri, 17 Jun 2016 02:49:04 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w81si1641356pfi.181.2016.06.17.02.49.03; Fri, 17 Jun 2016 02:49:04 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933367AbcFQJtB (ORCPT + 30 others); Fri, 17 Jun 2016 05:49:01 -0400 Received: from foss.arm.com ([217.140.101.70]:48770 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753211AbcFQJs7 (ORCPT ); Fri, 17 Jun 2016 05:48:59 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D61C1F; Fri, 17 Jun 2016 02:49:41 -0700 (PDT) Received: from e106622-lin.cambridge.arm.com (e106622-lin.cambridge.arm.com [10.1.208.152]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 2F4063F246; Fri, 17 Jun 2016 02:48:58 -0700 (PDT) From: Juri Lelli To: linux-kernel@vger.kernel.org Cc: peterz@infradead.org, mingo@redhat.com, luca.abeni@unitn.it, rostedt@goodmis.org, juri.lelli@arm.com Subject: [PATCH] sched/deadline: remove useless param from setup_new_dl_entity Date: Fri, 17 Jun 2016 10:48:41 +0100 Message-Id: <1466156921-12417-1-git-send-email-juri.lelli@arm.com> X-Mailer: git-send-email 2.7.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org setup_new_dl_entity() takes two parameters, but it only actually uses one of them to setup a new dl_entity. Remove the second, useless, parameter. Cc: Ingo Molnar Cc: Peter Zijlstra Cc: Steven Rostedt Cc: Luca Abeni Signed-off-by: Juri Lelli --- kernel/sched/deadline.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) -- 2.7.0 diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c index fcb7f0217ff4..5229788a4765 100644 --- a/kernel/sched/deadline.c +++ b/kernel/sched/deadline.c @@ -346,8 +346,7 @@ static void check_preempt_curr_dl(struct rq *rq, struct task_struct *p, * one, and to (try to!) reconcile itself with its own scheduling * parameters. */ -static inline void setup_new_dl_entity(struct sched_dl_entity *dl_se, - struct sched_dl_entity *pi_se) +static inline void setup_new_dl_entity(struct sched_dl_entity *dl_se) { struct dl_rq *dl_rq = dl_rq_of_se(dl_se); struct rq *rq = rq_of_dl_rq(dl_rq); @@ -367,8 +366,8 @@ static inline void setup_new_dl_entity(struct sched_dl_entity *dl_se, * future; in fact, we must consider execution overheads (time * spent on hardirq context, etc.). */ - dl_se->deadline = rq_clock(rq) + pi_se->dl_deadline; - dl_se->runtime = pi_se->dl_runtime; + dl_se->deadline = rq_clock(rq) + dl_se->dl_deadline; + dl_se->runtime = dl_se->dl_runtime; } /* @@ -1721,7 +1720,7 @@ static void switched_from_dl(struct rq *rq, struct task_struct *p) static void switched_to_dl(struct rq *rq, struct task_struct *p) { if (dl_time_before(p->dl.deadline, rq_clock(rq))) - setup_new_dl_entity(&p->dl, &p->dl); + setup_new_dl_entity(&p->dl); if (task_on_rq_queued(p) && rq->curr != p) { #ifdef CONFIG_SMP