diff mbox series

[v2,2/5] locking/barriers: Add implicit smp_read_barrier_depends() to READ_ONCE()

Message ID 1508840570-22169-3-git-send-email-will.deacon@arm.com
State Accepted
Commit 76ebbe78f7390aee075a7f3768af197ded1bdfbb
Headers show
Series Get rid of lockless_dereference() | expand

Commit Message

Will Deacon Oct. 24, 2017, 10:22 a.m. UTC
In preparation for the removal of lockless_dereference(), which is the
same as READ_ONCE() on all architectures other than Alpha, add an
implicit smp_read_barrier_depends() to READ_ONCE() so that it can be
used to head dependency chains on all architectures.

Cc: Ingo Molnar <mingo@kernel.org>
Cc: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Signed-off-by: Will Deacon <will.deacon@arm.com>

---
 include/linux/compiler.h | 1 +
 1 file changed, 1 insertion(+)

-- 
2.1.4
diff mbox series

Patch

diff --git a/include/linux/compiler.h b/include/linux/compiler.h
index 08083186e54f..7d7b77da9716 100644
--- a/include/linux/compiler.h
+++ b/include/linux/compiler.h
@@ -242,6 +242,7 @@  static __always_inline void __write_once_size(volatile void *p, void *res, int s
 		__read_once_size(&(x), __u.__c, sizeof(x));		\
 	else								\
 		__read_once_size_nocheck(&(x), __u.__c, sizeof(x));	\
+	smp_read_barrier_depends(); /* Enforce dependency ordering from x */ \
 	__u.__val;							\
 })
 #define READ_ONCE(x) __READ_ONCE(x, 1)