From patchwork Fri Nov 3 14:47:49 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sudeep Holla X-Patchwork-Id: 117919 Delivered-To: patch@linaro.org Received: by 10.80.245.45 with SMTP id t42csp3401855edm; Fri, 3 Nov 2017 07:49:24 -0700 (PDT) X-Google-Smtp-Source: ABhQp+RSH74+rMUTYxFo5CAZY/asOrWDiwLCvHTpXwoVuKIx4lRh8KrKN4x4R/1kgIrFFLEvA/e+ X-Received: by 10.159.211.65 with SMTP id g1mr7145655plp.312.1509720564869; Fri, 03 Nov 2017 07:49:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1509720564; cv=none; d=google.com; s=arc-20160816; b=keC8Zb79888b0QEx6ULWdhtSkWDqoi+Rm9fqPM5KWg62m5bjeYc+o755lfo2KwozuQ LeoZo/hpRH/ZE2ZQ6A9HL98hCRBozs4ik6bN+I5c3eMpIPJ7eiANx0AhfBDjWxx5quNN x6f9rX/mjMfCtJ73J6ni4dup1ZnCm5ZB3/9B8l6nDsX5eFOxP1FL26CFTbDL21+kh0S7 1E7xg9nbapPXQSVDqrkFBrCQMoXX9Iau3b+DXmF1fPeRPMl9CTpgYHKwF3bj/Vx+ZnWv h59pN9kVmhHPiJUXN0mXj3yfpttVesKm9mzFW+ngcpw4+0ZxeRcXGS1v/aDUg9WCMnAP 57tw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=Ywze5g/uqabuiDbmOySf2Ld4of8AjODtc0hpc8auKzI=; b=ewnZuTk9Ed4Hdk/lh8R6Ym+AsVf0Rn+wd7yyLiiPBaeevRThLJhWGFhYxi83ltWLGL nqmi1N/Qs+mY/K/mXUM5lPTWP47er5J+ESk73mfDJSLN3UZYpI2eEAOfMrPBmSliLAWe tmzOhMiNbLZpUWxITGjAj0Vm9cR/m015RqC5ccP986L3vh0C/cQrwvLQ0HU0M8SPjjWn 1VXnj+7lZqqvd+Tkt6STDmEsAN67Qz8prZKBR/78SEzQyzSkahxqo4qwcq6kGa1S5zZG qajmY4RJxpPAfmQX60pROvUxOdAcXfVrA7MDfTgD0rtn5KEuZ7cW0oXW+tFwPSBa4Gjp +ILg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h90si4897294plb.253.2017.11.03.07.49.24; Fri, 03 Nov 2017 07:49:24 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933604AbdKCOtV (ORCPT + 26 others); Fri, 3 Nov 2017 10:49:21 -0400 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:44406 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755726AbdKCOtR (ORCPT ); Fri, 3 Nov 2017 10:49:17 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D949C1596; Fri, 3 Nov 2017 07:49:16 -0700 (PDT) Received: from e107155-lin.cambridge.arm.com (e107155-lin.cambridge.arm.com [10.1.210.28]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id E9DF23F3DF; Fri, 3 Nov 2017 07:49:14 -0700 (PDT) From: Sudeep Holla To: ALKML , LKML , DTML Cc: Sudeep Holla , Roy Franz , Harb Abdulhamid , Nishanth Menon , Arnd Bergmann , Loc Ho , Ryan Harkin , Jassi Brar Subject: [PATCH v4 12/20] firmware: arm_scmi: add option for polling based performance domain operations Date: Fri, 3 Nov 2017 14:47:49 +0000 Message-Id: <1509720477-18936-13-git-send-email-sudeep.holla@arm.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1509720477-18936-1-git-send-email-sudeep.holla@arm.com> References: <1509720477-18936-1-git-send-email-sudeep.holla@arm.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In order to implement fast CPU DVFS switching, we need to perform all DVFS operations atomically. Since SCMI transfer already provide option to choose between pooling vs interrupt driven(default), we can opt for polling based transfers for set,get performance domain operations. This patch adds option to choose between polling vs interrupt driven SCMI transfers for set,get performance level operations. Cc: Arnd Bergmann Signed-off-by: Sudeep Holla --- drivers/firmware/arm_scmi/perf.c | 19 +++++++++++-------- include/linux/scmi_protocol.h | 8 ++++---- 2 files changed, 15 insertions(+), 12 deletions(-) -- 2.7.4 diff --git a/drivers/firmware/arm_scmi/perf.c b/drivers/firmware/arm_scmi/perf.c index a1f5cf136748..ad73ef6b8d7d 100644 --- a/drivers/firmware/arm_scmi/perf.c +++ b/drivers/firmware/arm_scmi/perf.c @@ -303,8 +303,8 @@ static int scmi_perf_limits_get(const struct scmi_handle *handle, u32 domain, return ret; } -static int -scmi_perf_level_set(const struct scmi_handle *handle, u32 domain, u32 level) +static int scmi_perf_level_set(const struct scmi_handle *handle, u32 domain, + u32 level, bool poll) { int ret; struct scmi_xfer *t; @@ -315,6 +315,7 @@ scmi_perf_level_set(const struct scmi_handle *handle, u32 domain, u32 level) if (ret) return ret; + t->hdr.poll_completion = poll; lvl = t->tx.buf; lvl->domain = cpu_to_le32(domain); lvl->level = cpu_to_le32(level); @@ -325,8 +326,8 @@ scmi_perf_level_set(const struct scmi_handle *handle, u32 domain, u32 level) return ret; } -static int -scmi_perf_level_get(const struct scmi_handle *handle, u32 domain, u32 *level) +static int scmi_perf_level_get(const struct scmi_handle *handle, u32 domain, + u32 *level, bool poll) { int ret; struct scmi_xfer *t; @@ -336,6 +337,7 @@ scmi_perf_level_get(const struct scmi_handle *handle, u32 domain, u32 *level) if (ret) return ret; + t->hdr.poll_completion = poll; *(__le32 *)t->tx.buf = cpu_to_le32(domain); ret = scmi_do_xfer(handle, t); @@ -447,23 +449,24 @@ static int scmi_dvfs_get_transition_latency(const struct scmi_handle *handle, } static int scmi_dvfs_freq_set(const struct scmi_handle *handle, u32 domain, - unsigned long freq) + unsigned long freq, bool poll) { struct scmi_perf_info *pi = handle->perf_priv; struct perf_dom_info *dom = pi->dom_info + domain; - return scmi_perf_level_set(handle, domain, freq / dom->mult_factor); + return scmi_perf_level_set(handle, domain, freq / dom->mult_factor, + poll); } static int scmi_dvfs_freq_get(const struct scmi_handle *handle, u32 domain, - unsigned long *freq) + unsigned long *freq, bool poll) { int ret; u32 level; struct scmi_perf_info *pi = handle->perf_priv; struct perf_dom_info *dom = pi->dom_info + domain; - ret = scmi_perf_level_get(handle, domain, &level); + ret = scmi_perf_level_get(handle, domain, &level, poll); if (!ret) *freq = level * dom->mult_factor; diff --git a/include/linux/scmi_protocol.h b/include/linux/scmi_protocol.h index 70e2993f6d48..3b378af1badd 100644 --- a/include/linux/scmi_protocol.h +++ b/include/linux/scmi_protocol.h @@ -100,16 +100,16 @@ struct scmi_clk_ops { struct scmi_perf_ops { int (*limits_set)(const struct scmi_handle *, u32, u32, u32); int (*limits_get)(const struct scmi_handle *, u32, u32 *, u32 *); - int (*level_set)(const struct scmi_handle *, u32, u32); - int (*level_get)(const struct scmi_handle *, u32, u32 *); + int (*level_set)(const struct scmi_handle *, u32, u32, bool); + int (*level_get)(const struct scmi_handle *, u32, u32 *, bool); int (*limits_notify_enable)(const struct scmi_handle *, u32, bool); int (*level_notify_enable)(const struct scmi_handle *, u32, bool); int (*device_domain_id)(struct device *); int (*get_transition_latency)(const struct scmi_handle *, struct device *); int (*add_opps_to_device)(const struct scmi_handle *, struct device *); - int (*freq_set)(const struct scmi_handle *, u32, unsigned long); - int (*freq_get)(const struct scmi_handle *, u32, unsigned long *); + int (*freq_set)(const struct scmi_handle *, u32, unsigned long, bool); + int (*freq_get)(const struct scmi_handle *, u32, unsigned long *, bool); }; /**