From patchwork Thu Nov 29 21:29:25 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Loic Pallardy X-Patchwork-Id: 152462 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp2887969ljp; Thu, 29 Nov 2018 13:30:03 -0800 (PST) X-Google-Smtp-Source: AFSGD/VbVX6ar1mTsHDeZSNMFSHrGwxx0mT16X9DojQ2Wx/jCu73EYKzgDtcdlNBhCkEOPSj65rF X-Received: by 2002:a63:3858:: with SMTP id h24mr1379346pgn.300.1543527003027; Thu, 29 Nov 2018 13:30:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543527003; cv=none; d=google.com; s=arc-20160816; b=XimoJR0jdA4Z1jVSZVTUvEsZt5cx2BpuAhH0ytnz3iaCwiUw6+ZkkuGNp154kxHDSd II2qAZf2z/QCIYLL7h2t3w1R7/HA6KnBZspScRgmri26qy96y8WXbzWXwFn4s+suWPTl rKu9jg7DB5mJ7FGOYNsCv6h0AJ8J6p6hgVymdo048uZA9UF+htQseN9uLz3Faiy2O45W 2IA4Qgn1CSm0hFEE8UssT7jk/+mbNF5QHrPCYUHDQKKhPwp1xMUcUtiHIlqbqF3BvqvH ETChsW+qaZdbAv7Gfs4nFb/zmlWbZ1kkG1Eq3IzuTX+ojcIPy4Gm4BBaZwtBCDJagrmR u1Vg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from; bh=GGaW6BrYtmBj5C8b5QY/JDd6fBsE0NAWmji6ZLBYMvI=; b=S04uOdTtPd3WfG1VH0StLSSKIrWjNHBbfr/GJKWfOFwxjvPwYzqHaRsMFKlMFnjz90 YOIjtAgXEUxC8yem4WvMP2hgQNSc6jrCCGhEtP59ZOHnkjtlacgArQwkC4fLL+hd+PDW 6L0V9p8GlXlPHnrecY31iC8ecVRlPCFzTNbGZPmn5BKFGbL2+riB+QoJqjxkK3sAkA4n pbnb5b7shVdZiRiY7fHJJy84m0pOk2a1ZSBJn1W6SX6lfm7WdOr4kC64tSbRul+Wu8KQ Csqtu7wFnyqIX//WBcJKk0wlLarTkbfmnlQ/Sgcwd4q5tMMi4q/Q4ipG2Jpaq+nsnVii ujHw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c31si3001528pgc.465.2018.11.29.13.30.02; Thu, 29 Nov 2018 13:30:03 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727109AbeK3Igs (ORCPT + 32 others); Fri, 30 Nov 2018 03:36:48 -0500 Received: from mx08-00178001.pphosted.com ([91.207.212.93]:52626 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726932AbeK3Igs (ORCPT ); Fri, 30 Nov 2018 03:36:48 -0500 Received: from pps.filterd (m0046660.ppops.net [127.0.0.1]) by mx08-.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id wATLTvHu001812; Thu, 29 Nov 2018 22:29:57 +0100 Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx08-00178001.pphosted.com with ESMTP id 2nxvnb6gft-1 (version=TLSv1 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NOT); Thu, 29 Nov 2018 22:29:57 +0100 Received: from zeta.dmz-eu.st.com (zeta.dmz-eu.st.com [164.129.230.9]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 226D3468; Thu, 29 Nov 2018 22:29:27 +0000 (GMT) Received: from Webmail-eu.st.com (Safex1hubcas22.st.com [10.75.90.92]) by zeta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 5BDDE5981; Thu, 29 Nov 2018 21:29:56 +0000 (GMT) Received: from SAFEX1HUBCAS24.st.com (10.75.90.95) by Safex1hubcas22.st.com (10.75.90.92) with Microsoft SMTP Server (TLS) id 14.3.361.1; Thu, 29 Nov 2018 22:29:56 +0100 Received: from localhost (10.129.6.191) by webmail-ga.st.com (10.75.90.48) with Microsoft SMTP Server (TLS) id 14.3.361.1; Thu, 29 Nov 2018 22:29:55 +0100 From: Loic Pallardy To: , CC: , , , , , Loic Pallardy Subject: [PATCH 4/7] remoteproc: add warning on resource table cast Date: Thu, 29 Nov 2018 22:29:25 +0100 Message-ID: <1543526968-56091-5-git-send-email-loic.pallardy@st.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1543526968-56091-1-git-send-email-loic.pallardy@st.com> References: <1543526968-56091-1-git-send-email-loic.pallardy@st.com> MIME-Version: 1.0 X-Originating-IP: [10.129.6.191] X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2018-11-29_13:, , signatures=0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Today resource table supports only 32bit address fields. This is not compliant with 64bit platform for which addresses are cast in 32bit. This patch adds warn messages when address cast is done. Signed-off-by: Loic Pallardy --- drivers/remoteproc/remoteproc_core.c | 8 ++++++++ 1 file changed, 8 insertions(+) -- 2.7.4 diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c index 18a1bbf820c9..61c954bd695e 100644 --- a/drivers/remoteproc/remoteproc_core.c +++ b/drivers/remoteproc/remoteproc_core.c @@ -772,6 +772,10 @@ static int rproc_alloc_carveout(struct rproc *rproc, dev_dbg(dev, "carveout mapped 0x%x to %pad\n", mem->da, &dma); } else { + /* Update device address as undefined by requester */ + if (sizeof(dma_addr_t) > sizeof(u32)) + dev_warn(dev, "DMA address cast in 32bit to fit resource table format\n"); + mem->da = (u32)dma; } @@ -1150,6 +1154,10 @@ static int rproc_alloc_registered_carveouts(struct rproc *rproc) */ /* Use va if defined else dma to generate pa */ + if (sizeof(dma_addr_t) > sizeof(u32) || + sizeof(phys_addr_t) > sizeof(u32)) + dev_warn(dev, "Physical address cast in 32bit to fit resource table format\n"); + if (entry->va) rsc->pa = (u32)rproc_va_to_pa(entry->va); else