diff mbox series

[1/7] microblaze: fix cleaning of boot images

Message ID 1543823457-32478-2-git-send-email-yamada.masahiro@socionext.com
State New
Headers show
Series microblaze: fix various problems in building boot images | expand

Commit Message

Masahiro Yamada Dec. 3, 2018, 7:50 a.m. UTC
The simpleImage.<dt> target generates the following files:

  arch/microblaze/boot/simpleImage.<dt>
  arch/microblaze/boot/simpleImage.<dt>.ub
  arch/microblaze/boot/simpleImage.<dt>.strip
  arch/microblaze/boot/simpleImage.<dt>.unstrip

However, "make ARCH=microblaze clean" only cleans up the unstrip
image. Fix the clean-files to take care of all the four.

Adding linux.bin.ub to clean-files is redundant because it is
already added into "targets".

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>

---

 arch/microblaze/boot/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.7.4

Comments

Michal Simek Dec. 5, 2018, 3:41 p.m. UTC | #1
On 03. 12. 18 8:50, Masahiro Yamada wrote:
> The simpleImage.<dt> target generates the following files:

> 

>   arch/microblaze/boot/simpleImage.<dt>

>   arch/microblaze/boot/simpleImage.<dt>.ub

>   arch/microblaze/boot/simpleImage.<dt>.strip

>   arch/microblaze/boot/simpleImage.<dt>.unstrip

> 

> However, "make ARCH=microblaze clean" only cleans up the unstrip

> image. Fix the clean-files to take care of all the four.

> 

> Adding linux.bin.ub to clean-files is redundant because it is

> already added into "targets".

> 

> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>

> ---

> 

>  arch/microblaze/boot/Makefile | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)

> 

> diff --git a/arch/microblaze/boot/Makefile b/arch/microblaze/boot/Makefile

> index 600e5a1..e8684a2 100644

> --- a/arch/microblaze/boot/Makefile

> +++ b/arch/microblaze/boot/Makefile

> @@ -37,4 +37,4 @@ $(obj)/simpleImage.%: vmlinux FORCE

>  	$(call if_changed,strip,.strip)

>  	@echo 'Kernel: $(UIMAGE_OUT) is ready' ' (#'`cat .version`')'

>  

> -clean-files += simpleImage.*.unstrip linux.bin.ub

> +clean-files += simpleImage.*

> 


Reviewed-by: Michal Simek <michal.simek@xilinx.com>


Thanks,
Michal

-- 
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Xilinx Microblaze
Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs
U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP/Versal SoCs
diff mbox series

Patch

diff --git a/arch/microblaze/boot/Makefile b/arch/microblaze/boot/Makefile
index 600e5a1..e8684a2 100644
--- a/arch/microblaze/boot/Makefile
+++ b/arch/microblaze/boot/Makefile
@@ -37,4 +37,4 @@  $(obj)/simpleImage.%: vmlinux FORCE
 	$(call if_changed,strip,.strip)
 	@echo 'Kernel: $(UIMAGE_OUT) is ready' ' (#'`cat .version`')'
 
-clean-files += simpleImage.*.unstrip linux.bin.ub
+clean-files += simpleImage.*