| Message ID | 1550568787-18710-4-git-send-email-yamada.masahiro@socionext.com |
|---|---|
| State | Accepted |
| Commit | 8d2e52003adf45035bc6e94056c68dacf517236b |
| Headers | show |
| Series | [1/5] scripts/gdb: delay generation of gdb constants.py | expand |
Hi Yamada-san, On 19/02/2019 09:33, Masahiro Yamada wrote: > It is weird to create gdb stuff as a side-effect of vmlinux. > > Move it to a more relevant place. > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> > --- > > Makefile | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/Makefile b/Makefile > index a5762c6..0459260 100644 > --- a/Makefile > +++ b/Makefile > @@ -1015,9 +1015,6 @@ cmd_link-vmlinux = \ > $(if $(ARCH_POSTLINK), $(MAKE) -f $(ARCH_POSTLINK) $@, true) > > vmlinux: scripts/link-vmlinux.sh autoksyms_recursive $(vmlinux-deps) FORCE > -ifdef CONFIG_GDB_SCRIPTS > - $(Q)ln -fsn $(abspath $(srctree)/scripts/gdb/vmlinux-gdb.py) > -endif My initial thought was, doesn't this have a dependency on the vmlinux ... but of course it doesn't. It's not symlinking to the output binary - it's creating a helper link for GDB to know how to tie in the scripts-gdb package. It doesn't require vmlinux to exist at all. So yes, I agree this is fine. > +$(call if_changed,link-vmlinux) > > targets := vmlinux > @@ -1519,6 +1516,7 @@ $(DOC_TARGETS): scripts_basic FORCE > PHONY += scripts_gdb > scripts_gdb: prepare > $(Q)$(MAKE) $(build)=scripts/gdb > + $(Q)ln -fsn $(abspath $(srctree)/scripts/gdb/vmlinux-gdb.py) and especially as we now have this convenient location for it. This looks much better. Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > > ifdef CONFIG_GDB_SCRIPTS > all: scripts_gdb > -- Regards -- Kieran
diff --git a/Makefile b/Makefile index a5762c6..0459260 100644 --- a/Makefile +++ b/Makefile @@ -1015,9 +1015,6 @@ cmd_link-vmlinux = \ $(if $(ARCH_POSTLINK), $(MAKE) -f $(ARCH_POSTLINK) $@, true) vmlinux: scripts/link-vmlinux.sh autoksyms_recursive $(vmlinux-deps) FORCE -ifdef CONFIG_GDB_SCRIPTS - $(Q)ln -fsn $(abspath $(srctree)/scripts/gdb/vmlinux-gdb.py) -endif +$(call if_changed,link-vmlinux) targets := vmlinux @@ -1519,6 +1516,7 @@ $(DOC_TARGETS): scripts_basic FORCE PHONY += scripts_gdb scripts_gdb: prepare $(Q)$(MAKE) $(build)=scripts/gdb + $(Q)ln -fsn $(abspath $(srctree)/scripts/gdb/vmlinux-gdb.py) ifdef CONFIG_GDB_SCRIPTS all: scripts_gdb
It is weird to create gdb stuff as a side-effect of vmlinux. Move it to a more relevant place. Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> --- Makefile | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) -- 2.7.4