From patchwork Mon Aug 21 14:40:03 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Salil Mehta X-Patchwork-Id: 110548 Delivered-To: patch@linaro.org Received: by 10.140.95.78 with SMTP id h72csp1375199qge; Mon, 21 Aug 2017 07:40:40 -0700 (PDT) X-Received: by 10.98.33.212 with SMTP id o81mr17278632pfj.50.1503326440389; Mon, 21 Aug 2017 07:40:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1503326440; cv=none; d=google.com; s=arc-20160816; b=rXVLYxMuqtKVdVWzWMNVY1Ms/IOQanHSz2NPyHf1rIpxJU3VXtsRCxVrr/e3VJRsVI z5rqO5E14K6jX/iumI7LIUwQnNuhDHj4mkrA2jaB6aBQfY7Hr8ihcIfa6Z49Bl+Kwm8W dikE0uVJdpDclBedPgF+bXqQZkKSdGbjtNtLWzwuAWZgYXFfQC+QcN521P9uMZXn7vzS 54xSW2kbEfyKrrNuoo530jQ3shxFltIqiQYsYVK6HSuX7Lt90EfzUat659aBHgDvt5P1 +ipKLfYyHt9g71SrRTE51sgvKitACm3s/tI4RFb5S2R+H+afmVNcdeBReQxGMw83itWD 5PKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:subject:cc :to:from:arc-authentication-results; bh=VKuajg/gn9SeRtvLojrjzDnb0JpUNaarv92E0FwERAE=; b=MloC0XtODKYdtBfa3+EWxUhZz4ZPCA7LxpnY9ck68C5dy2quZhV7W0AxwIVe2YgReP sX5fUoXasdjSrIOjyJEQR9AyZXs6Crps+l1KIUPYFdgvYij2PF3WxuLjtll+rr7fJP9Y BPPeyaoS+TGzt1YErNYPq6REq3fqrkMmSAZGSEJ6cdq6W1Qxl1u8TQ3bz4pxlyMw+nsU Vp/lg1cfhREqx4G85M3VICKa4Pm2ORoe2K0tVWX/1FeOHRmNOeWJeonzjHP/dZ2TlXii pupN1uzJ2nYjRy6PX0KtfngrSkredMbcT6yCmb1dtAiWm1ZCF/FT4VhYEcsT/MkHVCV+ Sw/g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 187si254234pge.559.2017.08.21.07.40.39; Mon, 21 Aug 2017 07:40:40 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753909AbdHUOkg (ORCPT + 26 others); Mon, 21 Aug 2017 10:40:36 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:4087 "EHLO szxga05-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753206AbdHUOkf (ORCPT ); Mon, 21 Aug 2017 10:40:35 -0400 Received: from 172.30.72.60 (EHLO DGGEMS414-HUB.china.huawei.com) ([172.30.72.60]) by dggrg05-dlp.huawei.com (MOS 4.4.6-GA FastPath queued) with ESMTP id DFR18360; Mon, 21 Aug 2017 22:40:31 +0800 (CST) Received: from S00293818-DELL1.china.huawei.com (10.203.181.152) by DGGEMS414-HUB.china.huawei.com (10.3.19.214) with Microsoft SMTP Server id 14.3.301.0; Mon, 21 Aug 2017 22:40:23 +0800 From: Salil Mehta To: CC: , , , , , , , Subject: [PATCH V4 net-next] net: hns3: Add support to change MTU in HNS3 hardware Date: Mon, 21 Aug 2017 15:40:03 +0100 Message-ID: <20170821144003.49436-1-salil.mehta@huawei.com> X-Mailer: git-send-email 2.8.3 MIME-Version: 1.0 X-Originating-IP: [10.203.181.152] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A090202.599AF0DF.01CC, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0, ip=0.0.0.0, so=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: ba52189b98f89b430d3dc1f98da6cd36 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch adds the following support to the HNS3 driver: 1. Support to change the Maximum Transmission Unit of a port in the HNS NIC hardware. 2. Initializes the supported MTU range for the netdevice. Signed-off-by: lipeng Signed-off-by: Salil Mehta --- PATCH V4: Addressed some minor comments Leon Romanovsky 1. https://lkml.org/lkml/2017/8/21/212 PATCH V3: Addressed some minor comments Leon Romanovsky 1. https://lkml.org/lkml/2017/8/20/27 PATCH V2: Addresses comments given by Andrew Lunn 1. https://lkml.org/lkml/2017/8/18/282 PATCH V1: Initial Submit --- .../net/ethernet/hisilicon/hns3/hns3pf/hns3_enet.c | 34 ++++++++++++++++++++++ .../net/ethernet/hisilicon/hns3/hns3pf/hns3_enet.h | 1 + 2 files changed, 35 insertions(+) -- 2.7.4 Reviewed-by: Leon Romanovsky diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hns3_enet.c b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hns3_enet.c index e731f87..1c3e294 100644 --- a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hns3_enet.c +++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hns3_enet.c @@ -1278,11 +1278,42 @@ static int hns3_ndo_set_vf_vlan(struct net_device *netdev, int vf, u16 vlan, return ret; } +static int hns3_nic_change_mtu(struct net_device *netdev, int new_mtu) +{ + struct hns3_nic_priv *priv = netdev_priv(netdev); + struct hnae3_handle *h = priv->ae_handle; + bool if_running = netif_running(netdev); + int ret; + + if (!h->ae_algo->ops->set_mtu) + return -EOPNOTSUPP; + + /* if this was called with netdev up then bring netdevice down */ + if (if_running) { + (void)hns3_nic_net_stop(netdev); + msleep(100); + } + + ret = h->ae_algo->ops->set_mtu(h, new_mtu); + if (ret) { + netdev_err(netdev, "failed to change MTU in hardware %d\n", + ret); + return ret; + } + + /* if the netdev was running earlier, bring it up again */ + if (if_running && hns3_nic_net_open(netdev)) + ret = -EINVAL; + + return ret; +} + static const struct net_device_ops hns3_nic_netdev_ops = { .ndo_open = hns3_nic_net_open, .ndo_stop = hns3_nic_net_stop, .ndo_start_xmit = hns3_nic_net_xmit, .ndo_set_mac_address = hns3_nic_net_set_mac_address, + .ndo_change_mtu = hns3_nic_change_mtu, .ndo_set_features = hns3_nic_set_features, .ndo_get_stats64 = hns3_nic_get_stats64, .ndo_setup_tc = hns3_nic_setup_tc, @@ -2752,6 +2783,9 @@ static int hns3_client_init(struct hnae3_handle *handle) goto out_reg_netdev_fail; } + /* MTU range: (ETH_MIN_MTU(kernel default) - 9706) */ + netdev->max_mtu = HNS3_MAX_MTU - (ETH_HLEN + ETH_FCS_LEN + VLAN_HLEN); + return ret; out_reg_netdev_fail: diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hns3_enet.h b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hns3_enet.h index a6e8f15..7e87461 100644 --- a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hns3_enet.h +++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hns3_enet.h @@ -76,6 +76,7 @@ enum hns3_nic_state { #define HNS3_RING_NAME_LEN 16 #define HNS3_BUFFER_SIZE_2048 2048 #define HNS3_RING_MAX_PENDING 32768 +#define HNS3_MAX_MTU 9728 #define HNS3_BD_SIZE_512_TYPE 0 #define HNS3_BD_SIZE_1024_TYPE 1