From patchwork Tue Jun 26 01:34:05 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Elder X-Patchwork-Id: 139912 Delivered-To: patch@linaro.org Received: by 2002:a2e:970d:0:0:0:0:0 with SMTP id r13-v6csp4639705lji; Mon, 25 Jun 2018 18:35:15 -0700 (PDT) X-Google-Smtp-Source: ADUXVKI+9CP0UZZSJqiusv+SMVy00+Oz61VpaUIH84KQlmKeRrsUDfDfZiZVynuuXSBbouffhRh4 X-Received: by 2002:a17:902:24a5:: with SMTP id w34-v6mr14643796pla.52.1529976915116; Mon, 25 Jun 2018 18:35:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1529976915; cv=none; d=google.com; s=arc-20160816; b=FP31ORzOY96CGB7uXBjE7qMfyEELeDJNAhiWqdQjfpci0aZxxPjJQC32pDOWlgBAyu 4rJde1TcdyB3z1xAtXxnAUToqIPAr+Hof4an2H5ye7bWfpkk2Uv4trAq3lEzK3/SgFM4 pj8XDU75PAxp20y4XOmoC2I+7Ys1HZi2bLP643ErDx+s9S/hhh3i/xEeHXFRuu/lkFxv e2XqrvfdciUfr8Mv40TfEUMkPXFNHZ5QDmgolcYrQSmvrOnIYQvnn26vBZh62ULi2xLH gN3M1mU78G8wWOz1gbxEQ5hvek5coF+EuG3qM1Mlx56uT7t6hKlYMypyQghiKn7i71cn RZMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=At01+zlppAHzv2kYNufv49tmZevIJdLwkZ64Y6dFay8=; b=TnTVzQtbR7lFYNyeL002KrSLp791t5iJ8yH0JUcahXokANYFc9cZBAC2YhJNxYwUj+ 8ePG8ulXEkWW+PAsac2vtdX9+xNyOZhoTA2lGf0TLvdUyzfDtGI3TpJwgYEOYVsGKwQp kZG9mc/E3Z4oQJXxZgObhh6r7FJf64m3I0/A4R9lGdEHtB7js+WcEF0e/XWCQuTU5XqS ArkCnVGCUtl6TekQOXVy3vWrmt6iiFVKstjKIL4yrKQdMtYS71QEebuUqRQdnBlwfmVs WX59OVZiYBdRgeihAzzXkgdQW/ufQ/P8kz2qoxVZFmNbQEI4v9M+TDtkKPsaB7engUNM +8Xw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="j/LFOPtU"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b19-v6si360266pls.439.2018.06.25.18.35.14; Mon, 25 Jun 2018 18:35:15 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="j/LFOPtU"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935392AbeFZBfN (ORCPT + 31 others); Mon, 25 Jun 2018 21:35:13 -0400 Received: from mail-it0-f68.google.com ([209.85.214.68]:55539 "EHLO mail-it0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935055AbeFZBeO (ORCPT ); Mon, 25 Jun 2018 21:34:14 -0400 Received: by mail-it0-f68.google.com with SMTP id 16-v6so15278095itl.5 for ; Mon, 25 Jun 2018 18:34:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=At01+zlppAHzv2kYNufv49tmZevIJdLwkZ64Y6dFay8=; b=j/LFOPtU8DO+umrMStbSSiJJyGGkMv8gTUlqLY2mq5CUHX9yfxJ4FrOvlZ0fJFrrHZ cym8K1fkEXi0kho12D0kxRm0+ULifCwOPBDBP0HJ+J0WUy6SdjCF4bVgxZ/iqbm2zG9b x22qod9rdXQqvhEMWcJ0PLT0Nb0qOxGp3LSIk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=At01+zlppAHzv2kYNufv49tmZevIJdLwkZ64Y6dFay8=; b=ffqnEgDYXko405qfWZy3w5OWN4Xydz7m2INoLjc9yhgDL1+PFFRHWX7u98bOs9+Lhj 7apvqlIr+xqoW/VgpsF54+PBZmD4/9lPwTvjvfr42NKzmtNVKnNZLKm1LQdiFahnOq4Q zsBEJ9nbNB9LJvrUOPQwSHguU7Yk4CiRVUrIpL3vdwh85pYGxyTxN1+IusZcm3VuViRv ziZFTVuJJJA5FpJrKiVWxELJPGIFSyMwd+PSlUV7wi7CWzyjOuGAuT0PNDxI+lKHt8HW cobGUwfZJhfp/0JewSSjE10tcAcTkpDHCyzrEBhsCM8gPoOP1skwELQOPfH/Xqgs032p GVjQ== X-Gm-Message-State: APt69E2Q9Wwy4Cqonbqo+dda0b8bf0LeLJWdvq3Odcu+zfzaY1dxE4EQ 2Hhd4DDC41tHWZGn+/M0s+qupA== X-Received: by 2002:a02:105:: with SMTP id c5-v6mr3912816jad.139.1529976853301; Mon, 25 Jun 2018 18:34:13 -0700 (PDT) Received: from localhost.localdomain (c-71-195-29-92.hsd1.mn.comcast.net. [71.195.29.92]) by smtp.gmail.com with ESMTPSA id h62-v6sm184699ioa.22.2018.06.25.18.34.12 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 25 Jun 2018 18:34:12 -0700 (PDT) From: Alex Elder To: ohad@wizery.com, bjorn.andersson@linaro.org Cc: linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH resend 1/5] remoteproc: Rename subdev functions to start/stop Date: Mon, 25 Jun 2018 20:34:05 -0500 Message-Id: <20180626013409.5125-2-elder@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180626013409.5125-1-elder@linaro.org> References: <20180626013409.5125-1-elder@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Bjorn Andersson "start" and "stop" are more suitable names for how these two operations are used, and they fit better with the upcoming introduction of two additional operations in the struct. [elder@linaro.org: minor comment edits] Signed-off-by: Bjorn Andersson Acked-by: Alex Elder Tested-by: Fabien Dessenne --- drivers/remoteproc/remoteproc_core.c | 30 ++++++++++++++-------------- include/linux/remoteproc.h | 14 ++++++------- 2 files changed, 22 insertions(+), 22 deletions(-) -- 2.17.1 Tested-by: Fabien Dessenne Signed-off-by: Bjorn Andersson Signed-off-by: Alex Elder diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c index a9609d971f7f..5dd58e6bea88 100644 --- a/drivers/remoteproc/remoteproc_core.c +++ b/drivers/remoteproc/remoteproc_core.c @@ -774,13 +774,13 @@ static int rproc_handle_resources(struct rproc *rproc, return ret; } -static int rproc_probe_subdevices(struct rproc *rproc) +static int rproc_start_subdevices(struct rproc *rproc) { struct rproc_subdev *subdev; int ret; list_for_each_entry(subdev, &rproc->subdevs, node) { - ret = subdev->probe(subdev); + ret = subdev->start(subdev); if (ret) goto unroll_registration; } @@ -789,17 +789,17 @@ static int rproc_probe_subdevices(struct rproc *rproc) unroll_registration: list_for_each_entry_continue_reverse(subdev, &rproc->subdevs, node) - subdev->remove(subdev, true); + subdev->stop(subdev, true); return ret; } -static void rproc_remove_subdevices(struct rproc *rproc, bool crashed) +static void rproc_stop_subdevices(struct rproc *rproc, bool crashed) { struct rproc_subdev *subdev; list_for_each_entry_reverse(subdev, &rproc->subdevs, node) - subdev->remove(subdev, crashed); + subdev->stop(subdev, crashed); } /** @@ -901,8 +901,8 @@ static int rproc_start(struct rproc *rproc, const struct firmware *fw) return ret; } - /* probe any subdevices for the remote processor */ - ret = rproc_probe_subdevices(rproc); + /* Start any subdevices for the remote processor */ + ret = rproc_start_subdevices(rproc); if (ret) { dev_err(dev, "failed to probe subdevices for %s: %d\n", rproc->name, ret); @@ -1014,8 +1014,8 @@ static int rproc_stop(struct rproc *rproc, bool crashed) struct device *dev = &rproc->dev; int ret; - /* remove any subdevices for the remote processor */ - rproc_remove_subdevices(rproc, crashed); + /* Stop any subdevices for the remote processor */ + rproc_stop_subdevices(rproc, crashed); /* the installed resource table is no longer accessible */ rproc->table_ptr = rproc->cached_table; @@ -1657,16 +1657,16 @@ EXPORT_SYMBOL(rproc_del); * rproc_add_subdev() - add a subdevice to a remoteproc * @rproc: rproc handle to add the subdevice to * @subdev: subdev handle to register - * @probe: function to call when the rproc boots - * @remove: function to call when the rproc shuts down + * @start: function to call after the rproc is started + * @stop: function to call before the rproc is stopped */ void rproc_add_subdev(struct rproc *rproc, struct rproc_subdev *subdev, - int (*probe)(struct rproc_subdev *subdev), - void (*remove)(struct rproc_subdev *subdev, bool crashed)) + int (*start)(struct rproc_subdev *subdev), + void (*stop)(struct rproc_subdev *subdev, bool crashed)) { - subdev->probe = probe; - subdev->remove = remove; + subdev->start = start; + subdev->stop = stop; list_add_tail(&subdev->node, &rproc->subdevs); } diff --git a/include/linux/remoteproc.h b/include/linux/remoteproc.h index dfdaede9139e..bf55bf2a5ee1 100644 --- a/include/linux/remoteproc.h +++ b/include/linux/remoteproc.h @@ -477,15 +477,15 @@ struct rproc { /** * struct rproc_subdev - subdevice tied to a remoteproc * @node: list node related to the rproc subdevs list - * @probe: probe function, called as the rproc is started - * @remove: remove function, called as the rproc is being stopped, the @crashed - * parameter indicates if this originates from the a recovery + * @start: start function, called after the rproc has been started + * @stop: stop function, called before the rproc is stopped; the @crashed + * parameter indicates if this originates from a recovery */ struct rproc_subdev { struct list_head node; - int (*probe)(struct rproc_subdev *subdev); - void (*remove)(struct rproc_subdev *subdev, bool crashed); + int (*start)(struct rproc_subdev *subdev); + void (*stop)(struct rproc_subdev *subdev, bool crashed); }; /* we currently support only two vrings per rvdev */ @@ -568,8 +568,8 @@ static inline struct rproc *vdev_to_rproc(struct virtio_device *vdev) void rproc_add_subdev(struct rproc *rproc, struct rproc_subdev *subdev, - int (*probe)(struct rproc_subdev *subdev), - void (*remove)(struct rproc_subdev *subdev, bool crashed)); + int (*start)(struct rproc_subdev *subdev), + void (*stop)(struct rproc_subdev *subdev, bool crashed)); void rproc_remove_subdev(struct rproc *rproc, struct rproc_subdev *subdev);