From patchwork Fri Feb 15 00:44:58 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Arnaldo Carvalho de Melo X-Patchwork-Id: 158454 Delivered-To: patch@linaro.org Received: by 2002:a02:48:0:0:0:0:0 with SMTP id 69csp102487jaa; Thu, 14 Feb 2019 16:46:10 -0800 (PST) X-Google-Smtp-Source: AHgI3IaKpBWSdpan6E00N06gCaH/iu8EJq4L4BgWOpWr5GaTg5AGj+BoQKwzRZtLLlRJJKWKefJC X-Received: by 2002:a17:902:c05:: with SMTP id 5mr7226836pls.155.1550191570222; Thu, 14 Feb 2019 16:46:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1550191570; cv=none; d=google.com; s=arc-20160816; b=DlJPzEhwgcKJwP/KRGlmmex0ICG9OptVkacX+tYkgw9/SeTXXqj47+eIRF0Kh0gQV7 q/e3yx6+dpHoiVdktF5bbRfUgATEGMbYSwt9kMjxHLG+4Zsysw6Y25j+BK3/DdzmQuxg rAfNgiQFR0VmXIYpoaZiyvX8OKWicVcnNajZcI6pCaJ8IgaMkIkiF8+/USayEiXVS6UI a2Bm//tXWOObHWGmLHFAcdBE3u99VKH20QzO5o0rrIiSWbK2BkPnjJJMP0CfZIHzVhm+ 9Rfxl5tpNr8DOdPslhqzV8/wN1s9z/SuCBD4j2LO95x5NxU9/MYCrcRkFHrCS3Gzoh4J 8v2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Y7ySSCCo1u9XQWYjbds3sZ9THJRtkR7dmbueltsXLA4=; b=OIymgiJfPM0VUBtxMR4vDq41CcAERvC1ZVwZiGrXbeRYxQGyflUPvKZIaBl0gV6/fi fUDfEeY76ToyvHCUWy4yXp6nymFLR9MNQCohWv8TyrZD3x+TtnppDLOjZUgmpwDyBJIa n/mXgoJ+hpxhTmhydKxNYCR8f1Z0qr4hG82VgHIqtWUJ3GuQ8f36Kkd+IQlVzO3pZ9y9 /uQs8yRV2JJwyF7CiBEonUgNr7k4C5iY2/NosnqhmCqdjYML6wbJvl/3VdS8ZIqWU1xs 96I6dycOLe2fHn/mPwa3kCcO1htPuySVOfiZHj+CcxHpeRqbnLw2sPFvZ8LlhsVjewje 7TCg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="d3VbzEm/"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s12si3765571pgm.586.2019.02.14.16.46.09; Thu, 14 Feb 2019 16:46:10 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="d3VbzEm/"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730335AbfBOAqD (ORCPT + 31 others); Thu, 14 Feb 2019 19:46:03 -0500 Received: from mail.kernel.org ([198.145.29.99]:44052 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730296AbfBOAp7 (ORCPT ); Thu, 14 Feb 2019 19:45:59 -0500 Received: from quaco.ghostprotocols.net (unknown [189.40.103.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7DB8B21B68; Fri, 15 Feb 2019 00:45:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1550191559; bh=sAIxCpdE/fBclKe7EWnnZg+XMA9lo5WpgqS/a7OlR64=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=d3VbzEm/tcLeMndtEOzHImtxIngHZIrxnNcVL0ePWBE27wTZnYELfoB/0jNGkMxnG v57O53PjE2I1m9EE7NMwOzLxCO1yz/E0Z+JM06lytqmJXyR5JHovIJsQSbbnEHARfo UFSpt2SG7f1hr0OZ4LGv0cW3WzO2HRAR3ieRpl3o= From: Arnaldo Carvalho de Melo To: Ingo Molnar Cc: Jiri Olsa , Namhyung Kim , Clark Williams , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Mathieu Poirier , Jiri Olsa , Peter Zijlstra , Suzuki K Poulouse , linux-arm-kernel@lists.infradead.org, Arnaldo Carvalho de Melo Subject: [PATCH 02/43] perf cs-etm: Add proper header file for symbols Date: Thu, 14 Feb 2019 21:44:58 -0300 Message-Id: <20190215004539.23571-3-acme@kernel.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190215004539.23571-1-acme@kernel.org> References: <20190215004539.23571-1-acme@kernel.org> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Mathieu Poirier After 'commit e22c1c751140 ("perf thread: Don't include symbol.h, symbol_conf.h is enough")' Compilation of the perf tools is broken when using the functionality provided by the openCSD library: [...] ... timerfd: [ on ] ... sched_getcpu: [ on ] ... sdt: [ OFF ] ... setns: [ on ] ... libopencsd: [ on ] [...] CC util/arm-spe.o CC util/arm-spe-pkt-decoder.o CC util/s390-cpumsf.o CC util/cs-etm.o CC util/parse-branch-options.o util/cs-etm.c: In function ‘cs_etm__mem_access’: util/cs-etm.c:297:24: error: storage size of ‘al’ isn’t known struct addr_location al; And rightly so since file cs-etm.c doesn't include symbol.h, something that is rectified in this patch. Signed-off-by: Mathieu Poirier Cc: Jiri Olsa Cc: Peter Zijlstra Cc: Suzuki K Poulouse Cc: linux-arm-kernel@lists.infradead.org Link: http://lkml.kernel.org/r/20190208223543.31836-1-mathieu.poirier@linaro.org Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/util/cs-etm.c | 1 + 1 file changed, 1 insertion(+) -- 2.19.1 diff --git a/tools/perf/util/cs-etm.c b/tools/perf/util/cs-etm.c index 8b3f882d6e2f..0b11d653cfbe 100644 --- a/tools/perf/util/cs-etm.c +++ b/tools/perf/util/cs-etm.c @@ -25,6 +25,7 @@ #include "machine.h" #include "map.h" #include "perf.h" +#include "symbol.h" #include "thread.h" #include "thread_map.h" #include "thread-stack.h"