| Message ID | 20191101061411.16988-2-yamada.masahiro@socionext.com |
|---|---|
| State | New |
| Headers | show |
| Series | libfdt: prepare for (U)INT32_MAX addition | expand |
On Fri, Nov 1, 2019 at 1:19 AM Masahiro Yamada <yamada.masahiro@socionext.com> wrote: > > These are kernel source code even though they are just two-line wrappers. > > Files without explicit license information fall back to GPL-2.0-only, > which is the project default. That is true and these are kernel only files, but given they are just a wrapper around the .c files, maybe they should have the same license? Rob
Hi Rob, (+CC: David Daney) On Mon, Nov 4, 2019 at 11:00 PM Rob Herring <robh+dt@kernel.org> wrote: > > On Fri, Nov 1, 2019 at 1:19 AM Masahiro Yamada > <yamada.masahiro@socionext.com> wrote: > > > > These are kernel source code even though they are just two-line wrappers. > > > > Files without explicit license information fall back to GPL-2.0-only, > > which is the project default. > > That is true and these are kernel only files, but given they are just > a wrapper around the .c files, maybe they should have the same > license? I just thought it at first but this wraps two files, with different license. include/linux/libfdt_env.h: GPLv2 only scripts/dtc/libfdt/fdt*.c : GPLv2+ or BSD-2-Clause Looking at the include/linux/libfdt_env.h, I thought GPLv2 only would be preferred for the kernel-specific code. If you prefer to align with scripts/dtc/libfdt/fdt*.c I can change it, but I would also respect the opinion from David Daney, the author of the following commit: commit ab25383983fb8d7786696f5371e75e79c3e9a405 Author: David Daney <david.daney@cavium.com> Date: Thu Jul 5 18:12:38 2012 +0200 of/lib: Allow scripts/dtc/libfdt to be used from kernel code -- Best Regards Masahiro Yamada
diff --git a/lib/fdt.c b/lib/fdt.c index 97f20069fc37..041f8922a23c 100644 --- a/lib/fdt.c +++ b/lib/fdt.c @@ -1,2 +1,3 @@ +// SPDX-License-Identifier: GPL-2.0-only #include <linux/libfdt_env.h> #include "../scripts/dtc/libfdt/fdt.c" diff --git a/lib/fdt_empty_tree.c b/lib/fdt_empty_tree.c index 5d30c58150ad..452221227bf3 100644 --- a/lib/fdt_empty_tree.c +++ b/lib/fdt_empty_tree.c @@ -1,2 +1,3 @@ +// SPDX-License-Identifier: GPL-2.0-only #include <linux/libfdt_env.h> #include "../scripts/dtc/libfdt/fdt_empty_tree.c" diff --git a/lib/fdt_ro.c b/lib/fdt_ro.c index f73c04ea7be4..9f696d19f060 100644 --- a/lib/fdt_ro.c +++ b/lib/fdt_ro.c @@ -1,2 +1,3 @@ +// SPDX-License-Identifier: GPL-2.0-only #include <linux/libfdt_env.h> #include "../scripts/dtc/libfdt/fdt_ro.c" diff --git a/lib/fdt_rw.c b/lib/fdt_rw.c index 0c1f0f4a4b13..2a61e9c6dd44 100644 --- a/lib/fdt_rw.c +++ b/lib/fdt_rw.c @@ -1,2 +1,3 @@ +// SPDX-License-Identifier: GPL-2.0-only #include <linux/libfdt_env.h> #include "../scripts/dtc/libfdt/fdt_rw.c" diff --git a/lib/fdt_strerror.c b/lib/fdt_strerror.c index 8713e3ff4707..4554e5fdac12 100644 --- a/lib/fdt_strerror.c +++ b/lib/fdt_strerror.c @@ -1,2 +1,3 @@ +// SPDX-License-Identifier: GPL-2.0-only #include <linux/libfdt_env.h> #include "../scripts/dtc/libfdt/fdt_strerror.c" diff --git a/lib/fdt_sw.c b/lib/fdt_sw.c index 9ac7e50c76ce..d3345ca399cf 100644 --- a/lib/fdt_sw.c +++ b/lib/fdt_sw.c @@ -1,2 +1,3 @@ +// SPDX-License-Identifier: GPL-2.0-only #include <linux/libfdt_env.h> #include "../scripts/dtc/libfdt/fdt_sw.c" diff --git a/lib/fdt_wip.c b/lib/fdt_wip.c index 45b3fc3d3ba1..9674d4c3b115 100644 --- a/lib/fdt_wip.c +++ b/lib/fdt_wip.c @@ -1,2 +1,3 @@ +// SPDX-License-Identifier: GPL-2.0-only #include <linux/libfdt_env.h> #include "../scripts/dtc/libfdt/fdt_wip.c"
These are kernel source code even though they are just two-line wrappers. Files without explicit license information fall back to GPL-2.0-only, which is the project default. Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> --- lib/fdt.c | 1 + lib/fdt_empty_tree.c | 1 + lib/fdt_ro.c | 1 + lib/fdt_rw.c | 1 + lib/fdt_strerror.c | 1 + lib/fdt_sw.c | 1 + lib/fdt_wip.c | 1 + 7 files changed, 7 insertions(+) -- 2.17.1