From patchwork Mon Mar 30 20:27:15 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Stultz X-Patchwork-Id: 185067 Delivered-To: patches@linaro.org Received: by 2002:a92:de47:0:0:0:0:0 with SMTP id e7csp2923635ilr; Mon, 30 Mar 2020 13:27:20 -0700 (PDT) X-Received: by 2002:a63:4641:: with SMTP id v1mr14063078pgk.156.1585600040745; Mon, 30 Mar 2020 13:27:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1585600040; cv=none; d=google.com; s=arc-20160816; b=K+BHLgP+WbsJ5wA88Z48VhnzY5d0o6yDa8Cs1ahc0QgDrS/J23Qbvwkw0DHOpEGVvs rukrIfBEs1RyjXNSCoYpZQSASmeysV9eVI/yxakzF6rDAgXJeeWj+BMhVCpn1ImL2ogw IjSgLdd69Zvvpx91j2viHcpJfEtx4oW/ukDO2gPA4GNmHTfHLaayFQO6jcLz+t5aROz2 GVYN93acLFJvAlfQ7N/W/C6afgdVyt+/6oQ7koznXpXY3hI3psiThl8F3fcBDEBpJxkM IxDNMjw3HhqFTyovNSU/ZAjVtDnsIy2c0nyOohyTwA40KuJJPrkwrxLnu3MoUsTPU0N7 s+zA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=message-id:date:subject:cc:to:from:dkim-signature; bh=5kwrCgZfkDCR5kojZgtUr75C5RmgBcKGuDCcFWeq9ps=; b=gRxmJkW8aloz6Jf8ytMH3cwc3JEwFYh2Vu8RJ1IO8seBdhJf2Ww8u0knasZgfUxryq XBzFegCxTVwt/LqgB5+XoUGqu60GDYQiAU3u/K7vsreGeIaKZGNU//4SoISPkduYQvOL z8M3bjAWpBPJRoqqbEYUYmOX4Y+XG5ef1ouT6C3pP2PzPP9SEmFbX93P+To8qa7qtxPf 9VHCvkquKUfbZjoxToKraUCWsXq53eGcuBfIGSQie1F3J9WXzXqalZfmdIPTZXAxkxu7 KrAD0VunMMNMBIXYyzVyj3BpsmILxZX0VEchHmPZpbkvLhREofOaCO7uN77cXvfW9HLQ rNfA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=y1cFkXMZ; spf=pass (google.com: domain of john.stultz@linaro.org designates 209.85.220.65 as permitted sender) smtp.mailfrom=john.stultz@linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id e4sor19802072pgg.50.2020.03.30.13.27.20 for (Google Transport Security); Mon, 30 Mar 2020 13:27:20 -0700 (PDT) Received-SPF: pass (google.com: domain of john.stultz@linaro.org designates 209.85.220.65 as permitted sender) client-ip=209.85.220.65; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=y1cFkXMZ; spf=pass (google.com: domain of john.stultz@linaro.org designates 209.85.220.65 as permitted sender) smtp.mailfrom=john.stultz@linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=5kwrCgZfkDCR5kojZgtUr75C5RmgBcKGuDCcFWeq9ps=; b=y1cFkXMZFV9ho+nVsFjYO29N0pTcxmjmPUUqukKfRxUi/J0XQctotRFc1U7AQA2/yR HBrf7EQl11HCCdXZHhPdsmLywrPkSHJeEZ2s4e88nJPhMv1k0brSEf1EfT98PVM8601n R6AfAy3XI3NsRin+/KsBqrTAHPf7bmRjiJT3EXtcdnJaWHdTTgaHdszUc9FRNAR/33R/ T/gtLlotKPspu5/tJKXz9aRQ3iuKTW7H7hWTg4y66YRaVVTzlydeyW6oskphnpZPYhBt 7RFag9tDIAE6hIeh5eVVFJRZovqjOmQJmg8LKtotMoLdAfQk4QGIZ9gHqy0bNwxnXdT3 GF7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=5kwrCgZfkDCR5kojZgtUr75C5RmgBcKGuDCcFWeq9ps=; b=c6f8ymy/uCb+NxWZBYc499IhTfvunE6AKo7SqjhWh81bL7mkO/OmfVgRhmG/LMbZU7 8prhodNik9Jzz/1Iiq5K7QOuSNisTTp4ms4gsJldzYorFk7Tyv91C2/QcmkZX454lp+p GY9tU0RwMStvjUroeXacdR5jgUthf1Dvp1CnNiKRHHVQs+Eu1Aeoqxd0P+DyUZ6QUJAh r+LfluxLLdceawszDveixYPYcCmelwZ0P3ronxpy6Qwb/n4Sn1lNQ3a8+gcuzDAgUIa6 tMLN9CloybqbEgNu+cKPsdPjFJJ8dE2RQr5OC9V2CsOCwGRiGtKiQE6h4iuEUdRIVKU2 zcMw== X-Gm-Message-State: ANhLgQ2qbS55cxTqtgrYdVXjpl6W5na5xFxycMEFpN0WHpZr0GvD6arJ xEKOMS+myHmqx913tc8ruMysvvrb X-Google-Smtp-Source: ADFU+vsrs02AnlgYDEXJGGhQIIEcONZIZpe5Yv9E5HIIBsANslv46K41gLCQJYv1pi9dy5y8wl/jZw== X-Received: by 2002:a63:a069:: with SMTP id u41mr14237169pgn.3.1585600040315; Mon, 30 Mar 2020 13:27:20 -0700 (PDT) Return-Path: Received: from localhost.localdomain ([2601:1c2:680:1319:692:26ff:feda:3a81]) by smtp.gmail.com with ESMTPSA id y22sm10853628pfr.68.2020.03.30.13.27.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Mar 2020 13:27:19 -0700 (PDT) From: John Stultz To: lkml Cc: John Stultz , Robin Murphy , Andy Shevchenko , Sudeep Holla , Andy Shevchenko , Naresh Kamboju , "Rafael J. Wysocki" , Greg Kroah-Hartman , Basil Eljuse , Ferry Toth , Arnd Bergmann , Anders Roxell Subject: [PATCH] driver core: Use dev_warn() instead of dev_WARN() for deferred_probe_timeout warnings Date: Mon, 30 Mar 2020 20:27:15 +0000 Message-Id: <20200330202715.86609-1-john.stultz@linaro.org> X-Mailer: git-send-email 2.17.1 In commit c8c43cee29f6 ("driver core: Fix driver_deferred_probe_check_state() logic") and following changes the logic was changes slightly so that if there is no driver to match whats found in the dtb, we wait 30 seconds for modules to be loaded by userland, and then timeout, where as previously we'd print "ignoring dependency for device, assuming no driver" and immediately return -ENODEV after initcall_done. However, in the timeout case (which previously existed but was practicaly un-used without a boot argument), the timeout message uses dev_WARN(). This means folks are now seeing a big backtrace in their boot logs if there a entry in their dts that doesn't have a driver. To fix this, lets use dev_warn(), instead of dev_WARN() to match the previous error path. Cc: Robin Murphy Cc: Andy Shevchenko Cc: Sudeep Holla Cc: Andy Shevchenko Cc: Naresh Kamboju Cc: "Rafael J. Wysocki" Cc: Greg Kroah-Hartman Cc: Basil Eljuse Cc: Ferry Toth Cc: Arnd Bergmann Cc: Anders Roxell Fixes: c8c43cee29f6 ("driver core: Fix driver_deferred_probe_check_state() logic") Signed-off-by: John Stultz --- drivers/base/dd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.17.1 diff --git a/drivers/base/dd.c b/drivers/base/dd.c index 06ec0e851fa1..ca1652221c1a 100644 --- a/drivers/base/dd.c +++ b/drivers/base/dd.c @@ -267,7 +267,7 @@ int driver_deferred_probe_check_state(struct device *dev) } if (!driver_deferred_probe_timeout) { - dev_WARN(dev, "deferred probe timeout, ignoring dependency"); + dev_warn(dev, "deferred probe timeout, ignoring dependency"); return -ETIMEDOUT; }