From patchwork Wed Aug 2 18:00:06 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Github ODP bot X-Patchwork-Id: 109274 Delivered-To: patch@linaro.org Received: by 10.140.101.6 with SMTP id t6csp3084473qge; Wed, 2 Aug 2017 11:00:45 -0700 (PDT) X-Received: by 10.55.160.15 with SMTP id j15mr32997821qke.324.1501696845839; Wed, 02 Aug 2017 11:00:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1501696845; cv=none; d=google.com; s=arc-20160816; b=IQpw4WShHPurpm/AKkxcdCwwzkLKff+H8pGvGWoU97MsLR57v/imOJj98PIMeMHUY2 NsKcGUznub1KL9KAO0fuNdNPi/Ua2KXYlcI/A0oIdGURxs/UAhfGMzTddTVsdzQBl0Cr NzX+WM3U4EEwhRSI2JDC1KFwnjbYPCh8G2uYGGliy4jyGCu9Ii8pcu7qeZ3+IjdrZVNG cVx9AJqiGwsG+2JWBjNouZWpiizDFockS5lciTSZKKEUurObW6kdJTdiR3bcQaJk3H1J VOjniZE3IqgGB/mGPYiHCXHGz3E9XeHzPLDfMPIDTtdjou/kZvhxW9/IWw08Z+qvl3YL S2dQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:github-pr-num :references:in-reply-to:message-id:date:to:from:delivered-to :arc-authentication-results; bh=tdgMsK6jBQMwAsz3SvnDl5jjIqqsoaw9G6fkVvqBY1A=; b=AumLwxDHBlBWh7R8aqQgLKYK1edouhVzQxl6kHUUC6Eq7Nbdy7bzBm9lYFPCo1a6WC i7Mf+Qvq/uI8tE/GMbhUxZBARvkbIof/TWLWdV3wUp/In4kUf32tzV9BrMOU9D86upmz ClLTY6GiFnLKesj9kEMGupdYP/DunE8n78DmAACwh//C6mEObIiMNx+bjTguQ3RT0Pvj W7EQd5UHKgsDpW9hJmWhZSusheeC+MG6/7x1ryThfODJKFWciM07xflVW1TeCQJ2j0D1 dB4Ol/kR5zds+R/MSL1l9jR0p/ks8Rrx+zyzFHajDHl/P1C7WRoCNsaSGOJH6+MTWa3G SvYg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=yandex.ru Return-Path: Received: from lists.linaro.org (lists.linaro.org. [54.225.227.206]) by mx.google.com with ESMTP id k77si24773270qke.89.2017.08.02.11.00.45; Wed, 02 Aug 2017 11:00:45 -0700 (PDT) Received-SPF: pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) client-ip=54.225.227.206; Authentication-Results: mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=yandex.ru Received: by lists.linaro.org (Postfix, from userid 109) id 7A8FA6064C; Wed, 2 Aug 2017 18:00:45 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ip-10-142-244-252 X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_LOW,URIBL_BLOCKED autolearn=disabled version=3.4.0 Received: from [127.0.0.1] (localhost [127.0.0.1]) by lists.linaro.org (Postfix) with ESMTP id 0BF766097D; Wed, 2 Aug 2017 18:00:18 +0000 (UTC) X-Original-To: lng-odp@lists.linaro.org Delivered-To: lng-odp@lists.linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id 5E07160856; Wed, 2 Aug 2017 18:00:15 +0000 (UTC) Received: from forward2p.cmail.yandex.net (forward2p.cmail.yandex.net [77.88.31.17]) by lists.linaro.org (Postfix) with ESMTPS id 3EFB860856 for ; Wed, 2 Aug 2017 18:00:14 +0000 (UTC) Received: from smtp4j.mail.yandex.net (smtp4j.mail.yandex.net [IPv6:2a02:6b8:0:1619::15:6]) by forward2p.cmail.yandex.net (Yandex) with ESMTP id E1431211A1 for ; Wed, 2 Aug 2017 21:00:11 +0300 (MSK) Received: from smtp4j.mail.yandex.net (localhost.localdomain [127.0.0.1]) by smtp4j.mail.yandex.net (Yandex) with ESMTP id B8ACD32410C5 for ; Wed, 2 Aug 2017 21:00:11 +0300 (MSK) Received: by smtp4j.mail.yandex.net (nwsmtp/Yandex) with ESMTPSA id TJbn3dfkc6-0AgqP5ZP; Wed, 02 Aug 2017 21:00:10 +0300 (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (Client certificate not present) X-Yandex-Suid-Status: 1 0 From: Github ODP bot To: lng-odp@lists.linaro.org Date: Wed, 2 Aug 2017 21:00:06 +0300 Message-Id: <1501696806-12054-2-git-send-email-odpbot@yandex.ru> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1501696806-12054-1-git-send-email-odpbot@yandex.ru> References: <1501696806-12054-1-git-send-email-odpbot@yandex.ru> Github-pr-num: 105 Subject: [lng-odp] [PATCH v2 1/1] api: packetio: deprecate redundant loop_supported field in capability X-BeenThere: lng-odp@lists.linaro.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: "The OpenDataPlane \(ODP\) List" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: lng-odp-bounces@lists.linaro.org Sender: "lng-odp" From: Balasubramanian Manoharan removes redundant loop_supported boolean in odp_pktio_capability_t Fixes https://bugs.linaro.org/show_bug.cgi?id=2861 Signed-off-by: Balasubramanian Manoharan --- /** Email created from pull request 105 (bala-manoharan:BUG2861) ** https://github.com/Linaro/odp/pull/105 ** Patch: https://github.com/Linaro/odp/pull/105.patch ** Base sha: a2040db93b114fb9e1da9aeca1d0a1ea91699448 ** Merge commit sha: 42188b7d28e6ec7d2fc696f14b40e024ff08d639 **/ include/odp/api/spec/packet_io.h | 8 +++----- platform/linux-generic/odp_packet_io.c | 2 +- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/include/odp/api/spec/packet_io.h b/include/odp/api/spec/packet_io.h index cec1f22a..76c63e72 100644 --- a/include/odp/api/spec/packet_io.h +++ b/include/odp/api/spec/packet_io.h @@ -19,6 +19,7 @@ extern "C" { #endif +#include #include #include #include @@ -445,11 +446,8 @@ typedef struct odp_pktio_capability_t { * set to zero. */ odp_pktio_set_op_t set_op; - /** Support of Loopback mode - * - * A boolean to denote whether loop back mode is supported on this - * specific interface. */ - odp_bool_t loop_supported; + /** @deprecated Use enable_loop inside odp_pktin_config_t */ + odp_bool_t ODP_DEPRECATE(loop_supported); } odp_pktio_capability_t; /** diff --git a/platform/linux-generic/odp_packet_io.c b/platform/linux-generic/odp_packet_io.c index 64c6e452..94075567 100644 --- a/platform/linux-generic/odp_packet_io.c +++ b/platform/linux-generic/odp_packet_io.c @@ -416,7 +416,7 @@ int odp_pktio_config(odp_pktio_t hdl, const odp_pktio_config_t *config) return -1; } - if (config->enable_loop && !capa.loop_supported) { + if (config->enable_loop && !capa.config.enable_loop) { ODP_ERR("Loopback mode not supported\n"); return -1; }