From patchwork Wed Oct 18 09:00:03 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Github ODP bot X-Patchwork-Id: 116248 Delivered-To: patch@linaro.org Received: by 10.140.22.163 with SMTP id 32csp5831114qgn; Wed, 18 Oct 2017 02:06:57 -0700 (PDT) X-Google-Smtp-Source: ABhQp+SnwLArao8P3QJvFiQvXiDa15KSM+3hjjG34c0AwG7+6ZWBLYBnT/XcNQxzzOcrukD5EC0u X-Received: by 10.36.73.99 with SMTP id z96mr9309416ita.36.1508317617154; Wed, 18 Oct 2017 02:06:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1508317617; cv=none; d=google.com; s=arc-20160816; b=tHDr7xv0FSkMVt1dZOe/QAwSpE0C8/rkF2fI1Thl7qNbTXi+tKrmrmpmhiwiGKHH1M PMo4m1rnfpqlwqasoJN+eD17rME6uNUQ0+UNRfB8WQrBcdDlT8xclpnWnvuX0MvZhEKs VWm/sTEOJ8WiM4NIu99NqFQpFr7xofbUqM8ic3qaj1NYW1SyZ+hQrGUIdErMg1bjv2yd vi3fdprHQ0/4/9oYZ5kUCw7SATKfCsxNJkIcgB8MWAPKlAnrUBO2ZbrMtQ8xl+69TMoC ow7LCG6O3cuvMlbZ/tXX0oH/uqw1wbT2YFjhGUKQMadGrNX1doNiaNr1vMM0MtvqQuTQ nPyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:github-pr-num :references:in-reply-to:message-id:date:to:from:delivered-to :arc-authentication-results; bh=Vqo0400HEnQkxItbhIIutautioGWeSe8O8XJ8upPw9k=; b=VkIHJ48Q4C2un0J/ipMAr5nqJTmhfH9gAdbS6618vXA0xIIuqMsgaDllmvkFnfVx3G Hoylz41WNgyoM3okdY3nByj1IpDxmiUVgrFYun6XHKH2IC5qJcBGDNctjq15BSLhIoN/ c5MYOrS4vY2sMNwZP5D/q2gW7jZqSiYUAxz16Ionr6RSsww0bkmiurVBYTYVBsTSbL+F 2lNyyLrQ63iSbsgQ6a4zWBwJq7jT1sAn93LGOa2DB3Vm0nTNZC/wed9UJCWQw0aUebGT 9/Ltx2ZTIXzGRBg/FoXkPfgVpqeCI3nivk66IXhp4RFZoYkNZ6y5WylPl6kxAXB9Rpug sqPg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.197.127.237 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=yandex.ru Return-Path: Received: from lists.linaro.org (ec2-54-197-127-237.compute-1.amazonaws.com. [54.197.127.237]) by mx.google.com with ESMTP id k12si8626236iok.66.2017.10.18.02.06.56; Wed, 18 Oct 2017 02:06:57 -0700 (PDT) Received-SPF: pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.197.127.237 as permitted sender) client-ip=54.197.127.237; Authentication-Results: mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.197.127.237 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=yandex.ru Received: by lists.linaro.org (Postfix, from userid 109) id 9C80E62D9D; Wed, 18 Oct 2017 09:06:56 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ip-10-142-244-252 X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,URIBL_BLOCKED autolearn=disabled version=3.4.0 Received: from [127.0.0.1] (localhost [127.0.0.1]) by lists.linaro.org (Postfix) with ESMTP id 22D8F62CE5; Wed, 18 Oct 2017 09:01:17 +0000 (UTC) X-Original-To: lng-odp@lists.linaro.org Delivered-To: lng-odp@lists.linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id 4EE6762AE3; Wed, 18 Oct 2017 09:00:35 +0000 (UTC) Received: from forward104o.mail.yandex.net (forward104o.mail.yandex.net [37.140.190.179]) by lists.linaro.org (Postfix) with ESMTPS id 98D6462C83 for ; Wed, 18 Oct 2017 09:00:26 +0000 (UTC) Received: from mxback15g.mail.yandex.net (mxback15g.mail.yandex.net [IPv6:2a02:6b8:0:1472:2741:0:8b7:94]) by forward104o.mail.yandex.net (Yandex) with ESMTP id 91F0D702D4B for ; Wed, 18 Oct 2017 12:00:21 +0300 (MSK) Received: from smtp1j.mail.yandex.net (smtp1j.mail.yandex.net [2a02:6b8:0:801::ab]) by mxback15g.mail.yandex.net (nwsmtp/Yandex) with ESMTP id PmKbRGq7bc-0Ln8fgrm; Wed, 18 Oct 2017 12:00:21 +0300 Received: by smtp1j.mail.yandex.net (nwsmtp/Yandex) with ESMTPSA id bYy1BTB7pX-0Kb0GrAV; Wed, 18 Oct 2017 12:00:21 +0300 (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (Client certificate not present) From: Github ODP bot To: lng-odp@lists.linaro.org Date: Wed, 18 Oct 2017 12:00:03 +0300 Message-Id: <1508317209-23610-5-git-send-email-odpbot@yandex.ru> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1508317209-23610-1-git-send-email-odpbot@yandex.ru> References: <1508317209-23610-1-git-send-email-odpbot@yandex.ru> Github-pr-num: 235 Subject: [lng-odp] [PATCH v4 4/10] configure: cleanup per-platform if X-BeenThere: lng-odp@lists.linaro.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: "The OpenDataPlane \(ODP\) List" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: lng-odp-bounces@lists.linaro.org Sender: "lng-odp" From: Dmitry Eremin-Solenikov Move setting IMPLEMENTATION_NAME to platform configure.m4. Use AS_IF instead of handcoded if. Use AC_MSG_ERROR instead of echo & exit. Signed-off-by: Dmitry Eremin-Solenikov --- /** Email created from pull request 235 (lumag:plat-def-2) ** https://github.com/Linaro/odp/pull/235 ** Patch: https://github.com/Linaro/odp/pull/235.patch ** Base sha: ec0c3145fcafa09ae3a79875e7e07dd4794583cc ** Merge commit sha: 3ecb623742a4220d83aa8929d5eef60c1abdeb45 **/ configure.ac | 12 +++--------- platform/linux-generic/m4/configure.m4 | 2 ++ 2 files changed, 5 insertions(+), 9 deletions(-) diff --git a/configure.ac b/configure.ac index 89ff486ff..4bce0534b 100644 --- a/configure.ac +++ b/configure.ac @@ -165,15 +165,9 @@ AC_SUBST([with_platform]) ########################################################################## # Run platform specific checks and settings ########################################################################## -IMPLEMENTATION_NAME="" -if test "${with_platform}" = "linux-generic"; -then - m4_include([./platform/linux-generic/m4/configure.m4]) - IMPLEMENTATION_NAME="odp-linux" -else - echo "UNSUPPORTED PLATFORM: ${with_platform}" - exit 1 -fi +AS_IF([test "${with_platform}" = "linux-generic"], + [m4_include([./platform/linux-generic/m4/configure.m4])], + [AC_MSG_ERROR([UNSUPPORTED PLATFORM: ${with_platform}])]) AC_DEFINE_UNQUOTED([IMPLEMENTATION_NAME], ["$IMPLEMENTATION_NAME"], [Define to the name of the implementation]) diff --git a/platform/linux-generic/m4/configure.m4 b/platform/linux-generic/m4/configure.m4 index 68a270d89..5d7ad35a1 100644 --- a/platform/linux-generic/m4/configure.m4 +++ b/platform/linux-generic/m4/configure.m4 @@ -1,3 +1,5 @@ +IMPLEMENTATION_NAME="odp-linux" + ODP_VISIBILITY ODP_ATOMIC