From patchwork Wed Dec 27 19:00:07 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Github ODP bot X-Patchwork-Id: 122816 Delivered-To: patch@linaro.org Received: by 10.140.22.227 with SMTP id 90csp2541952qgn; Wed, 27 Dec 2017 11:01:57 -0800 (PST) X-Google-Smtp-Source: ACJfBotVoG7gjX9R1JmI/saCMJjkScgOdaXX0EXj5L9bqpJ8B0LX5aXphqo4JgU8VhI7vy813paP X-Received: by 10.200.55.212 with SMTP id e20mr40335068qtc.295.1514401317093; Wed, 27 Dec 2017 11:01:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1514401317; cv=none; d=google.com; s=arc-20160816; b=A+OXZYEy3TDhI3dF2ThqrR2H5XE40QbDPYUEUqLkfge6qhwgMvRX+RSx+ET5C4JODx p/LzLgSzXn17lL2ZZgTLDI2sBzABVus5m/M5df6wmi1NSer6cTFuLAFN7LTM+IaUy35n DM0YPTHaYEKj9ZUiqoQ78u4r3/Hr9htjuGXJgELwR4ue9I/N6TvcCZv0uiHX56hE7nig mIhxAEL2BXJ/zE2KRTKsb0j1felRz78Z5WGgz9LkylICuVuLjFdR8dWDgpBBfzipRHvL F3ESDCLbs6b1Qa652Iq1WOGpX9giw0IsP2XiurHofozC+RwtsyIRih1wbj8wr5NE8hmD XCrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:github-pr-num :references:in-reply-to:message-id:date:to:from:delivered-to :arc-authentication-results; bh=4Bnl5EkRv05fhNguUDbOYrS7K7T82nXKh0qpbtMiegs=; b=eyDubo2vvfoOAOCGzwXj1VCFOCAJAHgV/bi3lYcZ/Uh6Htw/deMLQJxxnC5Z041fRW Ju3HcAL6HzpjVL8koPU1UZS03iVoF6x0Ja8hv7fbc//dnrW5mPlQXjNabDnLQ+8ePnaR 7v1mxdc77LnO/OM68j0eEcdb3Ohesh0JI+RcAysfenPrSN57u62bSySi2hu45oIUekGM E5UpZob88ZL7c9evxQczo3I8hAlfcaeMQMUuOxRg2M1T6C/fpO2eBMEBtfXPiPIZ9fLG S9J26EglmBREzgXeLgPlPBaFQvMfiWIlw9jph0UVIHS9+bYBfuUTRabVXZklVhhcWXJZ 4qng== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.197.127.237 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=yandex.ru Return-Path: Received: from lists.linaro.org (ec2-54-197-127-237.compute-1.amazonaws.com. [54.197.127.237]) by mx.google.com with ESMTP id q22si2875732qtk.165.2017.12.27.11.01.56; Wed, 27 Dec 2017 11:01:57 -0800 (PST) Received-SPF: pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.197.127.237 as permitted sender) client-ip=54.197.127.237; Authentication-Results: mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.197.127.237 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=yandex.ru Received: by lists.linaro.org (Postfix, from userid 109) id C80306095F; Wed, 27 Dec 2017 19:01:56 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ip-10-142-244-252 X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,URIBL_BLOCKED autolearn=disabled version=3.4.0 Received: from [127.0.0.1] (localhost [127.0.0.1]) by lists.linaro.org (Postfix) with ESMTP id A751D60940; Wed, 27 Dec 2017 19:00:25 +0000 (UTC) X-Original-To: lng-odp@lists.linaro.org Delivered-To: lng-odp@lists.linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id 05A3D608E2; Wed, 27 Dec 2017 19:00:16 +0000 (UTC) Received: from forward106o.mail.yandex.net (forward106o.mail.yandex.net [37.140.190.187]) by lists.linaro.org (Postfix) with ESMTPS id 3DC33608A4 for ; Wed, 27 Dec 2017 19:00:12 +0000 (UTC) Received: from mxback9g.mail.yandex.net (mxback9g.mail.yandex.net [IPv6:2a02:6b8:0:1472:2741:0:8b7:170]) by forward106o.mail.yandex.net (Yandex) with ESMTP id D1CBC784D01 for ; Wed, 27 Dec 2017 22:00:10 +0300 (MSK) Received: from smtp1p.mail.yandex.net (smtp1p.mail.yandex.net [2a02:6b8:0:1472:2741:0:8b6:6]) by mxback9g.mail.yandex.net (nwsmtp/Yandex) with ESMTP id NG9yrHHTrQ-0AmCq7aq; Wed, 27 Dec 2017 22:00:10 +0300 Received: by smtp1p.mail.yandex.net (nwsmtp/Yandex) with ESMTPSA id 3rv1tnIVjQ-0Av0AcG9; Wed, 27 Dec 2017 22:00:10 +0300 (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (Client certificate not present) From: Github ODP bot To: lng-odp@lists.linaro.org Date: Wed, 27 Dec 2017 22:00:07 +0300 Message-Id: <1514401208-30010-3-git-send-email-odpbot@yandex.ru> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1514401208-30010-1-git-send-email-odpbot@yandex.ru> References: <1514401208-30010-1-git-send-email-odpbot@yandex.ru> Github-pr-num: 374 Subject: [lng-odp] [PATCH API-NEXT v2 2/3] validation: crypto, ipsec: stop supporting DES operation X-BeenThere: lng-odp@lists.linaro.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: "The OpenDataPlane \(ODP\) List" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: lng-odp-bounces@lists.linaro.org Sender: "lng-odp" From: Dmitry Eremin-Solenikov RFC 7321 (and RFC 8221) mark single-key DES as 'MUST NOT' be implemented. Single-key DES is being phased out of ODP, so drop its support. Signed-off-by: Dmitry Eremin-Solenikov --- /** Email created from pull request 374 (lumag:no-des) ** https://github.com/Linaro/odp/pull/374 ** Patch: https://github.com/Linaro/odp/pull/374.patch ** Base sha: a7b46491ca049998dc38b0a5b29213a407931523 ** Merge commit sha: 681726cebb6b8b580b1180f1c97eb29176d20b8c **/ test/validation/api/crypto/odp_crypto_test_inp.c | 9 --------- test/validation/api/ipsec/ipsec.c | 4 ---- 2 files changed, 13 deletions(-) diff --git a/test/validation/api/crypto/odp_crypto_test_inp.c b/test/validation/api/crypto/odp_crypto_test_inp.c index f1da6989c..0f3f800ac 100644 --- a/test/validation/api/crypto/odp_crypto_test_inp.c +++ b/test/validation/api/crypto/odp_crypto_test_inp.c @@ -62,8 +62,6 @@ static const char *cipher_alg_name(odp_cipher_alg_t cipher) switch (cipher) { case ODP_CIPHER_ALG_NULL: return "ODP_CIPHER_ALG_NULL"; - case ODP_CIPHER_ALG_DES: - return "ODP_CIPHER_ALG_DES"; case ODP_CIPHER_ALG_3DES_CBC: return "ODP_CIPHER_ALG_3DES_CBC"; case ODP_CIPHER_ALG_AES_CBC: @@ -339,9 +337,6 @@ static void alg_test(odp_crypto_op_t op, if (cipher_alg == ODP_CIPHER_ALG_AES_GCM && !(capa.ciphers.bit.aes_gcm)) rc = -1; - if (cipher_alg == ODP_CIPHER_ALG_DES && - !(capa.ciphers.bit.des)) - rc = -1; if (cipher_alg == ODP_CIPHER_ALG_NULL && !(capa.ciphers.bit.null)) rc = -1; @@ -560,10 +555,6 @@ static int check_alg_support(odp_cipher_alg_t cipher, odp_auth_alg_t auth) if (!capability.ciphers.bit.null) return ODP_TEST_INACTIVE; break; - case ODP_CIPHER_ALG_DES: - if (!capability.ciphers.bit.des) - return ODP_TEST_INACTIVE; - break; case ODP_CIPHER_ALG_3DES_CBC: if (!capability.ciphers.bit.trides_cbc) return ODP_TEST_INACTIVE; diff --git a/test/validation/api/ipsec/ipsec.c b/test/validation/api/ipsec/ipsec.c index ea3cff052..effe6fb02 100644 --- a/test/validation/api/ipsec/ipsec.c +++ b/test/validation/api/ipsec/ipsec.c @@ -157,10 +157,6 @@ int ipsec_check(odp_bool_t ah, if (!capa.ciphers.bit.null) return ODP_TEST_INACTIVE; break; - case ODP_CIPHER_ALG_DES: - if (!capa.ciphers.bit.des) - return ODP_TEST_INACTIVE; - break; case ODP_CIPHER_ALG_3DES_CBC: if (!capa.ciphers.bit.trides_cbc) return ODP_TEST_INACTIVE;