| Message ID | 20170712135438.22191-1-petri.savolainen@linaro.org |
|---|---|
| State | Accepted |
| Commit | 81ed733db4cafba894785ffe6c7aa4568b64ed91 |
| Headers | show |
| Series | [API-NEXT,v3,1/9] api: ipsec: add salt parameter | expand |
On 12.07.2017 16:54, Petri Savolainen wrote: > Added a parameter for passing salt/nonce for algorithms that > need it. Currently, only AES GCM needs it with 4 bytes of > salt. Later on, other cipher (or auth) algorithms may need > also salt/nonce data. > > Signed-off-by: Petri Savolainen <petri.savolainen@linaro.org> Whole series: Reviewed-by: Dmitry Eremin-Solenikov <dmitry.ereminsolenikov@linaro.org> -- With best wishes Dmitry
For the series: Reviewed-by: Balasubramanian Manoharan <bala.manoharan@linaro.org> On 12 July 2017 at 19:24, Petri Savolainen <petri.savolainen@linaro.org> wrote: > Added a parameter for passing salt/nonce for algorithms that > need it. Currently, only AES GCM needs it with 4 bytes of > salt. Later on, other cipher (or auth) algorithms may need > also salt/nonce data. > > Signed-off-by: Petri Savolainen <petri.savolainen@linaro.org> > --- > include/odp/api/spec/ipsec.h | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/include/odp/api/spec/ipsec.h b/include/odp/api/spec/ipsec.h > index e602e4b8..9f061961 100644 > --- a/include/odp/api/spec/ipsec.h > +++ b/include/odp/api/spec/ipsec.h > @@ -378,6 +378,15 @@ typedef struct odp_ipsec_crypto_param_t { > /** Cipher key */ > odp_crypto_key_t cipher_key; > > + /** Extra keying material for cipher key > + * > + * Additional data used as salt or nonce if the algorithm > requires it, > + * other algorithms ignore this field. These algorithms require > this > + * field set: > + * - AES_GCM: 4 bytes of salt > + **/ > + odp_crypto_key_t cipher_key_extra; > + > /** Authentication algorithm */ > odp_auth_alg_t auth_alg; > > -- > 2.13.0 > >
Merged. On 07/13/17 17:30, Bala Manoharan wrote: > For the series: > Reviewed-by: Balasubramanian Manoharan <bala.manoharan@linaro.org> > > > On 12 July 2017 at 19:24, Petri Savolainen <petri.savolainen@linaro.org> > wrote: > >> Added a parameter for passing salt/nonce for algorithms that >> need it. Currently, only AES GCM needs it with 4 bytes of >> salt. Later on, other cipher (or auth) algorithms may need >> also salt/nonce data. >> >> Signed-off-by: Petri Savolainen <petri.savolainen@linaro.org> >> --- >> include/odp/api/spec/ipsec.h | 9 +++++++++ >> 1 file changed, 9 insertions(+) >> >> diff --git a/include/odp/api/spec/ipsec.h b/include/odp/api/spec/ipsec.h >> index e602e4b8..9f061961 100644 >> --- a/include/odp/api/spec/ipsec.h >> +++ b/include/odp/api/spec/ipsec.h >> @@ -378,6 +378,15 @@ typedef struct odp_ipsec_crypto_param_t { >> /** Cipher key */ >> odp_crypto_key_t cipher_key; >> >> + /** Extra keying material for cipher key >> + * >> + * Additional data used as salt or nonce if the algorithm >> requires it, >> + * other algorithms ignore this field. These algorithms require >> this >> + * field set: >> + * - AES_GCM: 4 bytes of salt >> + **/ >> + odp_crypto_key_t cipher_key_extra; >> + >> /** Authentication algorithm */ >> odp_auth_alg_t auth_alg; >> >> -- >> 2.13.0 >> >>
For the series: Reviewed-by: Nikhil Agarwal <Nikhil.agarwal@linaro.org> -----Original Message----- From: lng-odp [mailto:lng-odp-bounces@lists.linaro.org] On Behalf Of Petri Savolainen Sent: Wednesday, July 12, 2017 7:25 PM To: lng-odp@lists.linaro.org Subject: [lng-odp] [API-NEXT PATCH v3 1/9] api: ipsec: add salt parameter Added a parameter for passing salt/nonce for algorithms that need it. Currently, only AES GCM needs it with 4 bytes of salt. Later on, other cipher (or auth) algorithms may need also salt/nonce data. Signed-off-by: Petri Savolainen <petri.savolainen@linaro.org> --- include/odp/api/spec/ipsec.h | 9 +++++++++ 1 file changed, 9 insertions(+) -- 2.13.0diff --git a/include/odp/api/spec/ipsec.h b/include/odp/api/spec/ipsec.h index e602e4b8..9f061961 100644 --- a/include/odp/api/spec/ipsec.h +++ b/include/odp/api/spec/ipsec.h @@ -378,6 +378,15 @@ typedef struct odp_ipsec_crypto_param_t { /** Cipher key */ odp_crypto_key_t cipher_key; + /** Extra keying material for cipher key + * + * Additional data used as salt or nonce if the algorithm requires it, + * other algorithms ignore this field. These algorithms require this + * field set: + * - AES_GCM: 4 bytes of salt + **/ + odp_crypto_key_t cipher_key_extra; + /** Authentication algorithm */ odp_auth_alg_t auth_alg;
diff --git a/include/odp/api/spec/ipsec.h b/include/odp/api/spec/ipsec.h index e602e4b8..9f061961 100644 --- a/include/odp/api/spec/ipsec.h +++ b/include/odp/api/spec/ipsec.h @@ -378,6 +378,15 @@ typedef struct odp_ipsec_crypto_param_t { /** Cipher key */ odp_crypto_key_t cipher_key; + /** Extra keying material for cipher key + * + * Additional data used as salt or nonce if the algorithm requires it, + * other algorithms ignore this field. These algorithms require this + * field set: + * - AES_GCM: 4 bytes of salt + **/ + odp_crypto_key_t cipher_key_extra; + /** Authentication algorithm */ odp_auth_alg_t auth_alg;
Added a parameter for passing salt/nonce for algorithms that need it. Currently, only AES GCM needs it with 4 bytes of salt. Later on, other cipher (or auth) algorithms may need also salt/nonce data. Signed-off-by: Petri Savolainen <petri.savolainen@linaro.org> --- include/odp/api/spec/ipsec.h | 9 +++++++++ 1 file changed, 9 insertions(+) -- 2.13.0