From patchwork Mon Apr 18 19:35:39 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anders Roxell X-Patchwork-Id: 66051 Delivered-To: patch@linaro.org Received: by 10.140.93.198 with SMTP id d64csp1463784qge; Mon, 18 Apr 2016 12:38:37 -0700 (PDT) X-Received: by 10.50.34.130 with SMTP id z2mr375237igi.82.1461008317274; Mon, 18 Apr 2016 12:38:37 -0700 (PDT) Return-Path: Received: from lists.linaro.org (lists.linaro.org. [54.225.227.206]) by mx.google.com with ESMTP id 101si23293833iom.2.2016.04.18.12.38.36; Mon, 18 Apr 2016 12:38:37 -0700 (PDT) Received-SPF: pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) client-ip=54.225.227.206; Authentication-Results: mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dmarc=pass (p=NONE dis=NONE) header.from=linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id 7882761724; Mon, 18 Apr 2016 19:38:36 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ip-10-142-244-252 X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, URIBL_BLOCKED autolearn=disabled version=3.4.0 Received: from [127.0.0.1] (localhost [127.0.0.1]) by lists.linaro.org (Postfix) with ESMTP id 1A0F7674B9; Mon, 18 Apr 2016 19:38:32 +0000 (UTC) X-Original-To: lng-odp@lists.linaro.org Delivered-To: lng-odp@lists.linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id 38BAA68875; Mon, 18 Apr 2016 19:38:25 +0000 (UTC) Received: from mail-ig0-f171.google.com (mail-ig0-f171.google.com [209.85.213.171]) by lists.linaro.org (Postfix) with ESMTPS id 1F0AD68854 for ; Mon, 18 Apr 2016 19:35:40 +0000 (UTC) Received: by mail-ig0-f171.google.com with SMTP id y9so34227092igg.1 for ; Mon, 18 Apr 2016 12:35:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=69hW3z754NDzcurMkh7996s9X0F27ijNaLV2E+kNIT4=; b=OmdeYoMu6Z7RL3HNl80hH/M65L1lh1ws8GEsYML0b2bz/6yF8n3jk4L8TGWaemOLxC fJD26y8C4elWYwlmY17JdJyUA+9cV9xZzWSVbx4eshdGiPrWH96iquiQQdhfhLA0B1Ld TV05Sn8X6Vb+LfyJTQujE0HgvN3HpfIHnU9WP+uul4l2Ck4hQzR6kIHIHQQJ0c7rBwPK h2T5fGV/PxBLchhUvq5OMVFkYBp27U3W0oxbDO5qEjEVtpAblsIIW8hGvDyriubMO8zj cZ9zoIFGOCzrLhw36QIIDgHF/7i7EQS2jhsg7HMqBX56eXJerKX9FNHJCT7kdhgTzgBp kqIQ== X-Gm-Message-State: AOPr4FVTAR9f66bs/5HTCER8ievNFKo6zUO/+XAdtZcBABxmKjdCB1yBnimKXg4Rty7pJMPtzHwcTz3VtKnwPrI8eWA= MIME-Version: 1.0 X-Received: by 10.50.144.163 with SMTP id sn3mr21222986igb.26.1461008139615; Mon, 18 Apr 2016 12:35:39 -0700 (PDT) Received: by 10.107.8.217 with HTTP; Mon, 18 Apr 2016 12:35:39 -0700 (PDT) In-Reply-To: <1460998045-3816-1-git-send-email-bill.fischofer@linaro.org> References: <1460998045-3816-1-git-send-email-bill.fischofer@linaro.org> Date: Mon, 18 Apr 2016 21:35:39 +0200 Message-ID: From: Anders Roxell To: Bill Fischofer X-Topics: patch Cc: LNG ODP Mailman List Subject: Re: [lng-odp] [API-NEXT PATCHv5] api: make only the API visible X-BeenThere: lng-odp@lists.linaro.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: "The OpenDataPlane \(ODP\) List" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: lng-odp-bounces@lists.linaro.org Sender: "lng-odp" On 18 April 2016 at 18:47, Bill Fischofer wrote: > From: Anders Roxell > > Internal functions should not be part of symbols that are visible > outside the library. Using -fvisibility=hidden hides all internal > functions from the public ABI. > > Suggested-by: Ricardo Salveti > Signed-off-by: Anders Roxell > Signed-off-by: Bill Fischofer > --- > include/odp/api/spec/align.h | 2 ++ > include/odp/api/spec/atomic.h | 2 ++ > include/odp/api/spec/barrier.h | 2 ++ > include/odp/api/spec/buffer.h | 3 ++- > include/odp/api/spec/byteorder.h | 2 ++ > include/odp/api/spec/classification.h | 3 ++- > include/odp/api/spec/compiler.h | 2 ++ > include/odp/api/spec/config.h | 2 ++ > include/odp/api/spec/cpu.h | 2 ++ > include/odp/api/spec/cpumask.h | 2 ++ > include/odp/api/spec/crypto.h | 2 ++ > include/odp/api/spec/debug.h | 3 ++- > include/odp/api/spec/errno.h | 2 ++ > include/odp/api/spec/event.h | 3 ++- > include/odp/api/spec/hash.h | 2 ++ > include/odp/api/spec/hints.h | 2 ++ > include/odp/api/spec/init.h | 4 ++-- > include/odp/api/spec/packet.h | 2 ++ > include/odp/api/spec/packet_flags.h | 2 ++ > include/odp/api/spec/packet_io.h | 2 ++ > include/odp/api/spec/packet_io_stats.h | 2 ++ > include/odp/api/spec/pool.h | 4 ++-- > include/odp/api/spec/queue.h | 2 ++ > include/odp/api/spec/random.h | 3 ++- > include/odp/api/spec/rwlock.h | 2 ++ > include/odp/api/spec/rwlock_recursive.h | 2 ++ > include/odp/api/spec/schedule.h | 3 ++- > include/odp/api/spec/schedule_types.h | 2 ++ > include/odp/api/spec/shared_memory.h | 3 ++- > include/odp/api/spec/spinlock.h | 2 ++ > include/odp/api/spec/spinlock_recursive.h | 2 ++ > include/odp/api/spec/std_clib.h | 2 ++ > include/odp/api/spec/std_types.h | 3 ++- > include/odp/api/spec/sync.h | 2 ++ > include/odp/api/spec/system_info.h | 3 ++- > include/odp/api/spec/thread.h | 2 ++ > include/odp/api/spec/thrmask.h | 2 ++ > include/odp/api/spec/ticketlock.h | 2 ++ > include/odp/api/spec/time.h | 3 ++- > include/odp/api/spec/timer.h | 2 ++ > include/odp/api/spec/traffic_mngr.h | 2 ++ > include/odp/api/spec/version.h | 2 ++ > platform/Makefile.inc | 1 + > platform/linux-generic/include/odp/api/abi_begin.h | 3 +++ > platform/linux-generic/include/odp/api/abi_end.h | 3 +++ > platform/linux-generic/m4/configure.m4 | 12 ++++++++++++ > 46 files changed, 103 insertions(+), 14 deletions(-) > create mode 100644 platform/linux-generic/include/odp/api/abi_begin.h > create mode 100644 platform/linux-generic/include/odp/api/abi_end.h > Looks good, except that I think you missed this: make distcheck finds this wee problem: make[1]: Entering directory '/media/data/src/odp/crap/opendataplane-1.8.0.1.git574.g91c3d48.dirty/_build' Making all in platform/linux-generic make[2]: Entering directory '/media/data/src/odp/crap/opendataplane-1.8.0.1.git574.g91c3d48.dirty/_build/platform/linux-generic' CC odp_atomic.lo In file included from ../../../platform/linux-generic/include/odp/api/align.h:54:0, from ../../../platform/linux-generic/include/odp/api/atomic.h:20, from ../../../platform/linux-generic/odp_atomic.c:7: ../../../include/odp/api/spec/align.h:16:31: fatal error: odp/api/abi_begin.h: No such file or directory #include ^ compilation terminated. Makefile:809: recipe for target 'odp_atomic.lo' failed make[2]: *** [odp_atomic.lo] Error 1 make[2]: Leaving directory '/media/data/src/odp/crap/opendataplane-1.8.0.1.git574.g91c3d48.dirty/_build/platform/linux-generic' Makefile:457: recipe for target 'all-recursive' failed make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory '/media/data/src/odp/crap/opendataplane-1.8.0.1.git574.g91c3d48.dirty/_build' Makefile:663: recipe for target 'distcheck' failed make: *** [distcheck] Error 1 Cheers, Anders diff --git a/platform/linux-generic/Makefile.am b/platform/linux-generic/Makefile.am index 5eb8cbc..bc5573d 100644 --- a/platform/linux-generic/Makefile.am +++ b/platform/linux-generic/Makefile.am @@ -16,6 +16,8 @@ include_HEADERS = \ odpapiincludedir= $(includedir)/odp/api odpapiinclude_HEADERS = \ $(srcdir)/include/odp/api/align.h \ + $(srcdir)/include/odp/api/abi_begin.h \ + $(srcdir)/include/odp/api/abi_end.h \ $(srcdir)/include/odp/api/atomic.h \ $(srcdir)/include/odp/api/barrier.h \ $(srcdir)/include/odp/api/buffer.h \